Skip to content

Commit 4fce740

Browse files
JarlJarl
authored andcommitted
test(server): verify each provider template reaches PR generation
1 parent d7b8e45 commit 4fce740

1 file changed

Lines changed: 36 additions & 17 deletions

File tree

‎apps/server/src/git/GitManager.test.ts‎

Lines changed: 36 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,8 @@ import {
4747
import * as DateTime from "effect/DateTime";
4848
import { decodeGitHubPullRequestListJson } from "@t3tools/source-control-github/server/gitHubPullRequests";
4949
import * as GitHubChangeRequestTemplate from "@t3tools/source-control-github/server/gitHubChangeRequestTemplate";
50+
import * as AzureDevOpsCli from "@t3tools/source-control-azure-devops/server/AzureDevOpsCli";
51+
import * as AzureDevOpsSourceControlProvider from "@t3tools/source-control-azure-devops/server/AzureDevOpsSourceControlProvider";
5052
import * as GitLabCli from "@t3tools/source-control-gitlab/server/GitLabCli";
5153
import type * as SourceControlHost from "@t3tools/source-control-core/server/SourceControlHost";
5254
import * as TestSourceControlHost from "@t3tools/source-control-testing/TestSourceControlHost";
@@ -814,17 +816,28 @@ function makeManager(input?: {
814816
const layerSourceControlRegistry = Layer.effect(
815817
SourceControlProviderRegistry.SourceControlProviderRegistry,
816818
Effect.gen(function* () {
817-
// GitHub reads its PR template with git, which the fake gh cannot answer; give the fake
818-
// the package's real reader over the test repository's git.
819+
if (input?.sourceControlProvider) return input.sourceControlProvider;
819820
const git = yield* GitVcsDriver.GitVcsDriver;
820-
return (
821-
input?.sourceControlProvider ?? {
822-
...fakeGitHubProvider,
823-
kind: input?.sourceControlProviderKind ?? fakeGitHubProvider.kind,
824-
readChangeRequestTemplate: ({ cwd, treeish }: { cwd: string; treeish: string }) =>
825-
GitHubChangeRequestTemplate.detect(cwd, treeish, git.execute),
826-
}
827-
);
821+
const kind = input?.sourceControlProviderKind ?? fakeGitHubProvider.kind;
822+
let readChangeRequestTemplate: SourceControlProvider["Service"]["readChangeRequestTemplate"] =
823+
({ cwd, treeish }) => GitHubChangeRequestTemplate.detect(cwd, treeish, git.execute);
824+
if (kind === "gitlab" || kind === "azure-devops") {
825+
const provider = yield* (
826+
kind === "gitlab"
827+
? GitLabSourceControlProvider.make.pipe(
828+
Effect.provide(Layer.mock(GitLabCli.GitLabCli)({})),
829+
)
830+
: AzureDevOpsSourceControlProvider.make.pipe(
831+
Effect.provide(Layer.mock(AzureDevOpsCli.AzureDevOpsCli)({})),
832+
)
833+
).pipe(Effect.provide(TestSourceControlHost.layer({ git: { execute: git.execute } })));
834+
readChangeRequestTemplate = provider.readChangeRequestTemplate;
835+
}
836+
return {
837+
...fakeGitHubProvider,
838+
kind,
839+
...(readChangeRequestTemplate ? { readChangeRequestTemplate } : {}),
840+
};
828841
}).pipe(
829842
Effect.map((provider) =>
830843
SourceControlProviderRegistry.SourceControlProviderRegistry.of({
@@ -4909,12 +4922,18 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
49094922
Effect.gen(function* () {
49104923
const repoDir = yield* makeTempDir("t3code-git-manager-");
49114924
yield* initRepo(repoDir);
4912-
NodeFS.mkdirSync(NodePath.join(repoDir, ".github"));
4913-
NodeFS.writeFileSync(
4914-
NodePath.join(repoDir, ".github", "pull_request_template.md"),
4915-
"## What changed?\n\n## Verification",
4916-
);
4917-
yield* runGit(repoDir, ["add", ".github/pull_request_template.md"]);
4925+
const templatePaths = {
4926+
github: ".github/pull_request_template.md",
4927+
gitlab: ".gitlab/merge_request_templates/Default.md",
4928+
"azure-devops": ".azuredevops/pull_request_template.md",
4929+
};
4930+
const templateContent = (provider: string) => `## ${provider} context\n\n## Verification`;
4931+
for (const [provider, relativePath] of Object.entries(templatePaths)) {
4932+
const templatePath = NodePath.join(repoDir, relativePath);
4933+
NodeFS.mkdirSync(NodePath.dirname(templatePath), { recursive: true });
4934+
NodeFS.writeFileSync(templatePath, templateContent(provider));
4935+
}
4936+
yield* runGit(repoDir, ["add", ...Object.values(templatePaths)]);
49184937
yield* runGit(repoDir, ["commit", "-m", "Add pull request template"]);
49194938
yield* runGit(repoDir, ["checkout", "-b", "feature-create-pr"]);
49204939
const remoteDir = yield* createBareRemote();
@@ -4971,7 +4990,7 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
49714990
expect(generatedPolicy).toMatchObject({
49724991
changeRequestInstructions: "Lead with user impact.",
49734992
});
4974-
expect(generatedChangeRequestTemplate).toBe("## What changed?\n\n## Verification");
4993+
expect(generatedChangeRequestTemplate).toBe(templateContent(kind));
49754994
expect(ghCalls.filter((call) => call.startsWith("pr list "))).toHaveLength(2);
49764995
expect(
49774996
ghCalls.some((call) => call.includes("pr create --base main --head feature-create-pr")),

0 commit comments

Comments
 (0)