Skip to content

Commit 4f4a6cf

Browse files
committed
fix(web): avoid claiming checks passed before details load
1 parent dab5157 commit 4f4a6cf

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

‎apps/web/src/components/pullRequest/PullRequestGhosts.tsx‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,9 +92,11 @@ export function PullRequestDetailGhost({
9292
isDraft: seed.isDraft ?? false,
9393
})
9494
: null;
95-
const checksPresentation = seed?.checksState
96-
? pullRequestChecksStatePresentation(seed.checksState)
97-
: null;
95+
// Passing list rollups can omit workflows awaiting approval; wait for detail to claim success.
96+
const checksPresentation =
97+
seed?.checksState === "failing" || seed?.checksState === "pending"
98+
? pullRequestChecksStatePresentation(seed.checksState)
99+
: null;
98100

99101
return (
100102
<div

0 commit comments

Comments
 (0)