Skip to content

Commit 4e48d9e

Browse files
t3dotggclaude
andauthored
test(web): HTML preview accordion test waits for the frame's script before it toggles (#35359)
Co-authored-by: Claude Fable 5.2 <[email protected]>
1 parent 69dd4d0 commit 4e48d9e

1 file changed

Lines changed: 11 additions & 1 deletion

File tree

‎apps/web/src/components/chat/MessagesTimeline.browser.test.tsx‎

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,9 +228,18 @@ describe("MessagesTimeline work rows", () => {
228228
const props = baseProps();
229229
const html = injectHtmlRenderBootstrap(`<div style="height:1400px">Earlier preview content</div>
230230
<details><summary>More rows</summary><div style="height:900px">More rows</div></details>
231-
<script>addEventListener('message', e => { if(e.data === 'toggle') document.querySelector('details').open = !document.querySelector('details').open; });</script>`);
231+
<script>addEventListener('message', e => { if(e.data === 'toggle') document.querySelector('details').open = !document.querySelector('details').open; }); parent.postMessage('listening', '*');</script>`);
232232
const src = URL.createObjectURL(new Blob([html], { type: "text/html" }));
233233
using _url = { [Symbol.dispose]: () => URL.revokeObjectURL(src) };
234+
// The frame loads on its own clock, and a toggle posted before its script runs is lost.
235+
const listening = new Promise<void>((resolve) => {
236+
const onMessage = (event: MessageEvent) => {
237+
if (event.data !== "listening") return;
238+
window.removeEventListener("message", onMessage);
239+
resolve();
240+
};
241+
window.addEventListener("message", onMessage);
242+
});
234243
function Preview() {
235244
const [height, setHeight] = useState(1437);
236245
return (
@@ -270,6 +279,7 @@ describe("MessagesTimeline work rows", () => {
270279
expect(viewport.scrollTop).toBeGreaterThan(0);
271280
expect(viewport.scrollHeight - viewport.clientHeight - viewport.scrollTop).toBeLessThan(2);
272281
});
282+
await listening;
273283
const top = frame.getBoundingClientRect().top;
274284
frame.focus();
275285
frame.contentWindow!.postMessage("toggle", "*");

0 commit comments

Comments
 (0)