Skip to content

Commit 4e46d97

Browse files
committed
fix(web): unresolved pull request links use the compact link tooltip
1 parent d2c9281 commit 4e46d97

1 file changed

Lines changed: 13 additions & 7 deletions

File tree

‎apps/web/src/components/pullRequest/PullRequestLinkPreview.tsx‎

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ import { useAtomQueryRunner } from "~/state/use-atom-query-runner";
1515
import { useEnvironmentQuery } from "~/state/query";
1616

1717
import { PreviewCard, PreviewCardPopup, PreviewCardTrigger } from "../ui/preview-card";
18+
import { Tooltip, TooltipPopup, TooltipTrigger } from "../ui/tooltip";
1819
import { PullRequestActorAvatar, resolvePullRequestState } from "./pullRequestPresentation";
1920

2021
interface PullRequestLinkPreviewTarget {
@@ -81,6 +82,8 @@ export function PullRequestLinkPreview({
8182
})
8283
: link;
8384
const detail = detailQuery.data;
85+
const showCard = detail !== null || (detailQuery.error !== null && fallback !== undefined);
86+
const showUrlTooltip = open && detailQuery.error !== null && !showCard;
8487
const state =
8588
detail === null
8689
? null
@@ -94,16 +97,19 @@ export function PullRequestLinkPreview({
9497

9598
return (
9699
<PreviewCard open={open} onOpenChange={setOpen}>
97-
<PreviewCardTrigger render={trigger} delay={350} closeDelay={120} />
98-
{detail !== null || detailQuery.error !== null ? (
100+
<Tooltip open={showUrlTooltip}>
101+
<PreviewCardTrigger
102+
render={<TooltipTrigger render={trigger} />}
103+
delay={350}
104+
closeDelay={120}
105+
/>
106+
<TooltipPopup side="top">{originalUrl}</TooltipPopup>
107+
</Tooltip>
108+
{showCard ? (
99109
<PreviewCardPopup align="center" className="w-80 max-w-[calc(100vw-2rem)]">
100110
<div className="p-3">
101111
{detail === null ? (
102-
(fallback ?? (
103-
<p className="text-xs leading-relaxed text-muted-foreground wrap-anywhere">
104-
{originalUrl}
105-
</p>
106-
))
112+
fallback
107113
) : (
108114
<div className="min-w-0">
109115
<div className="flex min-w-0 items-center gap-1.5 text-2xs text-muted-foreground">

0 commit comments

Comments
 (0)