Skip to content

Commit 4df79f1

Browse files
Include fallback values in perf env warnings
Co-authored-by: Julius Marminge <[email protected]>
1 parent d5f676e commit 4df79f1

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

‎scripts/desktop-perf-trace.mjs‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,14 +70,14 @@ function mb(bytes) {
7070
return bytes / (1024 * 1024);
7171
}
7272

73-
function parseNumericEnv({ name, value, predicate, expectation }) {
73+
function parseNumericEnv({ name, value, predicate, expectation, fallback }) {
7474
if (typeof value !== "string") {
7575
return null;
7676
}
7777
const raw = value.trim();
7878
if (raw.length === 0) {
7979
console.warn(
80-
`[desktop-perf] invalid ${name}="${value}" (expected ${expectation}); using default`,
80+
`[desktop-perf] invalid ${name}="${value}" (expected ${expectation}); using ${fallback}`,
8181
);
8282
return null;
8383
}
@@ -89,7 +89,7 @@ function parseNumericEnv({ name, value, predicate, expectation }) {
8989
};
9090
}
9191
console.warn(
92-
`[desktop-perf] invalid ${name}="${value}" (expected ${expectation}); using default`,
92+
`[desktop-perf] invalid ${name}="${value}" (expected ${expectation}); using ${fallback}`,
9393
);
9494
return null;
9595
}
@@ -100,6 +100,7 @@ function resolveNonNegativeNumberEnv({ name, value, fallback }) {
100100
value,
101101
predicate: (parsed) => parsed >= 0,
102102
expectation: "non-negative number",
103+
fallback,
103104
});
104105
return resolved?.parsed ?? fallback;
105106
}
@@ -110,6 +111,7 @@ function resolveNonNegativeIntegerEnv({ name, value, fallback }) {
110111
value,
111112
predicate: (parsed) => parsed >= 0,
112113
expectation: "non-negative number",
114+
fallback,
113115
});
114116
if (!resolved) {
115117
return fallback;
@@ -129,6 +131,7 @@ function resolvePositiveIntegerEnv({ name, value, fallback }) {
129131
value,
130132
predicate: (parsed) => parsed > 0,
131133
expectation: "positive number",
134+
fallback,
132135
});
133136
if (!resolved) {
134137
return fallback;

0 commit comments

Comments
 (0)