Skip to content

Commit 4c795fd

Browse files
committed
fix(mobile): report live recognition timeouts correctly
1 parent 5aef1f3 commit 4c795fd

2 files changed

Lines changed: 12 additions & 3 deletions

File tree

  • apps/mobile/modules/t3-voice-transcription/android/src

‎apps/mobile/modules/t3-voice-transcription/android/src/main/java/expo/modules/t3voicetranscription/PcmOutput.kt‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,12 @@ internal fun livePcmResponses(
9494
capture.awaitFinished()
9595
output.verifyConsumed()
9696
}
97+
} catch (e: TimeoutCancellationException) {
98+
throw VoiceTranscriptionException(
99+
"incomplete-audio",
100+
"Speech recognition did not finish the complete recording. No transcript was added. Retry dictation.",
101+
e
102+
)
97103
} finally {
98104
capture.cancel()
99105
}

‎apps/mobile/modules/t3-voice-transcription/android/src/test/java/expo/modules/t3voicetranscription/LivePcmCaptureTest.kt‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import java.io.File
66
import kotlinx.coroutines.CompletableDeferred
77
import kotlinx.coroutines.CoroutineStart
88
import kotlinx.coroutines.async
9+
import kotlinx.coroutines.awaitCancellation
910
import kotlinx.coroutines.channels.Channel
1011
import kotlinx.coroutines.flow.flow
1112
import kotlinx.coroutines.test.runTest
@@ -98,10 +99,11 @@ class LivePcmCaptureTest {
9899
}
99100
}
100101

101-
@Test fun rejectsPrematureRecognitionAndUnreadCapturedAudio() = runTest {
102-
for (early in listOf(true, false)) {
102+
@Test fun rejectsIncompleteRecognitionAndUnreadCapturedAudio() = runTest {
103+
for (failure in listOf("early", "unread", "timeout")) {
104+
val early = failure == "early"
103105
val source = Source()
104-
val output = Output().apply { unread = !early }
106+
val output = Output().apply { unread = failure == "unread" }
105107
val file = File.createTempFile("live-capture-test-", ".pcm")
106108
val capture = LivePcmCapture(source, file, output, testScheduler.timeSource)
107109
try {
@@ -112,6 +114,7 @@ class LivePcmCaptureTest {
112114
livePcmResponses(capture, output) {
113115
flow {
114116
if (!early) output.ended.await()
117+
if (failure == "timeout") awaitCancellation()
115118
emit(SpeechRecognizerResponse.FinalTextResponse("Incomplete.", emptyList()))
116119
emit(SpeechRecognizerResponse.CompletedResponse)
117120
}

0 commit comments

Comments
 (0)