Skip to content

Commit 4ac8fa4

Browse files
fix(mobile): Android thread pane no longer ends short after switching threads (#18963)
Co-authored-by: Julius Marminge <[email protected]>
1 parent f3161f3 commit 4ac8fa4

1 file changed

Lines changed: 9 additions & 7 deletions

File tree

‎apps/mobile/src/Stack.tsx‎

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,9 @@ const GLASS_HEADER_OPTIONS: AppScreenOptions = {
169169
unstable_navigationItemStyle: NATIVE_LIQUID_GLASS_SUPPORTED ? "editor" : undefined,
170170
};
171171

172-
const PULL_REQUEST_HEADER_OPTIONS: AppScreenOptions = {
172+
// Hiding Android's native header after mount can leave detail panes measured short.
173+
// These screens render their own Material toolbar, so hide it from the first layout.
174+
const DETAIL_HEADER_OPTIONS: AppScreenOptions = {
173175
...GLASS_HEADER_OPTIONS,
174176
headerShown: Platform.OS !== "android",
175177
};
@@ -704,15 +706,15 @@ const RootStackConfig = createWorkspaceStackNavigator({
704706
path: "pull-requests/:environmentId/:projectId/:repository/:number",
705707
parse: { number: Number },
706708
},
707-
options: PULL_REQUEST_HEADER_OPTIONS,
709+
options: DETAIL_HEADER_OPTIONS,
708710
}),
709711
PullRequestGuideStop: createNativeStackScreen({
710712
screen: PullRequestGuideStopScreen,
711-
options: PULL_REQUEST_HEADER_OPTIONS,
713+
options: DETAIL_HEADER_OPTIONS,
712714
}),
713715
PullRequestFile: createNativeStackScreen({
714716
screen: PullRequestFileRouteScreen,
715-
options: PULL_REQUEST_HEADER_OPTIONS,
717+
options: DETAIL_HEADER_OPTIONS,
716718
}),
717719
PullRequestFiles: createNativeStackScreen({
718720
screen: PullRequestFilesRouteScreen,
@@ -726,7 +728,7 @@ const RootStackConfig = createWorkspaceStackNavigator({
726728
PullRequestReviewers: createNativeStackScreen({
727729
screen: PullRequestReviewersScreen,
728730
options: {
729-
...PULL_REQUEST_HEADER_OPTIONS,
731+
...DETAIL_HEADER_OPTIONS,
730732
...FORM_SHEET_PRESENTATION_OPTIONS,
731733
sheetAllowedDetents: [0.75, 0.92],
732734
sheetGrabberVisible: true,
@@ -735,7 +737,7 @@ const RootStackConfig = createWorkspaceStackNavigator({
735737
}),
736738
PullRequestDiscussion: createNativeStackScreen({
737739
screen: PullRequestDiscussionScreen,
738-
options: PULL_REQUEST_HEADER_OPTIONS,
740+
options: DETAIL_HEADER_OPTIONS,
739741
}),
740742
PullRequestInlineComment: createNativeStackScreen({
741743
screen: PullRequestInlineCommentScreen,
@@ -760,7 +762,7 @@ const RootStackConfig = createWorkspaceStackNavigator({
760762
Thread: createNativeStackScreen({
761763
screen: ThreadRouteScreen,
762764
linking: THREAD_LINKING_PREFIX,
763-
options: GLASS_HEADER_OPTIONS,
765+
options: DETAIL_HEADER_OPTIONS,
764766
}),
765767
ThreadTerminal: createNativeStackScreen({
766768
screen: ThreadTerminalRouteScreen,

0 commit comments

Comments
 (0)