Skip to content

Commit 4a0eceb

Browse files
committed
test(issues): await native image rendering and loads
1 parent c73e695 commit 4a0eceb

1 file changed

Lines changed: 18 additions & 1 deletion

File tree

‎apps/web/src/components/issue/IssueMarkdown.media.browser.test.tsx‎

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import { act } from "react";
1919
import { createRoot, type Root } from "react-dom/client";
2020
import { flushSync } from "react-dom";
2121
import { afterAll, afterEach, beforeAll, beforeEach, expect, it, vi } from "vite-plus/test";
22-
import { cdp } from "vite-plus/test/browser";
22+
import { cdp, page } from "vite-plus/test/browser";
2323
import type { CDPSession } from "vite-plus/test/browser-playwright";
2424

2525
const assets = vi.hoisted(() => ({
@@ -186,6 +186,7 @@ beforeEach(() => {
186186
});
187187
afterEach(async () => {
188188
await act(async () => {
189+
await settleImages();
189190
await Promise.all(imageResponses.splice(0));
190191
root.unmount();
191192
});
@@ -198,9 +199,25 @@ async function flush() {
198199
for (let index = 0; index < 5; index += 1) await Promise.resolve();
199200
});
200201
}
202+
async function settleImages() {
203+
await Promise.all(
204+
[...document.images].map((image) => {
205+
if (image.complete) return;
206+
image.loading = "eager";
207+
return new Promise<void>((resolve) => {
208+
image.addEventListener("load", () => resolve(), { once: true });
209+
image.addEventListener("error", () => resolve(), { once: true });
210+
});
211+
}),
212+
);
213+
}
201214
async function render(node: React.ReactNode) {
202215
await act(async () => root.render(<RegistryContext value={registry}>{node}</RegistryContext>));
203216
await flush();
217+
await expect
218+
.element(page.getByRole("status", { name: "Loading image" }).first())
219+
.not.toBeInTheDocument();
220+
await act(settleImages);
204221
}
205222
const sources = () => [...container.querySelectorAll("img")].map((image) => image.src);
206223
const linearResource = { _tag: "linear-media", issue, url: upload };

0 commit comments

Comments
 (0)