Skip to content

Commit 497bf30

Browse files
only21milclaude
andcommitted
test(web): name each settings search composition case
Table rows instead of nested loops, so a failure names its case; Escape rows use keyCode 27. Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 863f683 commit 497bf30

1 file changed

Lines changed: 10 additions & 15 deletions

File tree

‎apps/web/src/components/settings/SettingsSidebarNav.composition.browser.test.tsx‎

Lines changed: 10 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -22,22 +22,17 @@ it("keeps composition Enter and Escape in the search from navigating or clearing
2222
await search.fill("theme");
2323
await expect.element(page.getByRole("option", { name: /Theme/ })).toBeVisible();
2424

25-
for (const nativeEvent of [
26-
{ isComposing: true, keyCode: 13 },
27-
{ isComposing: false, keyCode: 229 },
25+
for (const composition of [
26+
{ key: "Enter", isComposing: true, keyCode: 13 },
27+
{ key: "Enter", isComposing: false, keyCode: 229 },
28+
{ key: "Escape", isComposing: true, keyCode: 27 },
29+
{ key: "Escape", isComposing: false, keyCode: 229 },
2830
]) {
29-
for (const key of ["Enter", "Escape"]) {
30-
const event = new KeyboardEvent("keydown", {
31-
key,
32-
...nativeEvent,
33-
bubbles: true,
34-
cancelable: true,
35-
});
36-
await act(() => search.element().dispatchEvent(event));
37-
expect(event.defaultPrevented).toBe(false);
38-
expect(screen.router?.state.location.pathname).toBe("/settings/general");
39-
await expect.element(search).toHaveValue("theme");
40-
}
31+
const event = new KeyboardEvent("keydown", { ...composition, bubbles: true, cancelable: true });
32+
await act(() => search.element().dispatchEvent(event));
33+
expect(event.defaultPrevented, JSON.stringify(composition)).toBe(false);
34+
expect(screen.router?.state.location.pathname).toBe("/settings/general");
35+
await expect.element(search).toHaveValue("theme");
4136
}
4237

4338
await userEvent.keyboard("{Enter}");

0 commit comments

Comments
 (0)