Skip to content

Commit 495c54f

Browse files
fix(web): run panel registry tests with React DOM
Move the registry lifecycle test into the browser project, verify retained local state through a real DOM interaction, and format the moved Diff panel import.
1 parent 2ccb588 commit 495c54f

2 files changed

Lines changed: 32 additions & 12 deletions

File tree

‎apps/web/src/panels/diff/DiffSidePanel.tsx‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,10 @@ import { DiffFilePathCopyButton } from "~/components/DiffFilePathCopyButton";
5151
import { DiffPanelLoadingState } from "~/components/diffs/DiffLoadingState";
5252
import type { SidePanelProps } from "../bundledPanels";
5353
import { DiffStatLabel } from "~/components/chat/DiffStatLabel";
54-
import { AnnotatableCodeView, type AnnotatableCodeViewHandle } from "~/components/diffs/AnnotatableCodeView";
54+
import {
55+
AnnotatableCodeView,
56+
type AnnotatableCodeViewHandle,
57+
} from "~/components/diffs/AnnotatableCodeView";
5558
import { DiffFileTree } from "~/components/diffs/DiffFileTree";
5659
import { diffFileTreeEntries } from "~/components/diffs/diffFileTree.logic";
5760
import { Button } from "~/components/ui/button";

apps/web/src/panels/panelRegistry.test.tsx renamed to apps/web/src/panels/panelRegistry.browser.test.tsx

Lines changed: 28 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,26 @@
1-
import { act, Suspense, useEffect } from "react";
2-
import { create, type ReactTestRenderer } from "react-test-renderer";
3-
import { describe, expect, it, vi } from "vite-plus/test";
1+
import { act, Suspense, useEffect, useState } from "react";
2+
import { createRoot, type Root } from "react-dom/client";
3+
import { afterEach, beforeEach, describe, expect, it, vi } from "vite-plus/test";
44

55
import { createPanelRegistry } from "./panelRegistry";
66

7-
// These exercise lazy evaluation and actual mount/disposal, without inspecting markup.
7+
let root: Root;
8+
let container: HTMLDivElement;
9+
10+
beforeEach(() => {
11+
vi.stubGlobal("IS_REACT_ACT_ENVIRONMENT", true);
12+
container = document.createElement("div");
13+
document.body.append(container);
14+
root = createRoot(container);
15+
});
16+
17+
afterEach(async () => {
18+
await act(async () => root.unmount());
19+
container.remove();
20+
vi.unstubAllGlobals();
21+
});
22+
23+
// Exercise lazy loading, retained local state, and mount/disposal in the client.
824
describe("panel registry", () => {
925
it("rejects duplicate ids without loading either panel", () => {
1026
const load = vi.fn();
@@ -21,19 +37,19 @@ describe("panel registry", () => {
2137
const mounted = vi.fn();
2238
const disposed = vi.fn();
2339
function Panel() {
40+
const [count, setCount] = useState(0);
2441
useEffect(() => {
2542
mounted();
2643
return disposed;
2744
}, []);
28-
return null;
45+
return <button onClick={() => setCount((current) => current + 1)}>Count {count}</button>;
2946
}
3047
const load = vi.fn(() => loaded);
3148
const registry = createPanelRegistry([{ id: "diff", load }]);
3249
expect(load).not.toHaveBeenCalled();
3350
const Component = registry.get("diff")!.Component;
34-
let renderer!: ReactTestRenderer;
3551
await act(async () => {
36-
renderer = create(
52+
root.render(
3753
<Suspense fallback={null}>
3854
<Component />
3955
</Suspense>,
@@ -46,11 +62,13 @@ describe("panel registry", () => {
4662
await loaded;
4763
});
4864
expect(mounted).toHaveBeenCalledTimes(1);
65+
await act(async () => container.querySelector<HTMLButtonElement>("button")!.click());
66+
expect(container.textContent).toBe("Count 1");
4967
// A parent re-render looks the panel up again; it must keep the same mount and state.
5068
const Again = registry.get("diff")!.Component;
5169
expect(Again).toBe(Component);
5270
await act(async () => {
53-
renderer.update(
71+
root.render(
5472
<Suspense fallback={null}>
5573
<Again />
5674
</Suspense>,
@@ -59,9 +77,8 @@ describe("panel registry", () => {
5977
expect(load).toHaveBeenCalledTimes(1);
6078
expect(mounted).toHaveBeenCalledTimes(1);
6179
expect(disposed).not.toHaveBeenCalled();
62-
await act(async () => {
63-
renderer.unmount();
64-
});
80+
expect(container.textContent).toBe("Count 1");
81+
await act(async () => root.render(null));
6582
expect(disposed).toHaveBeenCalledTimes(1);
6683
});
6784
});

0 commit comments

Comments
 (0)