Skip to content

Commit 4935830

Browse files
perf(web): ACP session management compile with the React Compiler
Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 914c065 commit 4935830

2 files changed

Lines changed: 36 additions & 21 deletions

File tree

‎apps/web/reactCompiledFiles.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,4 +85,5 @@ export const REACT_COMPILED_FILES = [
8585
"apps/web/src/components/settings/DiagnosticsSettings.tsx",
8686
"apps/web/src/components/settings/DeviceHostsSettings.tsx",
8787
"apps/web/src/components/settings/ProjectSettingsPanel.tsx",
88+
"apps/web/src/components/settings/AcpSessionManagementSection.tsx",
8889
] as const;

‎apps/web/src/components/settings/AcpSessionManagementSection.tsx‎

Lines changed: 35 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,32 @@ function reportFailure(title: string, result: AtomCommandResult<unknown, unknown
4444
});
4545
}
4646

47+
function parseProviderHeaders(
48+
text: string,
49+
):
50+
| { readonly ok: true; readonly headers: Record<string, string> | undefined }
51+
| { readonly ok: false; readonly error: string } {
52+
if (text.trim().length === 0) return { ok: true, headers: undefined };
53+
let parsed: unknown;
54+
try {
55+
parsed = JSON.parse(text);
56+
} catch (error) {
57+
return {
58+
ok: false,
59+
error: error instanceof Error ? error.message : "Headers must be valid JSON.",
60+
};
61+
}
62+
if (
63+
typeof parsed !== "object" ||
64+
parsed === null ||
65+
Array.isArray(parsed) ||
66+
!Object.values(parsed).every((value) => typeof value === "string")
67+
) {
68+
return { ok: false, error: "Headers must be a JSON object with string values." };
69+
}
70+
return { ok: true, headers: parsed as Record<string, string> };
71+
}
72+
4773
export function AcpSessionManagementSection(props: {
4874
readonly environmentId: EnvironmentId;
4975
readonly instanceId: ProviderInstanceId;
@@ -221,28 +247,16 @@ export function AcpSessionManagementSection(props: {
221247
return;
222248
const draft = providerDrafts[provider.providerId];
223249
if (draft === undefined || draft.apiType.length === 0 || draft.baseUrl.length === 0) return;
224-
let headers: Record<string, string> | undefined;
225-
if (draft.headers.trim().length > 0) {
226-
try {
227-
const parsed: unknown = JSON.parse(draft.headers);
228-
if (
229-
typeof parsed !== "object" ||
230-
parsed === null ||
231-
Array.isArray(parsed) ||
232-
!Object.values(parsed).every((value) => typeof value === "string")
233-
) {
234-
throw new Error("Headers must be a JSON object with string values.");
235-
}
236-
headers = parsed as Record<string, string>;
237-
} catch (error) {
238-
toastManager.add({
239-
type: "error",
240-
title: "Invalid provider headers",
241-
description: error instanceof Error ? error.message : "Headers must be valid JSON.",
242-
});
243-
return;
244-
}
250+
const parsedHeaders = parseProviderHeaders(draft.headers);
251+
if (!parsedHeaders.ok) {
252+
toastManager.add({
253+
type: "error",
254+
title: "Invalid provider headers",
255+
description: parsedHeaders.error,
256+
});
257+
return;
245258
}
259+
const headers = parsedHeaders.headers;
246260
setSavingProviderId(provider.providerId);
247261
const result = await setProvider({
248262
environmentId: props.environmentId,

0 commit comments

Comments
 (0)