You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 45dd888
Browse filesBrowse the repository at this point in the historyBrowse files
constapprovability=`Fail when a maintainer should read this pull request before CodeRabbit approves it, and name the rule and file. Fail if it:
4
+
5
+
- Changes a product default: a setting's default value, or what users get without opting in. Making a feature do what it already promises is a bug fix, not a default change.
6
+
- Adds or broadens a directive that disables or suppresses a lint, type-checker, LSP, or other static-analysis diagnostic, including file-level, line-level, and configuration-level overrides.
7
+
- Adds a subsystem or user workflow, or is a large refactor across apps or packages.
8
+
- Changes packages/contracts or persisted data in a way that existing clients or stored data might not accept.
9
+
- Changes authentication, pairing, credentials, secrets, or remote connection trust.
10
+
- Adds or changes an external side effect, such as acting on GitHub, publishing a release, or calling a webhook.
11
+
- Adds, upgrades, or patches a dependency.
12
+
- Changes CI or release configuration, agent or contributor instructions, or any review tool's configuration, including .github/, AGENTS.md, CONTRIBUTING.md, .agents/, and .coderabbit.config.ts.
13
+
14
+
Otherwise pass. A focused bug fix, copy or layout fix, revert, or docs-only or test-only change passes unless a rule above applies. If you cannot decide, fail rather than report inconclusive. When failing, say that the pull request needs a maintainer's review.
15
+
`;
16
+
17
+
// Org members and collaborators merge their own pull requests. On anyone else's, CodeRabbit
18
+
// requests changes until its comments are resolved and its checks pass, then approves.
Copy file name to clipboardExpand all lines: AGENTS.md
+1Lines changed: 1 addition & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -150,6 +150,7 @@ Architecture and its constraints: `docs/internals/overview.md`. Glossary: `docs/
150
150
## Taste
151
151
152
152
- Complexity belongs at the adapter boundary. Orchestration stays pure, UI stays dumb.
153
+
- Client mutations use `createEnvironmentRpcCommand`. Add protected methods to `CLIENT_GUARDED_RPC_SCOPES` in contracts and use the command's `permissionAtom` for UI availability. Grants are checked at execution against the destination environment; the server remains authoritative. Keep raw RPC clients inside `rpc/`, and extend the permission behavior tests when adding a protected method.
153
154
- Server features are services; transports stay thin. A `ws.ts` RPC handler, HTTP route, or MCP tool decodes input, calls one service method, and maps errors. See [Effect services](docs/internals/effect-services.md).
154
155
-`apps/web/src/components/ui` exports own their look. Pick a `variant` or `size`; do not restyle one with `className`. If none fits and the look is a generic concept, add a variant to the component; a look that belongs to one feature stays in that feature's own component, not in `components/ui`. Layout classes (width, flex, margin, position) belong on the parent. `shadcn/no-restyle` fails lint on violations. See [Web UI](docs/internals/web-ui.md).
155
156
- Inferred types over annotations. `any` is the enemy.
0 commit comments