Skip to content

Commit 432668d

Browse files
committed
Remove duplicate inline wheel handler, use existing onTurnStripWheel useCallback in useEffect
1 parent 632c141 commit 432668d

1 file changed

Lines changed: 3 additions & 11 deletions

File tree

‎apps/web/src/components/DiffPanel.tsx‎

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -260,26 +260,18 @@ export default function DiffPanel({ mode = "inline" }: DiffPanelProps) {
260260
updateTurnStripScrollState();
261261
const onScroll = () => updateTurnStripScrollState();
262262

263-
const onWheel = (event: WheelEvent) => {
264-
if (!element) return;
265-
if (element.scrollWidth <= element.clientWidth + 1) return;
266-
if (Math.abs(event.deltaY) <= Math.abs(event.deltaX)) return;
267-
event.preventDefault();
268-
element.scrollBy({ left: event.deltaY, behavior: "auto" });
269-
};
270-
271263
element.addEventListener("scroll", onScroll, { passive: true });
272-
element.addEventListener("wheel", onWheel, { passive: false });
264+
element.addEventListener("wheel", onTurnStripWheel, { passive: false });
273265

274266
const resizeObserver = new ResizeObserver(() => updateTurnStripScrollState());
275267
resizeObserver.observe(element);
276268

277269
return () => {
278270
element.removeEventListener("scroll", onScroll);
279-
element.removeEventListener("wheel", onWheel);
271+
element.removeEventListener("wheel", onTurnStripWheel);
280272
resizeObserver.disconnect();
281273
};
282-
}, [updateTurnStripScrollState]);
274+
}, [updateTurnStripScrollState, onTurnStripWheel]);
283275

284276
useEffect(() => {
285277
updateTurnStripScrollState();

0 commit comments

Comments
 (0)