Skip to content

Commit 42216f3

Browse files
only21milclaude
andcommitted
fix(provider-core): redact compound credential keys in provider failures
Provider failure text redacted values only for bare key names such as token or secret. Keys like client_secret, refresh_token or clientSecret kept their values, so those values reached the persisted error item and the thread. Match any key whose name ends in a credential word. Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent bd6940b commit 42216f3

2 files changed

Lines changed: 14 additions & 2 deletions

File tree

‎packages/provider-core/src/server/failure.test.ts‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,18 @@ it("redacts credentials and URL secrets from provider failures", () => {
4040
assert.notInclude(failure.message, "sk-abcdefghijklmnop");
4141
});
4242

43+
it("redacts credentials whose key names end in a credential word", () => {
44+
const failure = makeProviderFailure({
45+
message:
46+
'oauth refresh failed: client_secret=client-value refresh_token=refresh-value {"client_secret":"json-value"} clientSecret: camel-value X-Auth-Token: header-value max_tokens=4096',
47+
});
48+
49+
assert.equal(
50+
failure.message,
51+
'oauth refresh failed: client_secret=[REDACTED] refresh_token=[REDACTED] {"client_secret":"[REDACTED]"} clientSecret: [REDACTED] X-Auth-Token: [REDACTED] max_tokens=4096',
52+
);
53+
});
54+
4355
it("does not split a surrogate pair at the truncation boundary", () => {
4456
const failure = makeProviderFailure({
4557
message: `${"a".repeat(MAX_PROVIDER_FAILURE_MESSAGE_LENGTH - 2)}🚀tail`,

‎packages/provider-core/src/server/failure.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -178,11 +178,11 @@ function redactProviderFailureText(value: string): string {
178178
.replace(/\bhttps?:\/\/[^\s<>"']+/giu, redactUrl)
179179
.replace(/\b(Bearer|Basic)\s+[^\s,;]+/giu, "$1 [REDACTED]")
180180
.replace(
181-
/(["'](?:access[_-]?token|api[_-]?key|authorization|credential|password|secret|token)["']\s*:\s*["'])[^"']*(["'])/giu,
181+
/(["'][\w-]*(?:access[_-]?token|api[_-]?key|authorization|credential|password|secret|token)["']\s*:\s*["'])[^"']*(["'])/giu,
182182
"$1[REDACTED]$2",
183183
)
184184
.replace(
185-
/(\b(?:access[_-]?token|api[_-]?key|authorization|credential|password|secret|token)\b\s*[:=]\s*)(?:"[^"]*"|'[^']*'|[^\s,;]+)/giu,
185+
/((?<![\w-])[\w-]*(?:access[_-]?token|api[_-]?key|authorization|credential|password|secret|token)\b\s*[:=]\s*)(?:"[^"]*"|'[^']*'|[^\s,;]+)/giu,
186186
"$1[REDACTED]",
187187
)
188188
.replace(/\bsk-[A-Za-z0-9_-]{16,}\b/gu, "[REDACTED]")

0 commit comments

Comments
 (0)