Skip to content

Commit 41bbd4b

Browse files
author
Zayd
committed
fix(build): replace previous directory artifacts on rebuild
1 parent b5c5eb3 commit 41bbd4b

2 files changed

Lines changed: 11 additions & 0 deletions

File tree

‎scripts/build-desktop-artifact.test.ts‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1690,6 +1690,14 @@ it.effect("preserves packaged app directories from the dir target", () =>
16901690
assert.equal(yield* fs.readFileString(path.join(output, app, "Info.plist")), "built-app");
16911691
assert.equal(yield* fs.readLink(path.join(output, app, "Current")), "Info.plist");
16921692
assert.equal(yield* fs.readFileString(path.join(stage, app, "Info.plist")), "built-app");
1693+
yield* fs.remove(path.join(stage, app, "Info.plist"));
1694+
yield* fs.remove(path.join(stage, app, "Current"));
1695+
yield* fs.writeFileString(path.join(stage, app, "New.plist"), "rebuilt-app");
1696+
yield* fs.symlink("New.plist", path.join(stage, app, "Current"));
1697+
yield* copyDesktopBuildArtifacts(stage, output, true);
1698+
assert.isFalse(yield* fs.exists(path.join(output, app, "Info.plist")));
1699+
assert.equal(yield* fs.readFileString(path.join(output, app, "New.plist")), "rebuilt-app");
1700+
assert.equal(yield* fs.readLink(path.join(output, app, "Current")), "New.plist");
16931701
const filesOnly = yield* copyDesktopBuildArtifacts(stage, path.join(root, "files-only"));
16941702
assert.deepEqual(filesOnly, [path.join(root, "files-only", "builder-debug.yml")]);
16951703
assert.isFalse(yield* fs.exists(path.join(root, "files-only", "mac-arm64")));

‎scripts/build-desktop-artifact.ts‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4151,6 +4151,9 @@ export const copyDesktopBuildArtifacts = Effect.fn("copyDesktopBuildArtifacts")(
41514151
continue;
41524152

41534153
const to = path.join(outputDir, entry);
4154+
if (stat.type === "Directory") {
4155+
yield* fs.remove(to, { recursive: true, force: true });
4156+
}
41544157
yield* Effect.tryPromise(() =>
41554158
NodeFSP.cp(from, to, {
41564159
recursive: true,

0 commit comments

Comments
 (0)