Skip to content

Commit 401dd6a

Browse files
t3dotggclaude
andcommitted
fix(web): managed Codex shows the suggestion switch; skip suggestions beside context chips
Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 414f99c commit 401dd6a

3 files changed

Lines changed: 26 additions & 2 deletions

File tree

‎apps/web/src/components/chat/ChatComposer.tsx‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2184,6 +2184,7 @@ export const ChatComposer = memo(function ChatComposer(props: ChatComposerProps)
21842184
// Offered only where the default placeholder would show, so it never hides a pending question.
21852185
const offeredPromptSuggestion =
21862186
phase !== "running" &&
2187+
composerContextRecords.size === 0 &&
21872188
!isComposerApprovalState &&
21882189
!activePendingProgress &&
21892190
!(showPlanFollowUpPrompt && activeProposedPlan) &&

‎apps/web/src/components/settings/ProviderInstanceCard.tsx‎

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1283,7 +1283,25 @@ export function ProviderInstanceCard({
12831283
title="Runtime"
12841284
headerPlacement="outside"
12851285
>
1286-
{runtime ?? runtimeFields}
1286+
{runtime === undefined ? (
1287+
runtimeFields
1288+
) : (
1289+
<>
1290+
{runtime}
1291+
{driverOption ? (
1292+
// Managed Codex owns its paths; its behavior switches stay editable.
1293+
<ProviderSettingsForm
1294+
definition={driverOption}
1295+
value={instance.config}
1296+
idPrefix={`provider-instance-${instanceId}`}
1297+
variant="settings"
1298+
onChange={updateConfig}
1299+
environmentId={environmentId}
1300+
fieldKeys={["promptSuggestions"]}
1301+
/>
1302+
) : null}
1303+
</>
1304+
)}
12871305
</FoldedSettingsSection>
12881306
</div>
12891307
) : !driverOption || deriveProviderSettingsFields(driverOption).length > 0 ? (

‎apps/web/src/components/settings/ProviderSettingsForm.tsx‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -326,6 +326,8 @@ interface ProviderSettingsFormProps {
326326
readonly onChange: (nextConfig: Record<string, unknown> | undefined) => void;
327327
/** Where the secret providers offered for `SettingsSecretValue` fields are configured. */
328328
readonly environmentId?: EnvironmentId | undefined;
329+
/** Render only these fields; omit to render every visible field. */
330+
readonly fieldKeys?: ReadonlyArray<string>;
329331
}
330332

331333
function SecretSettingsControl({
@@ -661,8 +663,11 @@ export function ProviderSettingsForm({
661663
variant,
662664
onChange,
663665
environmentId,
666+
fieldKeys,
664667
}: ProviderSettingsFormProps) {
665-
const fields = deriveProviderSettingsFields(definition, value);
668+
const fields = deriveProviderSettingsFields(definition, value).filter(
669+
(field) => fieldKeys === undefined || fieldKeys.includes(field.key),
670+
);
666671
const isLocalAcp =
667672
definition.driverKind === "acpRegistry" &&
668673
readProviderConfigString(value, "source") === "local";

0 commit comments

Comments
 (0)