Skip to content

Commit 3d762a7

Browse files
committed
fix(clients): new threads prefer a connected copy of the project
1 parent 56db584 commit 3d762a7

5 files changed

Lines changed: 134 additions & 24 deletions

File tree

‎apps/mobile/src/features/threads/new-task-flow-provider.tsx‎

Lines changed: 20 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,10 @@ import {
121121
resolveNewTaskBranchWorktreePath,
122122
resolveNewTaskLocalWorkspaceSelection,
123123
} from "./new-task-context-presentation";
124-
import { resolveEnvironmentProjectMatch } from "./new-task-project-selection";
124+
import {
125+
resolveEnvironmentProjectMatch,
126+
resolveNewTaskEnvironmentId,
127+
} from "./new-task-project-selection";
125128
import { resolveProjectThreadCreationBranch } from "./projectThreadCreationValidation";
126129

127130
type WorkspaceMode = "local" | "worktree";
@@ -268,6 +271,16 @@ export function NewTaskFlowProvider(props: React.PropsWithChildren) {
268271
const projects = useProjects();
269272
const threads = useThreadShells();
270273
const { savedConnectionsById } = useSavedRemoteConnections();
274+
const { connectedEnvironments } = useRemoteConnectionStatus();
275+
const connectedEnvironmentIds = useMemo(
276+
() =>
277+
new Set(
278+
connectedEnvironments
279+
.filter((environment) => environment.connectionState === "connected")
280+
.map((environment) => environment.environmentId),
281+
),
282+
[connectedEnvironments],
283+
);
271284
const groupingSettings = useMobileProjectGroupingSettings();
272285
const { enabled: legacyPlanModeEnabled, loaded: planModePreferenceLoaded } =
273286
useLegacyPlanModeState();
@@ -290,11 +303,11 @@ export function NewTaskFlowProvider(props: React.PropsWithChildren) {
290303
const [selectedEnvironmentIdOverride, setSelectedEnvironmentId] = useState<EnvironmentId | null>(
291304
null,
292305
);
293-
const selectedEnvironmentId =
294-
selectedEnvironmentIdOverride !== null &&
295-
projects.some((project) => project.environmentId === selectedEnvironmentIdOverride)
296-
? selectedEnvironmentIdOverride
297-
: (projects[0]?.environmentId ?? null);
306+
const selectedEnvironmentId = resolveNewTaskEnvironmentId(
307+
projects,
308+
selectedEnvironmentIdOverride,
309+
connectedEnvironmentIds,
310+
);
298311
const [manualProjectRef, setManualProjectRef] = useState<ScopedProjectRef | null>(null);
299312
const [selectedProjectKey, setSelectedProjectKey] = useState<string | null>(null);
300313
// The new-task draft the composer is bound to. Null until a project is
@@ -385,7 +398,6 @@ export function NewTaskFlowProvider(props: React.PropsWithChildren) {
385398
selectedProject !== null &&
386399
isScratchProject(selectedProject, selectedEnvironmentServerConfig?.scratchWorkspaceRoot);
387400
const serverConfigs = useServerConfigs();
388-
const { connectedEnvironments } = useRemoteConnectionStatus();
389401
// A thread without a project can move to any connected machine that offers
390402
// one; its Scratch project there is created on the switch if it is missing.
391403
const scratchEnvironments = useMemo(
@@ -489,6 +501,7 @@ export function NewTaskFlowProvider(props: React.PropsWithChildren) {
489501
projectId: selectedProject.id,
490502
}),
491503
);
504+
setSelectedEnvironmentId(selectedProject.environmentId);
492505
}, [activeDraftKey, editingPendingTask, selectedProject]);
493506
const selectedProjectDraft = useComposerDraft(selectedProjectDraftKey);
494507
const prompt = selectedProjectDraft.text;

‎apps/mobile/src/features/threads/new-task-project-selection.test.ts‎

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import {
88
getProjectScopeSelectionTarget,
99
resolveDraftProjectSelection,
1010
resolveEnvironmentProjectMatch,
11+
resolveNewTaskEnvironmentId,
1112
} from "./new-task-project-selection";
1213

1314
function makeProject(
@@ -54,6 +55,35 @@ function makeScope(projects: ReadonlyArray<EnvironmentProject>): HomeProjectScop
5455
};
5556
}
5657

58+
describe("resolveNewTaskEnvironmentId", () => {
59+
const mac = EnvironmentId.make("mac");
60+
const server = EnvironmentId.make("server");
61+
const projects = [makeProject("mac-project", mac), makeProject("server-project", server)];
62+
63+
it("defaults to a connected environment that has projects", () => {
64+
expect(resolveNewTaskEnvironmentId(projects, null, new Set([server]))).toBe(server);
65+
expect(
66+
resolveNewTaskEnvironmentId(projects, null, new Set([EnvironmentId.make("empty"), server])),
67+
).toBe(server);
68+
});
69+
70+
it("keeps an explicit offline selection", () => {
71+
expect(resolveNewTaskEnvironmentId(projects, mac, new Set([server]))).toBe(mac);
72+
});
73+
74+
it("keeps project order when several or no environments are connected", () => {
75+
expect(resolveNewTaskEnvironmentId(projects, null, new Set([server, mac]))).toBe(mac);
76+
expect(resolveNewTaskEnvironmentId(projects, null, new Set())).toBe(mac);
77+
});
78+
79+
it("falls back when the selected environment has no projects", () => {
80+
expect(
81+
resolveNewTaskEnvironmentId(projects, EnvironmentId.make("missing"), new Set([server])),
82+
).toBe(server);
83+
expect(resolveNewTaskEnvironmentId([], null, new Set([server]))).toBeNull();
84+
});
85+
});
86+
5787
describe("getProjectScopeSelectionTarget", () => {
5888
it("keeps the current environment when it hosts the selected logical project", () => {
5989
const projects = [makeProject("t3code-mac", "mac"), makeProject("t3code-server", "server")];

‎apps/mobile/src/features/threads/new-task-project-selection.ts‎

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,24 @@ type DraftProjectSelectionResolution =
99
| { readonly kind: "select"; readonly project: EnvironmentProject }
1010
| { readonly kind: "pick" };
1111

12+
export function resolveNewTaskEnvironmentId(
13+
projects: ReadonlyArray<Pick<EnvironmentProject, "environmentId">>,
14+
selectedEnvironmentId: EnvironmentId | null,
15+
connectedEnvironmentIds: ReadonlySet<EnvironmentId>,
16+
): EnvironmentId | null {
17+
if (
18+
selectedEnvironmentId !== null &&
19+
projects.some((project) => project.environmentId === selectedEnvironmentId)
20+
) {
21+
return selectedEnvironmentId;
22+
}
23+
return (
24+
projects.find((project) => connectedEnvironmentIds.has(project.environmentId))?.environmentId ??
25+
projects[0]?.environmentId ??
26+
null
27+
);
28+
}
29+
1230
export function getProjectScopeSelectionTarget(
1331
scope: HomeProjectScope,
1432
preferredEnvironmentId: EnvironmentId | null,

‎packages/client-runtime/src/state/newThreadProjectRef.test.ts‎

Lines changed: 63 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -57,18 +57,15 @@ describe("new thread project environment", () => {
5757
});
5858

5959
it.each([{}, { defaultEnvironmentId: null }])(
60-
"preserves the context for Automatic %j whether connected or offline",
60+
"keeps a connected context for Automatic %j",
6161
(override) => {
62-
for (const connected of [connectedEnvironmentIds, new Set([mac.environmentId])]) {
63-
expect(
64-
resolveNewThreadProjectRef({
65-
...input,
66-
settingsByEnvironment: settings(override),
67-
contextProjectRef: padRef,
68-
connectedEnvironmentIds: connected,
69-
}),
70-
).toEqual({ projectRef: padRef, environmentSelection: "auto" });
71-
}
62+
expect(
63+
resolveNewThreadProjectRef({
64+
...input,
65+
settingsByEnvironment: settings(override),
66+
contextProjectRef: padRef,
67+
}),
68+
).toEqual({ projectRef: padRef, environmentSelection: "auto" });
7269
},
7370
);
7471

@@ -89,6 +86,61 @@ describe("new thread project environment", () => {
8986
},
9087
);
9188

89+
it.each([{}, { defaultEnvironmentId: null }])(
90+
"prefers a connected copy over an offline context for Automatic %j",
91+
(override) => {
92+
expect(
93+
resolveNewThreadProjectRef({
94+
...input,
95+
settingsByEnvironment: settings(override),
96+
contextProjectRef: padRef,
97+
connectedEnvironmentIds: new Set([mac.environmentId]),
98+
}),
99+
).toEqual({ projectRef: macRef, environmentSelection: "auto" });
100+
},
101+
);
102+
103+
it("keeps a manual offline pick ahead of connected copies", () => {
104+
expect(
105+
resolveNewThreadProjectRef({
106+
...input,
107+
manualProjectRef: padRef,
108+
connectedEnvironmentIds: new Set([mac.environmentId]),
109+
}),
110+
).toEqual({ projectRef: padRef, environmentSelection: "manual" });
111+
});
112+
113+
it("uses the first connected copy when context and primary are offline", () => {
114+
const server = { environmentId: EnvironmentId.make("server"), id: ProjectId.make("server") };
115+
expect(
116+
resolveNewThreadProjectRef({
117+
...input,
118+
settingsByEnvironment: settings(),
119+
members: [mac, pad, server],
120+
contextProjectRef: padRef,
121+
connectedEnvironmentIds: new Set([server.environmentId]),
122+
}).projectRef,
123+
).toEqual({ environmentId: server.environmentId, projectId: server.id });
124+
});
125+
126+
it.each([
127+
[{ contextProjectRef: padRef }, padRef],
128+
[{ contextProjectRef: null, primaryEnvironmentId: pad.environmentId }, padRef],
129+
[{ contextProjectRef: null, primaryEnvironmentId: null }, macRef],
130+
] as const)(
131+
"keeps context, primary, then member order when nothing is connected (%#)",
132+
(overrides, projectRef) => {
133+
expect(
134+
resolveNewThreadProjectRef({
135+
...input,
136+
settingsByEnvironment: settings(),
137+
connectedEnvironmentIds: new Set<EnvironmentId>(),
138+
...overrides,
139+
}).projectRef,
140+
).toEqual(projectRef);
141+
},
142+
);
143+
92144
it.each([mac.environmentId, null])(
93145
"ignores a disconnected first copy's stale default %j when a connected copy has a value",
94146
(staleDefault) => {

‎packages/client-runtime/src/state/projectGrouping.ts‎

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -385,12 +385,9 @@ export function resolveNewThreadProjectRef(input: {
385385
(member) => member.environmentId === input.primaryEnvironmentId,
386386
);
387387
const connectedFallbackMember =
388-
defaultEnvironmentId != null
389-
? ([contextMember, primaryMember].find(
390-
(member) => member && input.connectedEnvironmentIds.has(member.environmentId),
391-
) ??
392-
input.members.find((member) => input.connectedEnvironmentIds.has(member.environmentId)))
393-
: undefined;
388+
[contextMember, primaryMember].find(
389+
(member) => member && input.connectedEnvironmentIds.has(member.environmentId),
390+
) ?? input.members.find((member) => input.connectedEnvironmentIds.has(member.environmentId));
394391
const fallbackMember =
395392
connectedFallbackMember ?? contextMember ?? primaryMember ?? input.members[0];
396393
return {

0 commit comments

Comments
 (0)