Skip to content

Commit 3cea3f9

Browse files
t3dotggclaude
andcommitted
docs(client-runtime): state that activity blockers precede the settle override
CodeRabbit review: the effectiveSettled doc claimed the override "wins in both directions", but pending approvals/user-input, live sessions, and unadjudicated queued turns are evaluated first and hold a thread active regardless of any override. Say so explicitly. Co-Authored-By: Claude Fable 5 <[email protected]>
1 parent ca5b817 commit 3cea3f9

1 file changed

Lines changed: 9 additions & 7 deletions

File tree

‎packages/client-runtime/src/state/threadSettled.ts‎

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -105,13 +105,15 @@ export function canSettle(
105105
export const CHANGE_REQUEST_SETTLE_IDLE_MS = 60 * 60 * 1_000;
106106

107107
/**
108-
* Settled resolution over the server-backed settled lifecycle. The explicit
109-
* user override (thread.settle / thread.unsettle commands, projected into
110-
* settledOverride + settledAt) wins in both directions; without one, a
111-
* thread auto-settles on a merged/closed PR (once idle) or inactivity past
112-
* the window. The server un-settles on real activity (user message, session
113-
* start, approval/user-input request), so an override never goes stale
114-
* silently.
108+
* Settled resolution over the server-backed settled lifecycle. Activity
109+
* blockers (pending approval/user-input, a live session, an unadjudicated
110+
* queued turn) are checked first and hold a thread active regardless of any
111+
* override. Past the blockers, the explicit user override (thread.settle /
112+
* thread.unsettle commands, projected into settledOverride + settledAt)
113+
* wins in both directions; without one, a thread auto-settles on a
114+
* merged/closed PR (once idle) or inactivity past the window. The server
115+
* un-settles on real activity (user message, session start, approval/
116+
* user-input request), so an override never goes stale silently.
115117
*/
116118
export function effectiveSettled(
117119
shell: OrchestrationThreadShell,

0 commit comments

Comments
 (0)