You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 3c5a5a9
Browse filesBrowse the repository at this point in the historyBrowse files
fix(desktop): nightly updates no longer depend on GitHub's tag order
The release workflow records the newest nightly at one fixed URL, the
`update-feed` release, and the updater reads it before the atom feed. The
newer of the two wins. A scheduled job repairs a stale pointer and fails when
releases.atom no longer lists the newest nightly, which is the only source
older installs read.
Co-Authored-By: Claude Fable 5.2 <[email protected]>
- name: Fail when the feed hides the newest nightly
1095
+
if: steps.feed.outputs.in_feed == 'false'
1096
+
env:
1097
+
RELEASE_TAG: ${{ steps.feed.outputs.tag }}
1098
+
run: |
1099
+
echo "::error::releases.atom does not list $RELEASE_TAG. Nightly installs older than 0.1.10-nightly.20261112.4603 cannot update. See docs/operations/release.md#update-feed."
1100
+
exit 1
1101
+
1049
1102
# The `t3` npm package is a launcher that downloads this version's CLI
1050
1103
# archive from the GitHub Release, so it publishes only once that release
1051
1104
# exists. Preview publishes too, under the `preview` dist-tag, which
Copy file name to clipboardExpand all lines: docs/operations/release.md
+21-1Lines changed: 21 additions & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -19,7 +19,7 @@ the version.
19
19
- push tag matching `v*.*.*` for a stable release of an explicit commit
20
20
- scheduled nightly check every 30 minutes
21
21
- manual `workflow_dispatch` with `channel=nightly`
22
-
- manual `workflow_dispatch` with `channel=preview`, the maintainers' test train. It exercises the whole release flow (build, sign, notarize, smoke, publish) for a commit that end users must never receive, which is how an unmerged branch or a risky change gets a real release run before it lands. It builds the triggering commit with nightly's versioning under the `preview` prerelease identifier (`0.0.41-preview.<date>.<run>`) and leaves its GitHub prerelease as a draft, plus the npm packages under the `preview` dist-tag. It stays a draft because a draft has no git tag. `releases.atom` lists the 10 newest tags in the repository, same-day `preview` tags sort above `nightly` ones, and nightly updaters older than 0.1.10-nightly.20261112.4603 find updates only in that feed, so ten published previews hide every nightly from them. Do not publish a preview draft by hand; converting it back to a draft afterwards leaves the tag in the feed until the tag is deleted. Preview is not on the schedule, no default npm dist-tag points at it, its desktop builds carry no update feed, and no updater manifest (`latest*.yml`, `nightly*.yml`, blockmaps) is attached, so a stable or nightly install cannot be offered one. The only way onto it is downloading the draft by hand as a maintainer; `npx t3@preview`, `T3CODE_CHANNEL=preview`, and `t3 update --channel preview` cannot reach a draft's assets. Each of those paths prints a warning, and the CLI asks for confirmation when the running build is not itself a preview. The release itself is named as a maintainer test build and its body is a warning rather than generated notes: a changelog of unmerged branch history is not a changelog, and nightly and stable notes are unaffected because each series resolves its previous tag within its own channel. The hosted web app, AUR, and Discord announcements are skipped. Keep it; it costs nothing when idle.
22
+
- manual `workflow_dispatch` with `channel=preview`, the maintainers' test train. It exercises the whole release flow (build, sign, notarize, smoke, publish) for a commit that end users must never receive, which is how an unmerged branch or a risky change gets a real release run before it lands. It builds the triggering commit with nightly's versioning under the `preview` prerelease identifier (`0.0.41-preview.<date>.<run>`) and leaves its GitHub prerelease as a draft, plus the npm packages under the `preview` dist-tag. It stays a draft because a draft has no git tag, and published preview tags hide nightlies from the updater (see [Update feed](#update-feed)). Do not publish a preview draft by hand. Preview is not on the schedule, no default npm dist-tag points at it, its desktop builds carry no update feed, and no updater manifest (`latest*.yml`, `nightly*.yml`, blockmaps) is attached, so a stable or nightly install cannot be offered one. The only way onto it is downloading the draft by hand as a maintainer; `npx t3@preview`, `T3CODE_CHANNEL=preview`, and `t3 update --channel preview` cannot reach a draft's assets. Each of those paths prints a warning, and the CLI asks for confirmation when the running build is not itself a preview. The release itself is named as a maintainer test build and its body is a warning rather than generated notes: a changelog of unmerged branch history is not a changelog, and nightly and stable notes are unaffected because each series resolves its previous tag within its own channel. The hosted web app, AUR, and Discord announcements are skipped. Keep it; it costs nothing when idle.
23
23
- A manual stable release builds the commit of the latest published nightly, not `main` HEAD.
24
24
Nightly is the release candidate: verify the nightly, then promote it. Merges to `main` keep
25
25
landing while you verify and never leak into the stable build.
@@ -465,6 +465,26 @@ verify that the update stops before restart and run `npx t3@<version> service up
465
465
server machine. Also test the manual or desktop-managed guidance when those environments are
466
466
available.
467
467
468
+
## Update feed
469
+
470
+
A nightly install finds the newest nightly in two places.
471
+
472
+
-`releases.atom` lists the 10 newest git tags in the repository, of any kind, and same-day
473
+
`preview` tags sort above `nightly` ones. Installs built before the pointer existed read nothing
474
+
else: nightlies before `0.1.10-nightly.20261112.4603`, and stable `0.1.9` and older switched to
475
+
the nightly channel. Ten other tags in a row hide every nightly from them.
476
+
-`releases/download/update-feed/nightly.json` names the newest nightly. Newer installs read it
477
+
first and take the newer of it and the feed, so their updates do not depend on tag order. The
478
+
`update-feed` release holds that file. Never delete it.
479
+
480
+
The release workflow's `Check the update feed` job runs on every scheduled tick and after every
481
+
nightly. It rewrites a stale pointer, then fails when the feed does not list the newest nightly.
482
+
483
+
When it fails, old installs cannot update. The job log lists the tags that fill the feed. Delete
484
+
the ones nothing needs with `git push origin :refs/tags/<tag>`. Converting a release to a draft
485
+
keeps its tag, so it does not help. To keep this from happening, anything users should not be
486
+
offered stays a draft or uses one rolling tag, like `desktop-preview`.
0 commit comments