Skip to content

Commit 3b6f860

Browse files
fix(server): preserve telemetry and webhook tracing boundaries
1 parent 4ed2b8c commit 3b6f860

4 files changed

Lines changed: 272 additions & 244 deletions

File tree

‎apps/server/src/resourceTelemetry/NativeTelemetryClient.ts‎

Lines changed: 18 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -279,9 +279,8 @@ export function resolveNativeSampleIntervalMs(
279279
return SAMPLE_INTERVAL_MS;
280280
}
281281

282-
export const commitCollectionControlUpdate = Effect.fn(
283-
"NativeTelemetryClient.commitCollectionControlUpdate",
284-
)(function* <E, R>(
282+
// Desktop power samples also commit control state; avoid a span for each sample.
283+
export const commitCollectionControlUpdate = Effect.fnUntraced(function* <E, R>(
285284
desiredState: Ref.Ref<CollectionControl>,
286285
appliedState: Ref.Ref<CollectionControl>,
287286
update: (current: CollectionControl) => CollectionControl,
@@ -776,9 +775,11 @@ export const make = Effect.fn("resourceTelemetry.nativeTelemetryClient.make")(fu
776775
Effect.forkScoped,
777776
);
778777

779-
const applyCollectionControl = Effect.fn(
780-
"resourceTelemetry.nativeTelemetryClient.applyCollectionControl",
781-
)(function* (previous: CollectionControl, next: CollectionControl) {
778+
// Desktop power samples reach this even when the control state has not changed.
779+
const applyCollectionControl = Effect.fnUntraced(function* (
780+
previous: CollectionControl,
781+
next: CollectionControl,
782+
) {
782783
const current = yield* Ref.get(state);
783784
if (canCommandNativeTelemetrySidecar(current.status, Option.isSome(current.handle))) {
784785
const handle = Option.getOrThrow(current.handle);
@@ -841,18 +842,18 @@ export const make = Effect.fn("resourceTelemetry.nativeTelemetryClient.make")(fu
841842
}),
842843
);
843844

844-
const setExternalProcesses: NativeTelemetryClient["Service"]["setExternalProcesses"] = Effect.fn(
845-
"NativeTelemetryClient.setExternalProcesses",
846-
)(function* (processes) {
847-
yield* Ref.set(externalProcesses, [...processes]);
848-
const current = yield* Ref.get(state);
849-
if (!canCommandNativeTelemetrySidecar(current.status, Option.isSome(current.handle))) return;
850-
yield* writeCommand(Option.getOrThrow(current.handle), {
851-
version: RESOURCE_MONITOR_PROTOCOL_VERSION,
852-
type: "setExternalProcesses",
853-
processes: [...processes],
845+
// Desktop telemetry refreshes this process set on every sample.
846+
const setExternalProcesses: NativeTelemetryClient["Service"]["setExternalProcesses"] =
847+
Effect.fnUntraced(function* (processes) {
848+
yield* Ref.set(externalProcesses, [...processes]);
849+
const current = yield* Ref.get(state);
850+
if (!canCommandNativeTelemetrySidecar(current.status, Option.isSome(current.handle))) return;
851+
yield* writeCommand(Option.getOrThrow(current.handle), {
852+
version: RESOURCE_MONITOR_PROTOCOL_VERSION,
853+
type: "setExternalProcesses",
854+
processes: [...processes],
855+
});
854856
});
855-
});
856857

857858
const readHistory: NativeTelemetryClient["Service"]["readHistory"] = Effect.fn(
858859
"NativeTelemetryClient.readHistory",

0 commit comments

Comments
 (0)