@@ -20,6 +20,8 @@ import {
2020import * as DateTime from "effect/DateTime" ;
2121import * as Effect from "effect/Effect" ;
2222import * as Layer from "effect/Layer" ;
23+ import * as Result from "effect/Result" ;
24+ import * as TestClock from "effect/testing/TestClock" ;
2325import * as SqlClient from "effect/sql/SqlClient" ;
2426import * as SqlitePersistence from "../persistence/Sqlite.ts" ;
2527import { CodexProviderCapabilitiesV2 } from "./Adapters/CodexAdapterV2.ts" ;
@@ -624,3 +626,86 @@ it.effect("keeps delegated child pull-request links independent of the parent",
624626 assert . deepEqual ( parentAfterChildLink . thread . pullRequests , parent . thread . pullRequests ) ;
625627 } ) . pipe ( Effect . provide ( layerTest ) ) ,
626628) ;
629+
630+ it . effect . each ( [ false , true ] ) ( "rejects thread.create for an existing id (deleted: %s)" , ( deleted ) =>
631+ Effect . gen ( function * ( ) {
632+ const orchestrator = yield * Orchestrator . OrchestratorV2 ;
633+ const projections = yield * ProjectionStore . ProjectionStoreV2 ;
634+ const threadId = ThreadId . make ( `thread:duplicate-create:${ deleted } ` ) ;
635+ const create = {
636+ type : "thread.create" ,
637+ commandId : CommandId . make ( `create:${ threadId } ` ) ,
638+ threadId,
639+ projectId : ProjectId . make ( "project:duplicate-create" ) ,
640+ title : "Original" ,
641+ modelSelection,
642+ runtimeMode : "full-access" ,
643+ interactionMode : "default" ,
644+ branch : null ,
645+ worktreePath : null ,
646+ createdBy : "user" ,
647+ creationSource : "web" ,
648+ importedNativeThread : {
649+ ref : { driver : adapter . driver , nativeId : "native-original" , strength : "strong" } ,
650+ } ,
651+ } as const ;
652+ yield * orchestrator . dispatch ( create ) ;
653+ if ( deleted ) {
654+ yield * orchestrator . dispatch ( {
655+ type : "thread.delete" ,
656+ commandId : CommandId . make ( `delete:${ threadId } ` ) ,
657+ threadId,
658+ } ) ;
659+ }
660+ const before = yield * projections . getThread ( threadId ) ;
661+ assert . isNotNull ( before . activeProviderThreadId ) ;
662+ assert . equal ( before . deletedAt !== null , deleted ) ;
663+ const sequence = yield * orchestrator . getThreadEventSequence ( threadId ) ;
664+ yield * TestClock . adjust ( "1 second" ) ;
665+ const duplicate = {
666+ ...create ,
667+ commandId : CommandId . make ( `duplicate:${ threadId } ` ) ,
668+ title : "Replacement" ,
669+ importedNativeThread : undefined ,
670+ } ;
671+ const outcome = yield * orchestrator . dispatch ( duplicate ) . pipe ( Effect . result ) ;
672+ assert . ok ( Result . isFailure ( outcome ) , "duplicate create must be rejected" ) ;
673+ const refused = outcome . failure ;
674+ assert . equal ( refused . _tag , "OrchestratorThreadAlreadyExistsError" ) ;
675+ assert . equal ( refused . message , `Thread ${ threadId } already exists. Use a new thread id.` ) ;
676+ assert . deepEqual ( yield * projections . getThread ( threadId ) , before ) ;
677+ assert . equal ( yield * orchestrator . getThreadEventSequence ( threadId ) , sequence ) ;
678+ const retried = yield * orchestrator . dispatch ( duplicate ) . pipe ( Effect . flip ) ;
679+ assert . equal ( retried . _tag , "OrchestratorCommandPreviouslyRejectedError" ) ;
680+ assert . include ( retried . message , refused . message ) ;
681+ } ) . pipe ( Effect . provide ( layerTest ) ) ,
682+ ) ;
683+
684+ it . effect ( "replays a thread.create receipt without changing the thread" , ( ) =>
685+ Effect . gen ( function * ( ) {
686+ const orchestrator = yield * Orchestrator . OrchestratorV2 ;
687+ const projections = yield * ProjectionStore . ProjectionStoreV2 ;
688+ const threadId = ThreadId . make ( "thread:create-receipt-replay" ) ;
689+ const create = {
690+ type : "thread.create" ,
691+ commandId : CommandId . make ( "create:receipt-replay" ) ,
692+ threadId,
693+ projectId : ProjectId . make ( "project:duplicate-create" ) ,
694+ title : "Original" ,
695+ modelSelection,
696+ runtimeMode : "full-access" ,
697+ interactionMode : "default" ,
698+ branch : null ,
699+ worktreePath : null ,
700+ createdBy : "user" ,
701+ creationSource : "web" ,
702+ } as const ;
703+ const original = yield * orchestrator . dispatch ( create ) ;
704+ const before = yield * projections . getThread ( threadId ) ;
705+ const replayed = yield * orchestrator . dispatch ( create ) ;
706+ assert . equal ( replayed . sequence , original . sequence ) ;
707+ assert . deepEqual ( replayed , original ) ;
708+ assert . deepEqual ( yield * projections . getThread ( threadId ) , before ) ;
709+ assert . equal ( yield * orchestrator . getThreadEventSequence ( threadId ) , original . sequence ) ;
710+ } ) . pipe ( Effect . provide ( layerTest ) ) ,
711+ ) ;
0 commit comments