11// @effect -diagnostics globalTimers:off -- The Node socket client owns its response deadline and clears it on every completion path.
2+ // @effect -diagnostics-next-line nodeBuiltinImport:off -- Effect stat follows symlinks; IPC ownership validation requires lstat.
3+ import * as NodeFSP from "node:fs/promises" ;
24import * as NodeNet from "node:net" ;
35import * as NodeOS from "node:os" ;
46
@@ -9,7 +11,10 @@ import {
911 type DesktopAppActivationPlatform ,
1012 type DesktopAppActivationRequest ,
1113} from "@t3tools/contracts" ;
12- import { resolveDesktopAppControlAddress } from "@t3tools/shared/desktopAppControl" ;
14+ import {
15+ resolveDesktopAppControlAddress ,
16+ type DesktopAppControlAddress ,
17+ } from "@t3tools/shared/desktopAppControl" ;
1318import * as HostProcess from "@t3tools/shared/HostProcess" ;
1419import * as Config from "effect/Config" ;
1520import * as Console from "effect/Console" ;
@@ -77,14 +82,26 @@ function isDesktopPlatform(platform: NodeJS.Platform): platform is DesktopAppAct
7782 return platform === "darwin" || platform === "linux" || platform === "win32" ;
7883}
7984
80- function sendDesktopAppActivationRequest ( input : {
81- readonly address : string ;
82- readonly fallbackAddress ?: string ;
85+ async function sendDesktopAppActivationRequest ( input : {
86+ readonly address : DesktopAppControlAddress ;
87+ readonly fallbackAddress ?: DesktopAppControlAddress ;
88+ readonly userId : number | undefined ;
8389 readonly request : DesktopAppActivationRequest ;
8490 readonly timeoutMs ?: number ;
8591} ) : Promise < DesktopAppActivationResponse > {
92+ if ( input . address . directory !== null ) {
93+ const stat = await NodeFSP . lstat ( input . address . directory ) ;
94+ if (
95+ ! stat . isDirectory ( ) ||
96+ input . userId === undefined ||
97+ stat . uid !== input . userId ||
98+ ( stat . mode & 0o077 ) !== 0
99+ ) {
100+ throw new Error ( "The desktop app socket directory is not private or owned by this user." ) ;
101+ }
102+ }
86103 return new Promise ( ( resolve , reject ) => {
87- const socket = NodeNet . createConnection ( input . address ) ;
104+ const socket = NodeNet . createConnection ( input . address . address ) ;
88105 socket . setEncoding ( "utf8" ) ;
89106 let buffer = "" ;
90107 let settled = false ;
@@ -159,6 +176,7 @@ function sendDesktopAppActivationRequest(input: {
159176 resolve (
160177 sendDesktopAppActivationRequest ( {
161178 address : input . fallbackAddress ,
179+ userId : input . userId ,
162180 request : input . request ,
163181 ...( input . timeoutMs === undefined ? { } : { timeoutMs : input . timeoutMs } ) ,
164182 } ) ,
@@ -207,7 +225,7 @@ const runAppCommand = Effect.fn("cli.app")(function* (flags: {
207225 tempDir : NodeOS . tmpdir ( ) ,
208226 userId,
209227 joinPath : path . join ,
210- } ) . address ;
228+ } ) ;
211229 const crypto = yield * Crypto . Crypto ;
212230 const requestId = yield * crypto . randomUUIDv4 ( ) . pipe ( Effect . orDie ) ;
213231 const request : DesktopAppActivationRequest = {
@@ -224,12 +242,16 @@ const runAppCommand = Effect.fn("cli.app")(function* (flags: {
224242 try : ( ) =>
225243 sendDesktopAppActivationRequest ( {
226244 address,
245+ userId,
227246 ...( fallbackAddress === undefined ? { } : { fallbackAddress } ) ,
228247 request,
229248 } ) ,
230249 catch : ( cause ) =>
231250 new DesktopAppUnreachableError ( {
232- candidateAddresses : fallbackAddress === undefined ? [ address ] : [ address , fallbackAddress ] ,
251+ candidateAddresses :
252+ fallbackAddress === undefined
253+ ? [ address . address ]
254+ : [ address . address , fallbackAddress . address ] ,
233255 requestId : request . requestId ,
234256 workspaceRoot,
235257 cause,
0 commit comments