Skip to content

Commit 39b5c14

Browse files
Mezzleclaude
andcommitted
fix(mcp): refuse a schedule_task target whose provider the project disables
Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 6c72a2b commit 39b5c14

2 files changed

Lines changed: 27 additions & 0 deletions

File tree

‎apps/server/src/mcp/OrchestratorMcpService.test.ts‎

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3024,6 +3024,7 @@ describe("OrchestratorMcpService provider resolution", () => {
30243024
const service = (
30253025
saved: Ref.Ref<ReadonlyArray<ScheduledTask["modelSelection"]>>,
30263026
stored: ScheduledTask = existing,
3027+
enabledForProject = true,
30273028
) =>
30283029
OrchestratorMcpService.layer.pipe(
30293030
Layer.provide(Layer.mock(ThreadLaunchService.ThreadLaunchService)({})),
@@ -3040,6 +3041,7 @@ describe("OrchestratorMcpService provider resolution", () => {
30403041
NodeCrypto.layer,
30413042
Layer.mock(ThreadManagementService.ThreadManagementService)({
30423043
getThreadShell: () => Effect.succeed(null),
3044+
isProviderInstanceEnabledForProject: () => Effect.succeed(enabledForProject),
30433045
}),
30443046
ServerSettings.layerTest(),
30453047
providerRegistryLayer([codex]),
@@ -3186,6 +3188,23 @@ describe("OrchestratorMcpService provider resolution", () => {
31863188
}),
31873189
);
31883190

3191+
it.effect("refuses a provider the project has disabled, which every run would fail on", () =>
3192+
Effect.gen(function* () {
3193+
const saved = yield* Ref.make<ReadonlyArray<ScheduledTask["modelSelection"]>>([]);
3194+
const mcp = yield* OrchestratorMcpService.OrchestratorMcpService.pipe(
3195+
Effect.provide(service(saved, existing, false)),
3196+
);
3197+
const error = yield* mcp
3198+
.updateScheduledTask(client, {
3199+
scheduledTaskId: existing.id,
3200+
target: { providerInstanceId: codexInstanceId },
3201+
})
3202+
.pipe(Effect.flip);
3203+
assert.equal(error.code, "provider_unavailable");
3204+
assert.deepEqual(yield* Ref.get(saved), []);
3205+
}),
3206+
);
3207+
31893208
it.effect.each([
31903209
{ name: "an unknown model", target: { model: "gpt-0" }, code: "model_unavailable" },
31913210
{

‎apps/server/src/mcp/OrchestratorMcpService.ts‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2019,6 +2019,14 @@ const make = Effect.gen(function* () {
20192019
target,
20202020
providers: yield* loadProviders,
20212021
});
2022+
// Launch refuses a provider the project disables, so every run would fail.
2023+
const instanceId = resolved.modelSelection.instanceId;
2024+
if (!(yield* threadManagement.isProviderInstanceEnabledForProject({ projectId, instanceId }))) {
2025+
return yield* failure(
2026+
"provider_unavailable",
2027+
`Provider instance ${instanceId} is not enabled for this project.`,
2028+
);
2029+
}
20222030
return resolved.modelSelection;
20232031
});
20242032

0 commit comments

Comments
 (0)