Skip to content

Commit 390074b

Browse files
t3dotggclaude
andcommitted
fix(web): address council round 2 polish feedback
Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent f4f1ca3 commit 390074b

9 files changed

Lines changed: 20 additions & 19 deletions

File tree

‎apps/web/src/components/EnvironmentMachineIcon.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ function LucideLike(props: SVGProps<SVGSVGElement>) {
1212
viewBox="0 0 24 24"
1313
fill="none"
1414
stroke="currentColor"
15-
strokeWidth="2"
15+
strokeWidth="1.75"
1616
strokeLinecap="round"
1717
strokeLinejoin="round"
1818
{...props}

‎apps/web/src/components/chat/ComposerControl.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ function composerControlClassName(size: ComposerControlSize, className?: string)
1515
"[&_:is([data-composer-control-label],[data-chat-provider-model-picker-label])]:[text-box:trim-both_cap_alphabetic] supports-[text-box:trim-both_cap_alphabetic]:[&_:is([data-composer-control-label],[data-chat-provider-model-picker-label])]:py-1.5",
1616
size === "xs"
1717
? "h-7 gap-1 px-1.75 font-normal text-muted-foreground/70 text-sm hover:text-foreground/80 sm:h-6 sm:text-xs [&_svg:not([class*='size-'])]:size-4 sm:[&_svg:not([class*='size-'])]:size-3.5 [&_svg[data-composer-control-chevron]]:ms-0 [&_svg[data-composer-control-chevron]]:-me-1"
18-
: "h-7 gap-1.5 px-2.5 font-medium text-secondary-label [&_svg:not([class*='text-'])]:text-muted-foreground hover:text-foreground sm:text-sm [&_svg:not([class*='size-'])]:size-4.5 sm:[&_svg:not([class*='size-'])]:size-4",
18+
: "h-7 gap-1.5 px-2.5 font-medium text-foreground/80 [&_svg:not([class*='text-'])]:text-muted-foreground hover:text-foreground sm:text-sm [&_svg:not([class*='size-'])]:size-4.5 sm:[&_svg:not([class*='size-'])]:size-4",
1919
"aria-pressed:bg-accent aria-pressed:text-accent-foreground aria-pressed:hover:bg-accent/80",
2020
className,
2121
);

‎apps/web/src/components/chat/ComposerPrimaryActions.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -313,7 +313,7 @@ export const ComposerPrimaryActions = memo(function ComposerPrimaryActions({
313313
"relative isolate flex h-9 w-9 items-center justify-center overflow-hidden rounded-full shadow-xs transition-all duration-150 enabled:cursor-pointer enabled:inset-shadow-control-highlight hover:scale-105 active:inset-shadow-control-pressed active:shadow-none disabled:pointer-events-none disabled:shadow-none disabled:hover:scale-100 sm:h-8 sm:w-8 [&_svg]:pointer-events-none",
314314
stageBackdropVariant
315315
? "bg-transparent text-white enabled:shadow-black/24 enabled:hover:brightness-110 disabled:opacity-64"
316-
: "bg-message-action text-message-action-foreground enabled:shadow-message-action/24 hover:bg-message-action-hover disabled:bg-foreground/8 disabled:text-muted-foreground",
316+
: "bg-message-action text-message-action-foreground enabled:shadow-message-action/24 hover:bg-message-action-hover disabled:bg-foreground/12 disabled:text-muted-foreground",
317317
)}
318318
{...pointerFocusProps}
319319
onClick={showResume ? onResume : onSubmitMessage}

‎apps/web/src/components/preview/AgentBrowserCursor.tsx‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -87,10 +87,7 @@ export function AgentCursorMark(props: {
8787
className="absolute left-0.5 top-0.5 size-4 animate-status-ping rounded-full bg-primary/25 motion-reduce:animate-none"
8888
/>
8989
) : null}
90-
<MousePointer2
91-
className="relative size-5 -translate-x-0.5 -translate-y-0.5 fill-background text-primary drop-shadow-sm"
92-
strokeWidth={2}
93-
/>
90+
<MousePointer2 className="relative size-5 -translate-x-0.5 -translate-y-0.5 fill-background stroke-2 text-primary drop-shadow-sm" />
9491
</div>
9592
);
9693
}

‎apps/web/src/components/settings/SettingsSidebarNav.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ const SETTINGS_NAV_ITEMS: ReadonlyArray<{
106106

107107
function SettingsSectionIcon({ to }: { to: SettingsPath }) {
108108
const Icon = SETTINGS_SECTION_ICONS[to];
109-
return <Icon className="size-3.5 h-5 shrink-0 text-sidebar-muted-foreground/60" />;
109+
return <Icon className="size-4 shrink-0 text-(--sidebar-icon-color)" />;
110110
}
111111

112112
export function SettingsSidebarNav({ pathname }: { pathname: string }) {

‎apps/web/src/components/settings/settingsLayout.tsx‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,9 @@ export function SettingsSearchTarget({
183183
);
184184
}
185185

186-
export const SETTINGS_PICKER_TRIGGER_CLASSNAME = "min-w-0 max-w-none shrink-0";
186+
// Settings pickers reuse composer controls but match the bordered selects beside them.
187+
export const SETTINGS_PICKER_TRIGGER_CLASSNAME =
188+
"min-w-0 max-w-none shrink-0 border-input bg-background font-normal text-foreground shadow-xs/5 hover:bg-accent/50 dark:bg-input/32";
187189

188190
export function PolicyTooltip({ children }: { readonly children: string }) {
189191
return (
@@ -246,7 +248,7 @@ export function SettingsSection({
246248
className="flex min-h-7 items-start justify-between gap-4 px-3 sm:px-4"
247249
>
248250
<div className="flex min-w-0 items-center gap-1">
249-
<h2 className="flex min-h-7 items-center gap-2 text-sm font-semibold text-foreground">
251+
<h2 className="flex min-h-7 items-center gap-2 text-base font-semibold text-foreground">
250252
{icon}
251253
{title}
252254
</h2>

‎apps/web/src/components/sidebar/SidebarThreadRow.tsx‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -892,7 +892,9 @@ const SidebarThreadRow = memo(function SidebarThreadRow(props: SidebarThreadRowP
892892

893893
const rowSurfaceClassName = cn(
894894
"group/sidebar-row relative w-full cursor-pointer overflow-hidden rounded-md text-left outline-none select-none focus-visible:ring-2 focus-visible:ring-inset focus-visible:ring-ring",
895-
variantAction === "unsettle" && "[&:not(:hover):not(:focus-within)_*]:text-secondary-label/70",
895+
variantAction === "unsettle" &&
896+
!props.isActive &&
897+
"[&:not(:hover):not(:focus-within)_*]:text-secondary-label/70",
896898
props.isActive
897899
? "bg-sidebar-row-active text-sidebar-foreground light:shadow-xs light:ring-1 light:ring-inset light:ring-sidebar-border/70"
898900
: isSelected || props.sweepAction !== null
@@ -979,7 +981,7 @@ const SidebarThreadRow = memo(function SidebarThreadRow(props: SidebarThreadRowP
979981
? "text-foreground"
980982
: status === "failed"
981983
? "text-foreground/95"
982-
: "text-foreground/90",
984+
: "text-foreground",
983985
)
984986
: cn(
985987
"truncate group-focus-within/sidebar-row:text-foreground group-hover/sidebar-row:text-foreground",

‎apps/web/src/components/ui/menu.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ function MenuCheckboxItem({
197197
stroke="currentColor"
198198
strokeLinecap="round"
199199
strokeLinejoin="round"
200-
strokeWidth="2"
200+
strokeWidth="1.75"
201201
viewBox="0 0 24 24"
202202
width="24"
203203
xmlns="http://www.w3.org/2000/svg"

‎apps/web/src/index.css‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ html[data-mobile-composer-route-transition="true"]::view-transition-old(t3-mobil
103103
--sidebar-control-gap: 0.5rem;
104104
--sidebar-icon-color: color-mix(
105105
in srgb,
106-
var(--contrast-sidebar-muted-foreground) 60%,
106+
var(--contrast-sidebar-muted-foreground) 85%,
107107
var(--sidebar)
108108
);
109109
--sidebar-row-content-inset: 0.625rem;
@@ -193,7 +193,7 @@ html[data-mobile-composer-route-transition="true"]::view-transition-old(t3-mobil
193193
--ease-drawer: cubic-bezier(0.32, 0.72, 0, 1);
194194
/* The composer's elevation: a soft drop pulled in under the surface, shared
195195
by the composer, its context strip and attached banners. */
196-
--shadow-composer: 0 12px 28px -18px rgb(0 0 0 / 40%);
196+
--shadow-composer: 0 4px 16px -8px rgb(0 0 0 / 16%);
197197
--shadow-composer-dark: 0 14px 32px -18px rgb(0 0 0 / 75%);
198198
/* Overlap the lower toolbar backdrop by one pixel to cover the composer seam. */
199199
--spacing-composer-seam: calc(var(--spacing) * 4 - 1px);
@@ -1659,9 +1659,9 @@ body {
16591659
padding: 0;
16601660
}
16611661

1662-
/* Lighter default icon stroke. Lucide always writes stroke-width="2" unless a
1663-
caller passes its own, so explicit weights still win. */
1664-
svg.lucide[stroke-width="2"] {
1662+
/* Lighter default icon stroke. Zero specificity, so stroke-* classes still win
1663+
over it while it still beats lucide's stroke-width="2" attribute. */
1664+
:where(svg.lucide[stroke-width="2"]) {
16651665
stroke-width: 1.75;
16661666
}
16671667

@@ -2059,7 +2059,7 @@ code {
20592059
border-radius: 0.25rem;
20602060
box-decoration-break: clone;
20612061
-webkit-box-decoration-break: clone;
2062-
background: color-mix(in srgb, var(--contrast-foreground) 7%, transparent);
2062+
background: color-mix(in srgb, var(--contrast-foreground) 10%, transparent);
20632063
padding: 0.1em 0.35em;
20642064
color: var(--contrast-foreground);
20652065
font-size: 0.85em;

0 commit comments

Comments
 (0)