Skip to content

Commit 385b431

Browse files
committed
fix(preview): default browser recordings to 30 fps
1 parent 34406a2 commit 385b431

5 files changed

Lines changed: 10 additions & 10 deletions

File tree

‎apps/web/src/browser/browserRecording.test.ts‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ const { clientSettings, events, getUserMedia, registrySet, save, startScreencast
55
vi.hoisted(() => {
66
const events: string[] = [];
77
return {
8-
clientSettings: { browserRecordingFrameRate: 60 as 30 | 60 },
8+
clientSettings: { browserRecordingFrameRate: 30 as 30 | 60 },
99
events,
1010
getUserMedia: vi.fn(),
1111
registrySet: vi.fn((_atom: unknown, value: { readonly tabIds: ReadonlySet<string> }) => {
@@ -112,7 +112,7 @@ describe("browser recording", () => {
112112
FakeMediaRecorder.supportedTypes = new Set(["video/webm;codecs=vp9"]);
113113
FakeMediaRecorder.outputMimeType = undefined;
114114
FakeMediaRecorder.stopError = undefined;
115-
clientSettings.browserRecordingFrameRate = 60;
115+
clientSettings.browserRecordingFrameRate = 30;
116116
animationFrameCount = 0;
117117
vi.stubGlobal("window", globalThis);
118118
vi.stubGlobal("requestAnimationFrame", (callback: FrameRequestCallback) => {
@@ -195,7 +195,7 @@ describe("browser recording", () => {
195195
maxWidth: 1000,
196196
minHeight: 620,
197197
maxHeight: 620,
198-
maxFrameRate: 60,
198+
maxFrameRate: 30,
199199
},
200200
},
201201
});
@@ -206,14 +206,14 @@ describe("browser recording", () => {
206206
});
207207

208208
it("uses the configured recording frame rate", async () => {
209-
clientSettings.browserRecordingFrameRate = 30;
209+
clientSettings.browserRecordingFrameRate = 60;
210210

211211
await startBrowserRecording("recording-tab");
212212

213213
expect(getUserMedia).toHaveBeenCalledWith({
214214
audio: false,
215215
video: {
216-
mandatory: expect.objectContaining({ maxFrameRate: 30 }),
216+
mandatory: expect.objectContaining({ maxFrameRate: 60 }),
217217
},
218218
});
219219
await stopBrowserRecording("recording-tab");

‎apps/web/src/components/settings/IntegrationsSettings.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -364,7 +364,7 @@ function BrowserRecordingFrameRateSetting({ disabled }: { readonly disabled: boo
364364
return (
365365
<SettingsRow
366366
{...searchableSetting("browser-recording-frame-rate")}
367-
description="Maximum frame rate for browser recordings. 60 fps captures smoother motion; 30 fps uses less CPU and storage."
367+
description="Maximum frame rate for browser recordings. 30 fps is the default and uses less CPU and storage; 60 fps captures smoother motion."
368368
resetAction={
369369
!disabled && frameRate !== DEFAULT_BROWSER_RECORDING_FRAME_RATE ? (
370370
<SettingResetButton

‎apps/web/src/components/settings/SettingsPanels.logic.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,7 @@ describe("getChangedBrowserSettingLabels", () => {
268268
browserDefaultViewport: { _tag: "freeform", width: 900, height: 600 },
269269
browserDefaultZoomFactor: 1.5,
270270
browserDefaultAppearance: "dark",
271-
browserRecordingFrameRate: 30,
271+
browserRecordingFrameRate: 60,
272272
browserAutoShowFloatingPreview: !DEFAULT_UNIFIED_SETTINGS.browserAutoShowFloatingPreview,
273273
}),
274274
).toEqual([

‎packages/contracts/src/settings.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,8 @@ describe("ClientSettings word wrap", () => {
6767
});
6868

6969
describe("ClientSettings browser recording frame rate", () => {
70-
it("defaults to 60 fps", () => {
71-
expect(decodeClientSettings({}).browserRecordingFrameRate).toBe(60);
70+
it("defaults to 30 fps", () => {
71+
expect(decodeClientSettings({}).browserRecordingFrameRate).toBe(30);
7272
});
7373

7474
it.each([30, 60])("accepts a supported frame rate: %s", (frameRate) => {

‎packages/contracts/src/settings.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ export const DEFAULT_BROWSER_AUTO_SHOW_FLOATING_PREVIEW = true;
156156
export const BROWSER_RECORDING_FRAME_RATES = [30, 60] as const;
157157
export const BrowserRecordingFrameRate = Schema.Literals(BROWSER_RECORDING_FRAME_RATES);
158158
export type BrowserRecordingFrameRate = typeof BrowserRecordingFrameRate.Type;
159-
export const DEFAULT_BROWSER_RECORDING_FRAME_RATE: BrowserRecordingFrameRate = 60;
159+
export const DEFAULT_BROWSER_RECORDING_FRAME_RATE: BrowserRecordingFrameRate = 30;
160160

161161
export const ClientSettingsSchema = Schema.Struct({
162162
appearanceContrast: AppearanceContrast.pipe(

0 commit comments

Comments
 (0)