Skip to content

Commit 384c605

Browse files
afrojunclaude
andcommitted
fix(server): Codex network waits no longer show a stale retry limit
When Codex runs out of numbered reconnects ("Reconnecting... 5/5") it keeps waiting for the network indefinitely ("Reconnecting... waiting for network"). The adapter kept the old maximum for those uncounted retries, so the label climbed past it, for example "Retrying provider (272/5)". Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 47f2c8d commit 384c605

2 files changed

Lines changed: 30 additions & 5 deletions

File tree

‎apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.test.ts‎

Lines changed: 28 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3197,6 +3197,25 @@ describe("CodexAdapterV2 post-settle continuation", () => {
31973197
},
31983198
},
31993199
},
3200+
{
3201+
type: "emit_inbound",
3202+
label: "error/retry/waiting-for-network",
3203+
frame: {
3204+
method: "error",
3205+
params: {
3206+
threadId: nativeThreadId,
3207+
turnId: nativeTurnId,
3208+
willRetry: true,
3209+
error: {
3210+
message: "Reconnecting... waiting for network",
3211+
additionalDetails: "Connection failed: error sending request",
3212+
codexErrorInfo: {
3213+
responseStreamDisconnected: { httpStatusCode: null },
3214+
},
3215+
},
3216+
},
3217+
},
3218+
},
32003219
{
32013220
type: "emit_inbound",
32023221
label: "item/started/after-retry",
@@ -3280,17 +3299,22 @@ describe("CodexAdapterV2 post-settle continuation", () => {
32803299
? [event.turnItem]
32813300
: [],
32823301
);
3283-
assert.lengthOf(retryItems, 2);
3302+
assert.lengthOf(retryItems, 3);
32843303
assert.equal(retryItems[0]?.status, "running");
32853304
assert.equal(retryItems[0]?.failure.code, "responseStreamDisconnected");
32863305
assert.deepEqual(retryItems[0]?.retry, {
32873306
attempt: 2,
32883307
maxAttempts: 5,
32893308
retryDelayMs: null,
32903309
});
3291-
assert.equal(retryItems[1]?.id, retryItems[0]?.id);
3292-
assert.equal(retryItems[1]?.status, "completed");
3293-
assert.equal(retryItems[1]?.title, "Provider recovered");
3310+
assert.deepEqual(retryItems[1]?.retry, {
3311+
attempt: 3,
3312+
maxAttempts: null,
3313+
retryDelayMs: null,
3314+
});
3315+
assert.equal(retryItems[2]?.id, retryItems[0]?.id);
3316+
assert.equal(retryItems[2]?.status, "completed");
3317+
assert.equal(retryItems[2]?.title, "Provider recovered");
32943318

32953319
const recoveredIndex = harness.events.findIndex(
32963320
(event) =>

‎apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4663,7 +4663,8 @@ export const makeCodexAdapterV2 = Effect.fn("makeCodexAdapterV2")(function* (
46634663
const progress = parseCodexRetryProgress(payload.error.message);
46644664
const retry: OrchestrationV2ProviderRetry = {
46654665
attempt: progress?.attempt ?? (previous?.retry.attempt ?? 0) + 1,
4666-
maxAttempts: progress?.maxAttempts ?? previous?.retry.maxAttempts ?? null,
4666+
// Codex drops the count once it starts waiting for the network, which has no limit.
4667+
maxAttempts: progress?.maxAttempts ?? null,
46674668
retryDelayMs: null,
46684669
};
46694670
const code = codexErrorInfoCode(payload.error.codexErrorInfo);

0 commit comments

Comments
 (0)