Skip to content

Commit 369d307

Browse files
committed
fix(web): visually center breadcrumb text beside project icons
1 parent 8b657d2 commit 369d307

2 files changed

Lines changed: 43 additions & 11 deletions

File tree

‎apps/web/src/components/WorkspaceBreadcrumb.tsx‎

Lines changed: 29 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,27 @@ interface WorkspaceBreadcrumbItemProps {
2626
readonly current?: boolean;
2727
}
2828

29+
export function WorkspaceBreadcrumbText({
30+
children,
31+
className,
32+
}: {
33+
readonly children: ReactNode;
34+
readonly className?: string;
35+
}) {
36+
return (
37+
<span
38+
// Center the capital letters with adjacent icons, not the font's leading.
39+
// Padding preserves accents and descenders when a label is truncated.
40+
className={cn(
41+
"block min-w-0 truncate [text-box:trim-both_cap_alphabetic] supports-[text-box:trim-both_cap_alphabetic]:py-[0.5em]",
42+
className,
43+
)}
44+
>
45+
{children}
46+
</span>
47+
);
48+
}
49+
2950
export function WorkspaceBreadcrumbItem({
3051
children,
3152
className,
@@ -45,10 +66,16 @@ export function WorkspaceBreadcrumbItem({
4566
);
4667
}
4768

48-
export function WorkspaceBreadcrumbSeparator({ className }: { readonly className?: string }) {
69+
export function WorkspaceBreadcrumbSeparator({
70+
className,
71+
children = "/",
72+
}: {
73+
readonly className?: string;
74+
readonly children?: ReactNode;
75+
}) {
4976
return (
5077
<li aria-hidden="true" className={cn("flex shrink-0 items-center text-icon-muted", className)}>
51-
/
78+
{children}
5279
</li>
5380
);
5481
}

‎apps/web/src/components/chat/ChatHeader.tsx‎

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ import {
4646
WorkspaceBreadcrumb,
4747
WorkspaceBreadcrumbItem,
4848
WorkspaceBreadcrumbSeparator,
49+
WorkspaceBreadcrumbText,
4950
} from "../WorkspaceBreadcrumb";
5051
import { cn } from "~/lib/utils";
5152
import { useIsMobile } from "~/hooks/useMediaQuery";
@@ -421,12 +422,16 @@ export const ChatHeader = memo(function ChatHeader({
421422
}
422423
>
423424
<ProjectFavicon project={activeProject} className="size-3.5" />
424-
<span className="max-w-40 truncate">{activeProjectName}</span>
425+
<WorkspaceBreadcrumbText className="max-w-40">
426+
{activeProjectName}
427+
</WorkspaceBreadcrumbText>
425428
</TooltipTrigger>
426429
<TooltipPopup side="top">New thread in {activeProjectName}</TooltipPopup>
427430
</Tooltip>
428431
</WorkspaceBreadcrumbItem>
429-
<WorkspaceBreadcrumbSeparator />
432+
<WorkspaceBreadcrumbSeparator>
433+
<WorkspaceBreadcrumbText>/</WorkspaceBreadcrumbText>
434+
</WorkspaceBreadcrumbSeparator>
430435
</>
431436
) : null}
432437
<WorkspaceBreadcrumbItem current className="min-w-10 flex-1">
@@ -459,7 +464,9 @@ export const ChatHeader = memo(function ChatHeader({
459464
/>
460465
}
461466
>
462-
<h2 className="min-w-0 truncate">{activeThreadTitle}</h2>
467+
<h2 className="min-w-0">
468+
<WorkspaceBreadcrumbText>{activeThreadTitle}</WorkspaceBreadcrumbText>
469+
</h2>
463470
<ChevronDownIcon
464471
aria-hidden
465472
data-thread-title-chevron
@@ -471,12 +478,10 @@ export const ChatHeader = memo(function ChatHeader({
471478
) : (
472479
<Tooltip>
473480
<TooltipTrigger
474-
render={
475-
<h2 aria-label={activeThreadTitle} className="min-w-0 flex-1 truncate">
476-
{activeThreadTitle}
477-
</h2>
478-
}
479-
/>
481+
render={<h2 aria-label={activeThreadTitle} className="min-w-0 flex-1" />}
482+
>
483+
<WorkspaceBreadcrumbText>{activeThreadTitle}</WorkspaceBreadcrumbText>
484+
</TooltipTrigger>
480485
<TooltipPopup side="top">{activeThreadTitle}</TooltipPopup>
481486
</Tooltip>
482487
)}

0 commit comments

Comments
 (0)