11import { assert , describe , it } from "@effect/vitest" ;
22import * as Effect from "effect/Effect" ;
3+ import type { VerifyUpdateCodeSignature } from "electron-updater" ;
34import { beforeEach , vi } from "vite-plus/test" ;
45
56const { autoUpdaterMock } = vi . hoisted ( ( ) => ( {
@@ -13,6 +14,8 @@ const { autoUpdaterMock } = vi.hoisted(() => ({
1314 fullChangelog : false ,
1415 checkForUpdates : vi . fn ( ( ) => Promise . resolve ( null ) ) ,
1516 downloadUpdate : vi . fn ( ( ) => Promise . resolve ( [ ] ) ) ,
17+ logger : { info : vi . fn ( ) , warn : vi . fn ( ) , error : vi . fn ( ) } ,
18+ verifyUpdateCodeSignature : undefined as VerifyUpdateCodeSignature | undefined ,
1619 on : vi . fn ( ) ,
1720 quitAndInstall : vi . fn ( ) ,
1821 removeListener : vi . fn ( ) ,
@@ -43,6 +46,7 @@ describe("ElectronUpdater", () => {
4346 autoUpdaterMock . quitAndInstall . mockClear ( ) ;
4447 autoUpdaterMock . removeListener . mockClear ( ) ;
4548 autoUpdaterMock . setFeedURL . mockClear ( ) ;
49+ autoUpdaterMock . verifyUpdateCodeSignature = undefined ;
4650 } ) ;
4751
4852 it . effect ( "scopes updater event listeners" , ( ) =>
@@ -136,4 +140,84 @@ describe("ElectronUpdater", () => {
136140 assert . deepEqual ( autoUpdaterMock . quitAndInstall . mock . calls , [ [ true , false ] ] ) ;
137141 } ) . pipe ( Effect . provide ( ElectronUpdater . layer ) ) ,
138142 ) ;
143+
144+ describe ( "Windows update signature check" , ( ) => {
145+ const publisherNames = [ "T3 Tools Inc" ] ;
146+ const installerPath = "C:\\updater\\pending\\temp-T3-Code-x64.exe" ;
147+ // execFile marks the error killed when the verifier exceeds its 20-second timeout.
148+ const timedOut = ( ) =>
149+ Object . assign ( new Error ( "Command failed: powershell.exe" ) , { killed : true } ) ;
150+
151+ const downloadVerifyingSignature = ( ) => {
152+ autoUpdaterMock . downloadUpdate . mockImplementationOnce ( async ( ) => {
153+ const rejection = await autoUpdaterMock . verifyUpdateCodeSignature ! (
154+ publisherNames ,
155+ installerPath ,
156+ ) ;
157+ // NSIS accepts only null as a successful signature check.
158+ if ( rejection !== null ) throw new Error ( `Invalid signature: ${ rejection } ` ) ;
159+ return [ ] ;
160+ } ) ;
161+ return Effect . flatMap ( ElectronUpdater . ElectronUpdater , ( updater ) => updater . downloadUpdate ) ;
162+ } ;
163+
164+ it . effect ( "retries a timed-out signature check with the same verifier and installer" , ( ) =>
165+ Effect . gen ( function * ( ) {
166+ const verify = vi
167+ . fn < VerifyUpdateCodeSignature > ( )
168+ . mockRejectedValueOnce ( timedOut ( ) )
169+ . mockResolvedValueOnce ( null ) ;
170+ autoUpdaterMock . verifyUpdateCodeSignature = verify ;
171+
172+ yield * downloadVerifyingSignature ( ) ;
173+
174+ assert . deepEqual ( verify . mock . calls , [
175+ [ publisherNames , installerPath ] ,
176+ [ publisherNames , installerPath ] ,
177+ ] ) ;
178+ } ) . pipe ( Effect . provide ( ElectronUpdater . layer ) ) ,
179+ ) ;
180+
181+ it . effect ( "fails on invalid signatures, other errors and two timeouts on each download" , ( ) =>
182+ Effect . gen ( function * ( ) {
183+ const cases = [
184+ { outcome : ( ) => Promise . resolve ( "Invalid publisher" ) , calls : 1 } ,
185+ { outcome : ( ) => Promise . reject ( new Error ( "Cannot execute PowerShell" ) ) , calls : 1 } ,
186+ { outcome : ( ) => Promise . reject ( timedOut ( ) ) , calls : 2 } ,
187+ ] ;
188+ for ( const { outcome, calls } of cases ) {
189+ const verify = vi . fn < VerifyUpdateCodeSignature > ( outcome ) ;
190+ autoUpdaterMock . verifyUpdateCodeSignature = verify ;
191+
192+ // Reusing the installed verifier must neither stack retries nor exhaust future retries.
193+ for ( let download = 1 ; download <= 2 ; download ++ ) {
194+ const error = yield * downloadVerifyingSignature ( ) . pipe ( Effect . flip ) ;
195+ assert . instanceOf ( error , ElectronUpdater . ElectronUpdaterDownloadUpdateError ) ;
196+ assert . equal ( verify . mock . calls . length , calls * download ) ;
197+ }
198+ }
199+ } ) . pipe ( Effect . provide ( ElectronUpdater . layer ) ) ,
200+ ) ;
201+
202+ it . effect ( "rejects a retry when the upstream capability probe skips verification" , ( ) =>
203+ Effect . gen ( function * ( ) {
204+ const verify = vi
205+ . fn < VerifyUpdateCodeSignature > ( )
206+ . mockRejectedValueOnce ( timedOut ( ) )
207+ . mockImplementationOnce ( async ( ) => {
208+ // Upstream resolves null even though its failed capability probe skips verification.
209+ autoUpdaterMock . logger . warn (
210+ "Cannot execute ConvertTo-Json: spawnSync powershell.exe ETIMEDOUT. Ignoring signature validation due to unsupported powershell version. Please upgrade to powershell 3 or higher." ,
211+ ) ;
212+ return null ;
213+ } ) ;
214+ autoUpdaterMock . verifyUpdateCodeSignature = verify ;
215+
216+ const error = yield * downloadVerifyingSignature ( ) . pipe ( Effect . flip ) ;
217+
218+ assert . instanceOf ( error , ElectronUpdater . ElectronUpdaterDownloadUpdateError ) ;
219+ assert . equal ( verify . mock . calls . length , 2 ) ;
220+ } ) . pipe ( Effect . provide ( ElectronUpdater . layer ) ) ,
221+ ) ;
222+ } ) ;
139223} ) ;
0 commit comments