Skip to content

Commit 368e0e1

Browse files
t3dotggclaude
andcommitted
Let an explicit task start re-open a tombstoned task id
Tombstones exist to stop late/duplicate progress from resurrecting a finished task, but providers reuse task ids when an agent is resumed — a fresh task.started after completion is real work, not a replay. Progress stays blocked by the tombstone; an explicit start clears it. Co-Authored-By: Claude Fable 5 <[email protected]>
1 parent 514fccf commit 368e0e1

2 files changed

Lines changed: 60 additions & 1 deletion

File tree

‎apps/server/src/orchestration/Layers/ProviderRuntimeIngestion.test.ts‎

Lines changed: 53 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3479,6 +3479,59 @@ describe("ProviderRuntimeIngestion", () => {
34793479
await waitForThread(harness.readModel, (entry) => entry.session?.status === "ready");
34803480
});
34813481

3482+
it("re-opens a completed task on an explicit restart (resumed agent)", async () => {
3483+
const harness = await createHarness();
3484+
const now = "2026-01-01T00:00:00.000Z";
3485+
3486+
harness.emit({
3487+
type: "task.started",
3488+
eventId: asEventId("evt-resumed-task-started"),
3489+
provider: ProviderDriverKind.make("codex"),
3490+
createdAt: now,
3491+
threadId: asThreadId("thread-1"),
3492+
payload: {
3493+
taskId: "resumed-task-1",
3494+
},
3495+
});
3496+
harness.emit({
3497+
type: "task.completed",
3498+
eventId: asEventId("evt-resumed-task-completed"),
3499+
provider: ProviderDriverKind.make("codex"),
3500+
createdAt: "2026-01-01T00:00:01.000Z",
3501+
threadId: asThreadId("thread-1"),
3502+
payload: {
3503+
taskId: "resumed-task-1",
3504+
status: "completed",
3505+
},
3506+
});
3507+
// The agent is resumed: the same task id starts again. The tombstone
3508+
// must yield to the explicit start…
3509+
harness.emit({
3510+
type: "task.started",
3511+
eventId: asEventId("evt-resumed-task-restarted"),
3512+
provider: ProviderDriverKind.make("codex"),
3513+
createdAt: "2026-01-01T00:00:02.000Z",
3514+
threadId: asThreadId("thread-1"),
3515+
payload: {
3516+
taskId: "resumed-task-1",
3517+
},
3518+
});
3519+
harness.emit({
3520+
type: "turn.completed",
3521+
eventId: asEventId("evt-resumed-task-turn-completed"),
3522+
provider: ProviderDriverKind.make("codex"),
3523+
threadId: asThreadId("thread-1"),
3524+
createdAt: "2026-01-01T00:00:03.000Z",
3525+
turnId: asTurnId("turn-resumed-task"),
3526+
payload: {
3527+
state: "completed",
3528+
},
3529+
});
3530+
3531+
// …so the turn parks on Waiting for the resumed agent.
3532+
await waitForThread(harness.readModel, (entry) => entry.session?.status === "idle");
3533+
});
3534+
34823535
it("ignores task events from a stale provider instance", async () => {
34833536
const harness = await createHarness();
34843537
const now = "2026-01-01T00:00:00.000Z";

‎apps/server/src/orchestration/Layers/ProviderRuntimeIngestion.ts‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -795,7 +795,13 @@ const make = Effect.gen(function* () {
795795
return true;
796796
}
797797
if (entry.closedTaskIds.has(taskId)) {
798-
return false;
798+
// task.progress for a finished task is a late duplicate and stays
799+
// ignored. task.started is authoritative: providers reuse task ids
800+
// when an agent is resumed, so an explicit start re-opens the task.
801+
if (event.type !== "task.started") {
802+
return false;
803+
}
804+
entry.closedTaskIds.delete(taskId);
799805
}
800806
const wasEmpty = entry.taskIds.size === 0;
801807
entry.taskIds.add(taskId);

0 commit comments

Comments
 (0)