Skip to content

Commit 34c9543

Browse files
ScottN-PVclaude
andcommitted
fix(web): scheduled task times name the server's timezone
Fixed-time schedules run in the server's timezone, but the settings row, the Run at picker and the thread's automations panel showed the bare time. A browser in another zone could not tell when a task would run. The scheduled task list now carries the server's IANA zone, and those three places name it ("Daily at 16:31 UTC"). Older servers send no zone, and their labels stay as they were. Refs #18632 Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 5307c23 commit 34c9543

8 files changed

Lines changed: 96 additions & 18 deletions

File tree

‎apps/server/src/scheduledTasks/ScheduledTaskService.schedule.test.ts‎

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,25 @@ it.effect("rejects a stale form save after deletion while preserving explicit-id
5353
}).pipe(Effect.provide(SqlitePersistence.layerMemory)),
5454
);
5555

56+
it.effect("lists the zone fixed-time schedules run in, before any task exists", () =>
57+
Effect.gen(function* () {
58+
const layerDependencies = Layer.mergeAll(
59+
NodeCrypto.layer,
60+
Scheduler.layer,
61+
Layer.mock(ThreadLaunchService.ThreadLaunchService)({}),
62+
Layer.mock(ThreadManagementService.ThreadManagementService)({}),
63+
Layer.mock(SecretRequests.SecretRequests)({}),
64+
);
65+
yield* Effect.gen(function* () {
66+
const service = yield* ScheduledTaskService.ScheduledTaskService;
67+
expect(yield* service.list()).toEqual({
68+
tasks: [],
69+
timeZone: DateTime.zoneToString(DateTime.zoneMakeLocal()),
70+
});
71+
}).pipe(Effect.provide(ScheduledTaskService.layer.pipe(Layer.provide(layerDependencies))));
72+
}).pipe(Effect.provide(SqlitePersistence.layerMemory)),
73+
);
74+
5675
it.effect("preserves a due run when a save only pads the scheduled hour", () =>
5776
Effect.gen(function* () {
5877
const dueAt = DateTime.makeZonedUnsafe(

‎apps/server/src/scheduledTasks/ScheduledTaskService.ts‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -916,7 +916,11 @@ export const layer = Layer.effect(
916916

917917
const list: ScheduledTaskService["Service"]["list"] = () =>
918918
listRows().pipe(
919-
Effect.map((tasks) => ({ tasks })),
919+
// Fixed-time schedules run in the server's zone, which a client cannot see on its own.
920+
Effect.map((tasks) => ({
921+
tasks,
922+
timeZone: DateTime.zoneToString(DateTime.zoneMakeLocal()),
923+
})),
920924
Effect.mapError((cause) => taskError("Could not list schedule tasks.", { cause })),
921925
);
922926

‎apps/server/src/ws.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1309,6 +1309,7 @@ const layerWsRpc = (
13091309
currentSession.scopes.includes(AuthOrchestrationOperateScope)
13101310
? result
13111311
: {
1312+
...result,
13121313
tasks: result.tasks.map(({ webhook: _webhook, ...task }) => task),
13131314
};
13141315
const authorizeEffect = <A, E, R>(

‎apps/web/src/components/chat/ThreadAutomationsPanel.tsx‎

Lines changed: 32 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,24 @@ import {
3030
THREAD_DETAILS_PANEL_ROW_CONTENT_CLASS,
3131
} from "./threadDetailsPanelStyles";
3232

33+
function scheduleSummary(task: ScheduledTask, timeZone: string | undefined) {
34+
return (
35+
<>
36+
{scheduleLabel(task.schedule, timeZone)}
37+
{task.enabled && task.nextRunAt !== null ? (
38+
<>
39+
{" · next "}
40+
<ScheduledRelativeLabel value={task.nextRunAt} />
41+
</>
42+
) : task.enabled ? (
43+
""
44+
) : (
45+
" · paused"
46+
)}
47+
</>
48+
);
49+
}
50+
3351
const STATUS_DOT_CLASS: Record<ScheduledTask["lastRunStatus"], string> = {
3452
never: "bg-muted-foreground/40",
3553
running: "bg-sky-500",
@@ -166,19 +184,20 @@ export function ThreadAutomationsPanel(props: {
166184
<span className="block truncate text-sm font-medium text-foreground/80">
167185
{task.title}
168186
</span>
169-
<p className="truncate text-2xs text-muted-foreground">
170-
{scheduleLabel(task.schedule)}
171-
{task.enabled && task.nextRunAt !== null ? (
172-
<>
173-
{" · next "}
174-
<ScheduledRelativeLabel value={task.nextRunAt} />
175-
</>
176-
) : task.enabled ? (
177-
""
178-
) : (
179-
" · paused"
180-
)}
181-
</p>
187+
{/* The card is narrow, so the line can cut off the zone; hover or focus shows all of it. */}
188+
<Tooltip>
189+
<TooltipTrigger
190+
render={
191+
<p
192+
tabIndex={0}
193+
className="truncate rounded-sm text-2xs text-muted-foreground focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-inset focus-visible:ring-ring"
194+
/>
195+
}
196+
>
197+
{scheduleSummary(task, tasksQuery.data?.timeZone)}
198+
</TooltipTrigger>
199+
<TooltipPopup>{scheduleSummary(task, tasksQuery.data?.timeZone)}</TooltipPopup>
200+
</Tooltip>
182201
</div>
183202
<Tooltip>
184203
<TooltipTrigger

‎apps/web/src/components/settings/ScheduledTasksSettings.tsx‎

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ import {
8080
type DraftState,
8181
type ScheduleMode,
8282
type WorkspaceMode,
83+
scheduleTimeZoneLabel,
8384
} from "./scheduledTasksSettings.logic";
8485
import { Label } from "../ui/label";
8586
import { Menu, MenuTrigger, MenuPopup, MenuItem, MenuSeparator } from "../ui/menu";
@@ -179,7 +180,7 @@ function splitModelKey(value: string): ModelSelection | null {
179180
};
180181
}
181182

182-
export function scheduleLabel(schedule: ScheduledTaskSchedule): string {
183+
export function scheduleLabel(schedule: ScheduledTaskSchedule, timeZone?: string): string {
183184
if (schedule.type === "webhook") return "On webhook";
184185
if (schedule.type === "interval") {
185186
const minutes = schedule.everyMs / 60_000;
@@ -194,7 +195,8 @@ export function scheduleLabel(schedule: ScheduledTaskSchedule): string {
194195
: weekdays.length === 5 && weekdays.every((day) => day >= 1 && day <= 5)
195196
? "Weekdays"
196197
: weekdays.map((day) => WEEKDAY_LABELS[day]).join(", ");
197-
return `${days} at ${schedule.timeOfDay}`;
198+
const zone = scheduleTimeZoneLabel(timeZone);
199+
return `${days} at ${schedule.timeOfDay}${zone === null ? "" : ` ${zone}`}`;
198200
}
199201

200202
/**
@@ -364,6 +366,7 @@ function ScheduledTaskEnvironmentList({
364366
return {
365367
environment,
366368
connected: index >= 0,
369+
timeZone: data?.timeZone,
367370
tasks: data?.tasks.filter((task) =>
368371
matchesScheduledTaskScope(scope, environment.environmentId, task.projectId),
369372
),
@@ -405,7 +408,7 @@ function ScheduledTaskEnvironmentList({
405408

406409
return (
407410
<SettingsGroup>
408-
{populated.map(({ environment, tasks }) => {
411+
{populated.map(({ environment, tasks, timeZone }) => {
409412
const { primary, secondary } = settingsScopeEnvironmentLabels(environment, environments);
410413
const transport = environmentTransportLabel(environment);
411414
return (
@@ -435,6 +438,7 @@ function ScheduledTaskEnvironmentList({
435438
key={task.id}
436439
environmentId={environment.environmentId}
437440
task={task}
441+
timeZone={timeZone}
438442
onEdit={() => onEdit(environment.environmentId, task)}
439443
/>
440444
))}
@@ -550,6 +554,7 @@ function ScheduledTaskEnvironmentSection({
550554
key={task.id}
551555
environmentId={environment.environmentId}
552556
task={task}
557+
timeZone={tasksQuery.data?.timeZone}
553558
onEdit={() => onEdit(environment.environmentId, task)}
554559
/>
555560
))
@@ -563,10 +568,12 @@ function ScheduledTaskEnvironmentSection({
563568
function ScheduledTaskRow({
564569
environmentId,
565570
task,
571+
timeZone,
566572
onEdit,
567573
}: {
568574
readonly environmentId: EnvironmentId;
569575
readonly task: ScheduledTask;
576+
readonly timeZone: string | undefined;
570577
readonly onEdit: () => void;
571578
}) {
572579
const canOperate = useAtomValue(
@@ -611,7 +618,7 @@ function ScheduledTaskRow({
611618
status={
612619
<div className="flex flex-wrap items-center gap-2">
613620
<span>
614-
{scheduleLabel(task.schedule)} ·{" "}
621+
{scheduleLabel(task.schedule, timeZone)} ·{" "}
615622
{!task.enabled ? (
616623
"Paused"
617624
) : isWebhook ? (
@@ -998,6 +1005,7 @@ function ScheduledTaskEditorForm({
9981005
draft.editingId !== null &&
9991006
tasksQuery.data !== null &&
10001007
!tasksQuery.data.tasks.some((entry) => entry.id === draft.editingId);
1008+
const runAtZone = scheduleTimeZoneLabel(tasksQuery.data?.timeZone);
10011009
const liveTask = tasksQuery.data
10021010
? (tasksQuery.data.tasks.find((entry) => entry.id === draft.editingId) ?? null)
10031011
: task;
@@ -1501,6 +1509,9 @@ function ScheduledTaskEditorForm({
15011509
setDraft((current) => ({ ...current, timeOfDay: event.target.value }))
15021510
}
15031511
/>
1512+
{runAtZone === null ? null : (
1513+
<span className="text-xs text-muted-foreground">{runAtZone}</span>
1514+
)}
15041515
<span className="text-xs text-muted-foreground">on</span>
15051516
</div>
15061517
<ToggleGroup

‎apps/web/src/components/settings/scheduledTasksSettings.logic.test.ts‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import {
2020
scheduledTaskDefaultModel,
2121
matchesScheduledTaskScope,
2222
scheduleFromDraft,
23+
scheduleTimeZoneLabel,
2324
taskToDraft,
2425
} from "./scheduledTasksSettings.logic";
2526

@@ -314,3 +315,15 @@ describe("scheduled task model defaults", () => {
314315
).toBeNull();
315316
});
316317
});
318+
319+
describe("scheduleTimeZoneLabel", () => {
320+
it("names the server's zone, with UTC shown as UTC", () => {
321+
expect(scheduleTimeZoneLabel("Etc/UTC")).toBe("UTC");
322+
expect(scheduleTimeZoneLabel("UTC")).toBe("UTC");
323+
expect(scheduleTimeZoneLabel("Asia/Kolkata")).toBe("Asia/Kolkata");
324+
});
325+
326+
it("names nothing for an older server that does not report its zone", () => {
327+
expect(scheduleTimeZoneLabel(undefined)).toBeNull();
328+
});
329+
});

‎apps/web/src/components/settings/scheduledTasksSettings.logic.ts‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,15 @@ import type { ProviderInstanceEntry } from "../../providerInstances";
1919

2020
import type { ResolvedSettingsScope } from "./settingsScope";
2121

22+
/**
23+
* The zone to name after a fixed-time schedule, from the one the server reports. Older
24+
* servers report none, so their labels stay as they were.
25+
*/
26+
export function scheduleTimeZoneLabel(timeZone: string | undefined): string | null {
27+
if (timeZone === undefined) return null;
28+
return timeZone === "Etc/UTC" || timeZone === "UTC" ? "UTC" : timeZone;
29+
}
30+
2231
export function matchesScheduledTaskScope(
2332
scope: ResolvedSettingsScope,
2433
environmentId: EnvironmentId,

‎packages/contracts/src/scheduledTask.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,8 @@ export const ScheduledTaskListResult = Schema.Struct({
196196
// Trigger types grow over time; a client must not lose the whole list over
197197
// one task it cannot decode.
198198
tasks: ForwardCompatibleArray(ScheduledTask),
199+
/** The IANA zone fixed-time schedules run in. Absent from older servers. */
200+
timeZone: Schema.optional(TrimmedNonEmptyString),
199201
});
200202
export type ScheduledTaskListResult = typeof ScheduledTaskListResult.Type;
201203

0 commit comments

Comments
 (0)