@@ -3896,77 +3896,112 @@ it.effect("ProviderSessionManagerV2 settles a request the event pump persists du
38963896 } ) ,
38973897) ;
38983898
3899- it . effect ( "ProviderSessionManagerV2 terminalizes a pending input transcript item on release" , ( ) =>
3900- Effect . gen ( function * ( ) {
3901- const state = yield * Ref . make ( emptyState ) ;
3902- const effect = Effect . gen ( function * ( ) {
3903- const eventSink = yield * EventSink . EventSinkV2 ;
3904- const idAllocator = yield * IdAllocator . IdAllocatorV2 ;
3905- const manager = yield * ProviderSessionManager . ProviderSessionManagerV2 ;
3906- const projectionStore = yield * ProjectionStore . ProjectionStoreV2 ;
3907- const now = yield * DateTime . now ;
3908- const projectId = yield * idAllocator . allocate . project ( {
3909- fixtureName : "provider-session-manager-request-expire" ,
3910- } ) ;
3911- const threadId = yield * idAllocator . allocate . thread ( {
3912- fixtureName : "provider-session-manager-request-expire" ,
3913- projectId,
3914- } ) ;
3915- const providerSessionId = yield * idAllocator . allocate . providerSession ( {
3916- providerInstanceId : modelSelection . instanceId ,
3917- threadId,
3918- } ) ;
3919- const providerThread = makeProviderThread ( {
3920- idAllocator,
3921- threadId,
3922- providerSessionId,
3923- now,
3924- } ) ;
3899+ it . effect . each ( [ "runtime_error" , "manual_shutdown" , "server_shutdown" ] as const ) (
3900+ "ProviderSessionManagerV2 applies question recovery policy during %s release" ,
3901+ ( reason ) =>
3902+ Effect . gen ( function * ( ) {
3903+ const state = yield * Ref . make ( emptyState ) ;
3904+ const effect = Effect . gen ( function * ( ) {
3905+ const eventSink = yield * EventSink . EventSinkV2 ;
3906+ const idAllocator = yield * IdAllocator . IdAllocatorV2 ;
3907+ const manager = yield * ProviderSessionManager . ProviderSessionManagerV2 ;
3908+ const projectionStore = yield * ProjectionStore . ProjectionStoreV2 ;
3909+ const now = yield * DateTime . now ;
3910+ const projectId = yield * idAllocator . allocate . project ( {
3911+ fixtureName : "provider-session-manager-request-expire" ,
3912+ } ) ;
3913+ const threadId = yield * idAllocator . allocate . thread ( {
3914+ fixtureName : "provider-session-manager-request-expire" ,
3915+ projectId,
3916+ } ) ;
3917+ const providerSessionId = yield * idAllocator . allocate . providerSession ( {
3918+ providerInstanceId : modelSelection . instanceId ,
3919+ threadId,
3920+ } ) ;
3921+ const providerThread = makeProviderThread ( {
3922+ idAllocator,
3923+ threadId,
3924+ providerSessionId,
3925+ now,
3926+ } ) ;
39253927
3926- yield * eventSink . write ( {
3927- events : [ yield * makeThreadCreatedEvent ( { idAllocator, threadId, now } ) ] ,
3928- } ) ;
3929- const pendingRequest = yield * makePendingRuntimeRequestEvents ( {
3930- idAllocator,
3931- threadId,
3932- providerSessionId,
3933- providerThread,
3934- now,
3935- } ) ;
3936- yield * eventSink . write ( {
3937- events : pendingRequest . events . map ( ( event ) =>
3938- event . type === "turn-item.updated"
3939- ? { ...event , payload : { ...event . payload , type : "user_input_request" , questions : [ ] } }
3940- : event ,
3941- ) ,
3942- } ) ;
3943- yield * manager . open ( {
3944- threadId,
3945- providerSessionId,
3946- modelSelection,
3947- runtimePolicy,
3948- } ) ;
3949- yield * manager . release ( {
3950- providerSessionId,
3951- reason : "runtime_error" ,
3952- detail : "process exited" ,
3953- } ) ;
3928+ yield * eventSink . write ( {
3929+ events : [ yield * makeThreadCreatedEvent ( { idAllocator, threadId, now } ) ] ,
3930+ } ) ;
3931+ const pendingRequest = yield * makePendingRuntimeRequestEvents ( {
3932+ idAllocator,
3933+ threadId,
3934+ providerSessionId,
3935+ providerThread,
3936+ now,
3937+ } ) ;
3938+ yield * eventSink . write ( {
3939+ events : pendingRequest . events . map ( ( event ) =>
3940+ event . type === "turn-item.updated"
3941+ ? {
3942+ ...event ,
3943+ payload : {
3944+ ...event . payload ,
3945+ type : "user_input_request" ,
3946+ questions : [
3947+ {
3948+ id : "lookback" ,
3949+ header : "Lookback" ,
3950+ question : "How far back?" ,
3951+ options : [ ] ,
3952+ } ,
3953+ ] ,
3954+ } ,
3955+ }
3956+ : event . type === "runtime-request.updated"
3957+ ? { ...event , payload : { ...event . payload , kind : "user_input" } }
3958+ : event . type === "node.updated" &&
3959+ event . payload . runtimeRequestId === pendingRequest . requestId
3960+ ? { ...event , payload : { ...event . payload , kind : "user_input_request" } }
3961+ : event ,
3962+ ) ,
3963+ } ) ;
3964+ yield * manager . open ( {
3965+ threadId,
3966+ providerSessionId,
3967+ modelSelection,
3968+ runtimePolicy,
3969+ } ) ;
3970+ yield * manager . release ( {
3971+ providerSessionId,
3972+ reason,
3973+ detail : "process exited" ,
3974+ } ) ;
39543975
3955- const projection = yield * projectionStore . getThreadProjection ( threadId ) ;
3956- const request = projection . runtimeRequests . at ( - 1 ) ;
3957- const requestNode = projection . nodes . find ( ( node ) => node . id === request ?. nodeId ) ;
3958- const requestTurnItem = projection . turnItems . find (
3959- ( item ) => item . type === "user_input_request" && item . requestId === request ?. id ,
3960- ) ;
3976+ const projection = yield * projectionStore . getThreadProjection ( threadId ) ;
3977+ const request = projection . runtimeRequests . at ( - 1 ) ;
3978+ const requestNode = projection . nodes . find ( ( node ) => node . id === request ?. nodeId ) ;
3979+ const requestTurnItem = projection . turnItems . find (
3980+ ( item ) => item . type === "user_input_request" && item . requestId === request ?. id ,
3981+ ) ;
39613982
3962- assert . equal ( request ?. status , "expired" ) ;
3963- assert . equal ( request ?. responseCapability . type , "not_resumable" ) ;
3964- assert . equal ( requestNode ?. status , "failed" ) ;
3965- assert . equal ( requestTurnItem ?. status , "failed" ) ;
3966- } ) ;
3983+ if ( reason === "server_shutdown" ) {
3984+ assert . equal ( request ?. status , "pending" ) ;
3985+ assert . equal ( request ?. responseCapability . type , "message" ) ;
3986+ assert . equal ( requestNode ?. status , "waiting" ) ;
3987+ assert . equal ( requestTurnItem ?. status , "waiting" ) ;
3988+ assert . equal ( requestTurnItem ?. type , "user_input_request" ) ;
3989+ if ( requestTurnItem ?. type === "user_input_request" ) {
3990+ assert . isUndefined ( requestTurnItem . responseMode ) ;
3991+ }
3992+ } else {
3993+ assert . equal ( request ?. status , reason === "runtime_error" ? "expired" : "cancelled" ) ;
3994+ assert . equal ( request ?. responseCapability . type , "not_resumable" ) ;
3995+ assert . equal ( requestNode ?. status , reason === "runtime_error" ? "failed" : "cancelled" ) ;
3996+ assert . equal (
3997+ requestTurnItem ?. status ,
3998+ reason === "runtime_error" ? "failed" : "cancelled" ,
3999+ ) ;
4000+ }
4001+ } ) ;
39674002
3968- yield * effect . pipe ( Effect . provide ( layerTest ( { state, idleTimeoutMs : 1000 } ) ) ) ;
3969- } ) ,
4003+ yield * effect . pipe ( Effect . provide ( layerTest ( { state, idleTimeoutMs : 1000 } ) ) ) ;
4004+ } ) ,
39704005) ;
39714006
39724007it . effect ( "ProviderSessionManagerV2 persists session-scoped runtime requests without a run" , ( ) =>
0 commit comments