Skip to content

Commit 3415fd2

Browse files
chore: stop committing pull request assets
Co-authored-by: maria <[email protected]>
1 parent 8f7da3b commit 3415fd2

6 files changed

Lines changed: 10 additions & 3 deletions

File tree

‎.github/pr-assets/6424-after.svg‎

Lines changed: 0 additions & 1 deletion
This file was deleted.

‎.github/pr-assets/6424-before.svg‎

Lines changed: 0 additions & 1 deletion
This file was deleted.

‎.github/pr-assets/6503-after.svg‎

Lines changed: 0 additions & 1 deletion
This file was deleted.

‎.github/workflows/ci.yml‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,14 @@ jobs:
2424
!/.repos/
2525
sparse-checkout-cone-mode: false
2626

27+
- name: Reject repository-owned PR assets
28+
run: |
29+
files="$(git ls-files .github/pr-assets)"
30+
if test -n "$files"; then
31+
printf 'PR evidence must be uploaded to GitHub, not committed:\n%s\n' "$files" >&2
32+
exit 1
33+
fi
34+
2735
- name: Setup Vite+
2836
uses: voidzero-dev/setup-vp@v1
2937
with:

‎.gitignore‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ dist-electron/
3131
.showcase/
3232
apps/mobile/.showcase/
3333
artifacts/app-store/screenshots/
34+
.github/pr-assets/
3435
native/**/target/
3536
node_modules/
3637
.alchemy/

‎AGENTS.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,7 @@ An empty database is a bad test. Seed your worktree's `.t3` with a copy of real
115115
- Conventional commit titles, plain language: `fix(web): new threads no longer spike CPU`.
116116
- Body: the problem in a sentence or two, then how you fixed it. End with the model and harness that did the work.
117117
- UI changes need before/after images. Motion or timing needs a short video.
118+
- Upload PR evidence to GitHub. Never commit PR-only screenshots or assets such as `.github/pr-assets/`.
118119
- One concern per PR. If the description says "also", split it.
119120
- When babysitting: poll checks and comments newer than the last push, verify each bot finding against the source, fix real ones, dismiss false positives with a written reason. Stay quiet when nothing is new. Stop when the bots are green on the latest commit.
120121

0 commit comments

Comments
 (0)