Skip to content

Commit 31a7924

Browse files
committed
fix(mobile): gate live recording on Android 12
1 parent 14b8f21 commit 31a7924

3 files changed

Lines changed: 28 additions & 3 deletions

File tree

‎apps/mobile/modules/t3-voice-transcription/android/src/main/java/expo/modules/t3voicetranscription/T3VoiceTranscriptionModule.kt‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,9 @@ class T3VoiceTranscriptionModule : Module() {
8686
}
8787
}
8888

89-
defineLiveRecorder()
89+
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S) {
90+
defineLiveRecorder()
91+
}
9092

9193
AsyncFunction("cancel") { id: Int, promise: Promise ->
9294
scope.launch {

‎apps/mobile/src/native/voiceTranscription.android.test.ts‎

Lines changed: 21 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,17 @@ const mocks = vi.hoisted(() => ({
55
prepare: vi.fn<(id: number) => Promise<{ locale: string; mode: number }>>(),
66
transcribe: vi.fn<(id: number, uri: string, locale: string, mode: number) => Promise<string>>(),
77
cancel: vi.fn<(id: number) => Promise<void>>(),
8+
LiveVoiceRecorder: class {
9+
readonly uri = "file:///live.pcm";
10+
},
11+
}));
12+
13+
vi.mock("react-native", () => ({
14+
Platform: {
15+
get Version() {
16+
return 31;
17+
},
18+
},
819
}));
920

1021
vi.mock("expo", () => ({
@@ -15,8 +26,17 @@ import {
1526
VoiceInputController,
1627
resetVoiceInputGlobalsForTests,
1728
} from "../../../../packages/client-runtime/src/voice-input/controller";
29+
import { Platform } from "react-native";
30+
31+
import { createLiveVoiceRecorder, getLocalVoiceTranscriber } from "./voiceTranscription.android";
1832

19-
import { getLocalVoiceTranscriber } from "./voiceTranscription.android";
33+
it.each([
34+
[30, null],
35+
[31, "file:///live.pcm"],
36+
] as const)("offers live recording only on supported Android versions (%s)", (version, uri) => {
37+
using _version = vi.spyOn(Platform, "Version", "get").mockReturnValue(version);
38+
expect(createLiveVoiceRecorder()?.uri ?? null).toBe(uri);
39+
});
2040

2141
it.each([false, true])(
2242
"waits for device support before offering a transcriber (%s)",

‎apps/mobile/src/native/voiceTranscription.android.ts‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import { requireOptionalNativeModule } from "expo";
22
import type { RecorderState, RecordingStatus } from "expo-audio";
3+
import { Platform } from "react-native";
34
import type { NativeVoiceRecorder } from "../features/voice-input/lazyVoiceRecorder";
45

56
import {
@@ -38,7 +39,9 @@ const nativeErrorMessages: Readonly<Record<string, string>> = {
3839
let nextOperationId = 0;
3940

4041
export function createLiveVoiceRecorder() {
41-
return native?.LiveVoiceRecorder ? new native.LiveVoiceRecorder() : null;
42+
return Number(Platform.Version) >= 31 && native?.LiveVoiceRecorder
43+
? new native.LiveVoiceRecorder()
44+
: null;
4245
}
4346

4447
export async function getLocalVoiceTranscriber(): Promise<VoiceTranscriber | null> {

0 commit comments

Comments
 (0)