11import * as NodeServices from "@effect/platform-node/NodeServices" ;
22import {
33 EnvironmentId ,
4+ PREVIEW_MCP_NAV_DIAGNOSTIC_MAX_LENGTH ,
5+ PreviewMcpListResult ,
46 ProviderInstanceId ,
57 ThreadId ,
68 type PreviewAutomationRequest ,
79} from "@t3tools/contracts" ;
810import { expect , it } from "@effect/vitest" ;
911import * as Effect from "effect/Effect" ;
12+ import * as Deferred from "effect/Deferred" ;
13+ import * as Fiber from "effect/Fiber" ;
1014import * as Layer from "effect/Layer" ;
1115import * as PubSub from "effect/PubSub" ;
12- import * as Result from "effect/Result" ;
16+ import * as Ref from "effect/Ref" ;
17+ import * as Schema from "effect/Schema" ;
1318import * as Stream from "effect/Stream" ;
1419
1520import * as PreviewManager from "../preview/Manager.ts" ;
@@ -18,6 +23,7 @@ import * as PreviewAutomationBroker from "./PreviewAutomationBroker.ts";
1823import * as PreviewMcpService from "./PreviewMcpService.ts" ;
1924
2025const environmentId = EnvironmentId . make ( "environment-preview-mcp" ) ;
26+ const decodePreviewMcpListResult = Schema . decodeUnknownSync ( PreviewMcpListResult ) ;
2127const scopeFor = (
2228 threadId : ThreadId ,
2329 capabilities : McpInvocationContext . McpInvocationScope [ "capabilities" ] = new Set ( [ "preview" ] ) ,
@@ -70,6 +76,56 @@ it.layer(TestLayer)("PreviewMcpService", (it) => {
7076 } ) ,
7177 ) ;
7278
79+ it . effect ( "keeps long thread ids out of cursors and bounds failed-navigation diagnostics" , ( ) =>
80+ Effect . gen ( function * ( ) {
81+ const manager = yield * PreviewManager . PreviewManager ;
82+ const service = yield * PreviewMcpService . PreviewMcpService ;
83+ const currentThreadId = ThreadId . make ( `thread-preview-long-${ "x" . repeat ( 4_000 ) } ` ) ;
84+ const scope = scopeFor ( currentThreadId ) ;
85+ const opened = yield * Effect . all ( [
86+ manager . open ( { threadId : currentThreadId } ) ,
87+ manager . open ( { threadId : currentThreadId } ) ,
88+ ] ) ;
89+ const failed = opened [ 0 ] ! ;
90+ yield * manager . reportStatus ( {
91+ threadId : currentThreadId ,
92+ tabId : failed . tabId ,
93+ navStatus : {
94+ _tag : "LoadFailed" ,
95+ url : "http://localhost:3000" ,
96+ title : "Failed preview" ,
97+ code : - 2 ,
98+ description : "diagnostic" . repeat ( 1_000 ) ,
99+ } ,
100+ canGoBack : false ,
101+ canGoForward : false ,
102+ } ) ;
103+
104+ const first = yield * service . list ( scope , { limit : 1 } ) ;
105+ expect ( first . nextCursor ?. length ) . toBeLessThanOrEqual ( 512 ) ;
106+ const second = yield * service . list ( scope , { limit : 1 , cursor : first . nextCursor ! } ) ;
107+ expect ( [ ...first . sessions , ...second . sessions ] ) . toHaveLength ( 2 ) ;
108+ const failedResult = [ ...first . sessions , ...second . sessions ] . find (
109+ ( session ) => session . tabId === failed . tabId ,
110+ ) ;
111+ expect ( failedResult ?. navStatus . _tag ) . toBe ( "LoadFailed" ) ;
112+ if ( failedResult ?. navStatus . _tag === "LoadFailed" ) {
113+ expect ( failedResult . navStatus . description ) . toHaveLength (
114+ PREVIEW_MCP_NAV_DIAGNOSTIC_MAX_LENGTH ,
115+ ) ;
116+ expect ( failedResult . navStatus . descriptionTruncated ) . toBe ( true ) ;
117+ }
118+ expect ( ( ) => decodePreviewMcpListResult ( first ) ) . not . toThrow ( ) ;
119+ expect ( ( ) => decodePreviewMcpListResult ( second ) ) . not . toThrow ( ) ;
120+
121+ const foreignLongThreadId = ThreadId . make ( `thread-preview-other-${ "x" . repeat ( 4_000 ) } ` ) ;
122+ const foreign = yield * service
123+ . list ( scopeFor ( foreignLongThreadId ) , { cursor : first . nextCursor ! } )
124+ . pipe ( Effect . flip ) ;
125+ expect ( foreign . _tag ) . toBe ( "PreviewMcpInvalidCursorError" ) ;
126+ } ) ,
127+ ) ;
128+
73129 it . effect ( "closes through manager events and clears the broker's current-tab lease" , ( ) =>
74130 Effect . scoped (
75131 Effect . gen ( function * ( ) {
@@ -81,34 +137,41 @@ it.layer(TestLayer)("PreviewMcpService", (it) => {
81137 const opened = yield * manager . open ( { threadId : currentThreadId } ) ;
82138 const events = yield * manager . subscribeEvents ;
83139 const requests : PreviewAutomationRequest [ ] = [ ] ;
140+ const connected = yield * Deferred . make < void > ( ) ;
141+ const targetedRequest = yield * Deferred . make < void > ( ) ;
142+ const releaseTargetedResponse = yield * Deferred . make < void > ( ) ;
84143 const hostEvents = yield * broker . connect ( { clientId : "preview-host" , environmentId } ) ;
85- const requestEvents = hostEvents . pipe (
86- Stream . filterMap ( ( event ) =>
87- event . type === "request"
88- ? Result . succeed ( { ...event . request , connectionId : event . connectionId } )
89- : Result . failVoid ,
90- ) ,
91- ) ;
92- yield * Stream . runForEach ( requestEvents , ( request ) => {
144+ yield * Stream . runForEach ( hostEvents , ( event ) => {
145+ if ( event . type === "connected" ) return Deferred . succeed ( connected , undefined ) ;
146+ const request = { ...event . request , connectionId : event . connectionId } ;
93147 requests . push ( request ) ;
94- return broker . respond ( {
95- clientId : "preview-host" ,
96- connectionId : request . connectionId ,
97- requestId : request . requestId ,
98- ok : true ,
99- result : {
100- available : true ,
101- visible : false ,
102- tabId : request . tabId ?? null ,
103- url : null ,
104- title : null ,
105- loading : false ,
106- } ,
107- } ) ;
148+ return Effect . gen ( function * ( ) {
149+ if ( request . tabId === opened . tabId ) {
150+ yield * Deferred . succeed ( targetedRequest , undefined ) ;
151+ yield * Deferred . await ( releaseTargetedResponse ) ;
152+ }
153+ yield * broker . respond ( {
154+ clientId : "preview-host" ,
155+ connectionId : request . connectionId ,
156+ requestId : request . requestId ,
157+ ok : true ,
158+ result : {
159+ available : true ,
160+ visible : false ,
161+ tabId : request . tabId ?? null ,
162+ url : null ,
163+ title : null ,
164+ loading : false ,
165+ } ,
166+ } ) ;
167+ } ) . pipe ( Effect . forkScoped , Effect . asVoid ) ;
108168 } ) . pipe ( Effect . forkScoped ) ;
109- yield * Effect . yieldNow ;
169+ yield * Deferred . await ( connected ) ;
110170
111- yield * broker . invoke ( { scope, operation : "status" , input : { } , tabId : opened . tabId } ) ;
171+ const delayedStatus = yield * broker
172+ . invoke ( { scope, operation : "status" , input : { } , tabId : opened . tabId } )
173+ . pipe ( Effect . forkScoped ) ;
174+ yield * Deferred . await ( targetedRequest ) ;
112175 expect ( requests . at ( - 1 ) ?. tabId ) . toBe ( opened . tabId ) ;
113176
114177 expect ( yield * service . close ( scope , { tabId : opened . tabId } ) ) . toEqual ( {
@@ -122,6 +185,9 @@ it.layer(TestLayer)("PreviewMcpService", (it) => {
122185 tabId : opened . tabId ,
123186 } ) ;
124187
188+ yield * Deferred . succeed ( releaseTargetedResponse , undefined ) ;
189+ yield * Fiber . join ( delayedStatus ) ;
190+
125191 yield * broker . invoke ( { scope, operation : "status" , input : { } } ) ;
126192 expect ( requests . at ( - 1 ) ?. tabId ) . toBeUndefined ( ) ;
127193 const repeated = yield * service . close ( scope , { tabId : opened . tabId } ) . pipe ( Effect . flip ) ;
@@ -154,3 +220,44 @@ it.layer(TestLayer)("PreviewMcpService", (it) => {
154220 } ) ,
155221 ) ;
156222} ) ;
223+
224+ it . effect ( "finishes broker cleanup when close is interrupted after manager removal" , ( ) =>
225+ Effect . scoped (
226+ Effect . gen ( function * ( ) {
227+ const cleanupEntered = yield * Deferred . make < void > ( ) ;
228+ const releaseCleanup = yield * Deferred . make < void > ( ) ;
229+ const cleanupCompleted = yield * Ref . make ( false ) ;
230+ const manager = yield * PreviewManager . make ;
231+ const broker = PreviewAutomationBroker . PreviewAutomationBroker . of ( {
232+ connect : ( ) => Effect . die ( "unused" ) ,
233+ focusHost : ( ) => Effect . die ( "unused" ) ,
234+ respond : ( ) => Effect . die ( "unused" ) ,
235+ invoke : ( ) => Effect . die ( "unused" ) ,
236+ forgetClosedTab : ( ) =>
237+ Deferred . succeed ( cleanupEntered , undefined ) . pipe (
238+ Effect . andThen ( Deferred . await ( releaseCleanup ) ) ,
239+ Effect . andThen ( Ref . set ( cleanupCompleted , true ) ) ,
240+ ) ,
241+ } ) ;
242+ const service = yield * PreviewMcpService . make . pipe (
243+ Effect . provideService ( PreviewManager . PreviewManager , manager ) ,
244+ Effect . provideService ( PreviewAutomationBroker . PreviewAutomationBroker , broker ) ,
245+ ) ;
246+ const threadId = ThreadId . make ( "thread-preview-interrupted-close" ) ;
247+ const scope = scopeFor ( threadId ) ;
248+ const opened = yield * manager . open ( { threadId } ) ;
249+ const closeFiber = yield * service
250+ . close ( scope , { tabId : opened . tabId } )
251+ . pipe ( Effect . forkScoped ) ;
252+ yield * Deferred . await ( cleanupEntered ) ;
253+ expect ( ( yield * manager . list ( { threadId } ) ) . sessions ) . toHaveLength ( 0 ) ;
254+
255+ const interruption = yield * Fiber . interrupt ( closeFiber ) . pipe ( Effect . forkScoped ) ;
256+ yield * Deferred . succeed ( releaseCleanup , undefined ) ;
257+ yield * Fiber . join ( interruption ) ;
258+ expect ( yield * Ref . get ( cleanupCompleted ) ) . toBe ( true ) ;
259+ const repeated = yield * service . close ( scope , { tabId : opened . tabId } ) . pipe ( Effect . flip ) ;
260+ expect ( repeated . _tag ) . toBe ( "PreviewSessionLookupError" ) ;
261+ } ) ,
262+ ) ,
263+ ) ;
0 commit comments