@@ -2,7 +2,7 @@ import { ExternalLinkIcon, PaperclipIcon } from "lucide-react";
22import { markdownImageSourceFragment } from "@t3tools/client-runtime/markdown-images" ;
33import { githubMediaFetchUrl } from "@t3tools/shared/githubMedia" ;
44import type { AssetResource , EnvironmentId , ScopedThreadRef } from "@t3tools/contracts" ;
5- import { createContext , useContext , useMemo } from "react" ;
5+ import { createContext , useContext } from "react" ;
66import type { Options as ReactMarkdownOptions } from "react-markdown" ;
77
88import { useAssetUrlRefresh , useAssetUrlState } from "~/assets/assetUrls" ;
@@ -18,6 +18,13 @@ export const PullRequestMarkdownContext = createContext<{
1818 threadRef : ScopedThreadRef | null ;
1919} | null > ( null ) ;
2020
21+ // Both asset hooks key on the resource's identity; the compiler cannot cache a value
22+ // across successive hook calls in the component itself.
23+ function useGitHubMediaResource ( cwd : string , fetchUrl : string ) : AssetResource {
24+ "use memo" ;
25+ return { _tag : "github-media" , cwd, url : fetchUrl } ;
26+ }
27+
2128function PullRequestGitHubVideo ( {
2229 environmentId,
2330 cwd,
@@ -29,10 +36,7 @@ function PullRequestGitHubVideo({
2936 url : string ;
3037 fetchUrl : string ;
3138} ) {
32- const resource = useMemo < AssetResource > (
33- ( ) => ( { _tag : "github-media" , cwd, url : fetchUrl } ) ,
34- [ cwd , fetchUrl ] ,
35- ) ;
39+ const resource = useGitHubMediaResource ( cwd , fetchUrl ) ;
3640 const assetUrl = useAssetUrlState ( environmentId , resource ) ;
3741 const refreshAssetUrl = useAssetUrlRefresh ( environmentId , resource ) ;
3842 const src =
@@ -66,10 +70,9 @@ export function PullRequestMarkdown({
6670 const context = useContext ( PullRequestMarkdownContext ) ;
6771 const repositoryUrl = context ?. repositoryUrl ;
6872 const resolvedThreadRef = threadRef ?? context ?. threadRef ?? undefined ;
69- const extraRemarkPlugins = useMemo < NonNullable < ReactMarkdownOptions [ "remarkPlugins" ] > > (
70- ( ) => ( repositoryUrl ? [ [ remarkPullRequestAutolinks , { repositoryUrl } ] ] : [ ] ) ,
71- [ repositoryUrl ] ,
72- ) ;
73+ const extraRemarkPlugins : NonNullable < ReactMarkdownOptions [ "remarkPlugins" ] > = repositoryUrl
74+ ? [ [ remarkPullRequestAutolinks , { repositoryUrl } ] ]
75+ : [ ] ;
7376 return (
7477 < div
7578 className = { cn (
0 commit comments