@@ -196,13 +196,14 @@ function makeRegistry(
196196 refresh : ( ) => Ref . get ( providersRef ) ,
197197 refreshInstance : ( ) => Ref . get ( providersRef ) ,
198198 refreshAfterUpdate : ( ) => {
199- if ( options ?. installedVersionAfterUpdate === undefined ) {
199+ const version = options ?. installedVersionAfterUpdate ;
200+ if ( version === undefined ) {
200201 return Ref . get ( providersRef ) ;
201202 }
202203 return Ref . updateAndGet ( providersRef , ( providers ) =>
203204 providers . map ( ( provider ) => ( {
204205 ...provider ,
205- version : options . installedVersionAfterUpdate ,
206+ version,
206207 } ) ) ,
207208 ) ;
208209 } ,
@@ -260,7 +261,7 @@ function layerFailingLatestLookupAfterFirst() {
260261 Effect . gen ( function * ( ) {
261262 lookups += 1 ;
262263 if ( lookups > 1 ) {
263- return yield * Effect . fail ( new Error ( "latest lookup failed" ) ) ;
264+ return yield * Effect . die ( "latest lookup failed" ) ;
264265 }
265266 return yield * lookup ;
266267 } ) ,
@@ -307,7 +308,19 @@ describe("providerMaintenanceRunner", () => {
307308 ) ;
308309 } ) ;
309310
310- it . effect ( "skips the installer when a fresh probe already matches latest" , ( ) => {
311+ it . effect . each ( [
312+ { name : "current" , probe : { } , skip : true } ,
313+ { name : "failed" , probe : { status : "error" } , skip : false } ,
314+ { name : "behind" , probe : { version : "2.1.309" } , skip : false } ,
315+ { name : "unknown" , probe : { version : null } , skip : false } ,
316+ {
317+ name : "installed current" ,
318+ probe : { version : "2.1.309" , installedVersion : "2.1.310" } ,
319+ skip : true ,
320+ } ,
321+ { name : "installed behind" , probe : { installedVersion : "2.1.309" } , skip : false } ,
322+ { name : "installed unknown" , probe : { installedVersion : null } , skip : false } ,
323+ ] as const ) ( "only skips a successful fresh current probe: $name" , ( { probe, skip } ) => {
311324 const calls : Array < { command : string ; args : ReadonlyArray < string > } > = [ ] ;
312325 const refreshedInstanceIds : Array < ProviderInstanceId > = [ ] ;
313326 return Effect . gen ( function * ( ) {
@@ -334,6 +347,7 @@ describe("providerMaintenanceRunner", () => {
334347 ? {
335348 ...provider ,
336349 version : "2.1.310" ,
350+ ...probe ,
337351 checkedAt : "2026-04-10T00:00:01.000Z" ,
338352 }
339353 : provider ,
@@ -354,7 +368,8 @@ describe("providerMaintenanceRunner", () => {
354368
355369 const result = yield * updater . updateProvider ( CODEX_DRIVER ) ;
356370 assert . deepStrictEqual ( refreshedInstanceIds , [ CODEX_INSTANCE_ID ] ) ;
357- assert . deepStrictEqual ( calls , [ ] ) ;
371+ assert . deepStrictEqual ( calls , skip ? [ ] : [ { command : "claude" , args : [ "update" ] } ] ) ;
372+ if ( ! skip ) return ;
358373 assert . strictEqual ( result . providers [ 0 ] ?. updateState ?. status , "succeeded" ) ;
359374 assert . strictEqual ( result . providers [ 0 ] ?. updateState ?. message , "Already up to date." ) ;
360375 assert . deepStrictEqual (
@@ -476,89 +491,6 @@ describe("providerMaintenanceRunner", () => {
476491 ) ;
477492 } ) ;
478493
479- it . effect ( "still runs the installer when the installed version is unknown" , ( ) => {
480- const calls : Array < { command : string ; args : ReadonlyArray < string > } > = [ ] ;
481- return Effect . gen ( function * ( ) {
482- const { registry, providersRef } = yield * makeRegistry ( {
483- ...baseProvider ,
484- version : null ,
485- } ) ;
486- const updater = yield * makeTestRunner ( {
487- ...registry ,
488- refreshInstance : ( ) =>
489- Ref . updateAndGet ( providersRef , ( providers ) =>
490- providers . map ( ( provider ) => ( {
491- ...provider ,
492- checkedAt : "2026-04-10T00:00:01.000Z" ,
493- } ) ) ,
494- ) ,
495- getProviderMaintenanceCapabilitiesForInstance : ( ) =>
496- Effect . succeed (
497- makeProviderMaintenanceCapabilities ( {
498- provider : CODEX_DRIVER ,
499- packageName : "@anthropic-ai/claude-code" ,
500- updateExecutable : "claude" ,
501- updateArgs : [ "update" ] ,
502- updateLockKey : "claudeAgent-native" ,
503- } ) ,
504- ) ,
505- } ) ;
506-
507- const result = yield * updater . updateProvider ( CODEX_DRIVER ) ;
508- assert . deepStrictEqual ( calls , [ { command : "claude" , args : [ "update" ] } ] ) ;
509- assert . strictEqual ( result . providers [ 0 ] ?. updateState ?. status , "succeeded" ) ;
510- } ) . pipe (
511- Effect . provide (
512- Layer . mergeAll (
513- layerNonWindowsPlatform ,
514- layerLatestVersionHttpClient ( "2.1.310" ) ,
515- layerMockSpawner ( ( command , args ) => {
516- calls . push ( { command, args } ) ;
517- return { stdout : "updated" } ;
518- } ) ,
519- ) ,
520- ) ,
521- ) ;
522- } ) ;
523-
524- it . effect ( "still runs the installer when the fresh probe is behind latest" , ( ) => {
525- const calls : Array < { command : string ; args : ReadonlyArray < string > } > = [ ] ;
526- return Effect . gen ( function * ( ) {
527- const { registry } = yield * makeRegistry ( {
528- ...baseProvider ,
529- version : "2.1.309" ,
530- } ) ;
531- const updater = yield * makeTestRunner ( {
532- ...registry ,
533- getProviderMaintenanceCapabilitiesForInstance : ( ) =>
534- Effect . succeed (
535- makeProviderMaintenanceCapabilities ( {
536- provider : CODEX_DRIVER ,
537- packageName : "@anthropic-ai/claude-code" ,
538- updateExecutable : "claude" ,
539- updateArgs : [ "update" ] ,
540- updateLockKey : "claudeAgent-native" ,
541- } ) ,
542- ) ,
543- } ) ;
544-
545- const result = yield * updater . updateProvider ( CODEX_DRIVER ) ;
546- assert . deepStrictEqual ( calls , [ { command : "claude" , args : [ "update" ] } ] ) ;
547- assert . strictEqual ( result . providers [ 0 ] ?. updateState ?. status , "unchanged" ) ;
548- } ) . pipe (
549- Effect . provide (
550- Layer . mergeAll (
551- layerNonWindowsPlatform ,
552- layerLatestVersionHttpClient ( "2.1.310" ) ,
553- layerMockSpawner ( ( command , args ) => {
554- calls . push ( { command, args } ) ;
555- return { stdout : "updated" } ;
556- } ) ,
557- ) ,
558- ) ,
559- ) ;
560- } ) ;
561-
562494 it . effect (
563495 "keeps a successful update when the binary is present but its version is unreadable" ,
564496 ( ) => {
@@ -1013,6 +945,10 @@ it.effect.each([
1013945 const updater = yield * makeTestRunner (
1014946 {
1015947 ...registry ,
948+ refreshInstance : ( ) =>
949+ Ref . updateAndGet ( providersRef , ( providers ) =>
950+ providers . map ( ( provider ) => ( { ...provider , checkedAt : "2026-04-10T00:00:01.000Z" } ) ) ,
951+ ) ,
1016952 getProviderMaintenanceCapabilitiesForInstance : ( ) => Effect . succeed ( pinnedCapabilities ) ,
1017953 refreshAfterUpdate : ( ) =>
1018954 Effect . gen ( function * ( ) {
0 commit comments