Skip to content

Commit 3051b32

Browse files
fix: chat file links open the file agents cite (#33943)
Co-authored-by: Claude Opus 5.5 <[email protected]>
1 parent 1fed70c commit 3051b32

23 files changed

Lines changed: 395 additions & 80 deletions

File tree

‎apps/mobile/src/features/threads/ThreadFeed.tsx‎

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -236,8 +236,9 @@ import { readEnvironmentScope, usePreparedConnection } from "../../state/session
236236
import { projectEnvironment } from "../../state/projects";
237237
import {
238238
needsWorkspaceBasenameLookup,
239-
pickWorkspaceBasenameMatch,
239+
pickWorkspaceLinkMatch,
240240
WORKSPACE_BASENAME_LOOKUP_LIMIT,
241+
workspaceLinkLookupQuery,
241242
} from "@t3tools/client-runtime/workspace-basename-lookup";
242243
import {
243244
resolveThreadLink,
@@ -2894,17 +2895,18 @@ export const ThreadFeed = memo(function ThreadFeed(props: ThreadFeedProps) {
28942895
props.workspaceRoot &&
28952896
relativePath &&
28962897
!/[\\/]$/.test(presentation.path) &&
2897-
needsWorkspaceBasenameLookup(relativePath) &&
2898+
workspaceLinkLookupQuery(presentation.path, props.workspaceRoot) !== null &&
28982899
readEnvironmentScope(props.environmentId, AuthFilesystemReadScope)
28992900
) {
2901+
const workspaceRoot = props.workspaceRoot;
29002902
const originalPath = resolveWorkspaceFilePath(props.workspaceRoot, relativePath);
29012903
void executeAtomQuery(
29022904
appAtomRegistry,
29032905
projectEnvironment.searchEntries({
29042906
environmentId: props.environmentId,
29052907
input: {
2906-
cwd: props.workspaceRoot,
2907-
query: relativePath,
2908+
cwd: workspaceRoot,
2909+
query: workspaceLinkLookupQuery(relativePath, workspaceRoot) ?? relativePath,
29082910
kind: "file",
29092911
limit: WORKSPACE_BASENAME_LOOKUP_LIMIT,
29102912
},
@@ -2914,7 +2916,7 @@ export const ThreadFeed = memo(function ThreadFeed(props: ThreadFeedProps) {
29142916
(result) => {
29152917
const match =
29162918
result._tag === "Success"
2917-
? pickWorkspaceBasenameMatch(relativePath, result.value.entries)
2919+
? pickWorkspaceLinkMatch(relativePath, workspaceRoot, result.value.entries)
29182920
: null;
29192921
if (!match || match === relativePath) {
29202922
openAt(relativePath);
@@ -2931,7 +2933,10 @@ export const ThreadFeed = memo(function ThreadFeed(props: ThreadFeedProps) {
29312933
).then(
29322934
(metadata) =>
29332935
openAt(
2934-
metadata._tag === "Success" && metadata.value?.kind !== "directory"
2936+
metadata._tag === "Success" &&
2937+
(needsWorkspaceBasenameLookup(relativePath)
2938+
? metadata.value?.kind !== "directory"
2939+
: metadata.value === null)
29352940
? match
29362941
: relativePath,
29372942
),

‎apps/server/src/orchestration-v2/testkit/fixtures/kiro_model_switch/kiro_transcript.ndjson‎

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

‎apps/server/src/orchestration-v2/testkit/fixtures/kiro_unknown_model/kiro_transcript.ndjson‎

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

‎apps/server/src/orchestration-v2/testkit/fixtures/multi_turn/muse_transcript.ndjson‎

Lines changed: 6 additions & 6 deletions
Large diffs are not rendered by default.

‎apps/server/src/orchestration-v2/testkit/fixtures/muse_permission/muse_transcript.ndjson‎

Lines changed: 6 additions & 6 deletions
Large diffs are not rendered by default.

‎apps/server/src/orchestration-v2/testkit/fixtures/muse_subagent_approval/muse_transcript.ndjson‎

Lines changed: 3 additions & 3 deletions
Large diffs are not rendered by default.

‎apps/server/src/orchestration-v2/testkit/fixtures/muse_subagent_interrupt/muse_transcript.ndjson‎

Lines changed: 3 additions & 3 deletions
Large diffs are not rendered by default.

‎apps/server/src/orchestration-v2/testkit/fixtures/muse_workflow/muse_transcript.ndjson‎

Lines changed: 3 additions & 3 deletions
Large diffs are not rendered by default.

‎apps/server/src/orchestration-v2/testkit/fixtures/simple/muse_transcript.ndjson‎

Lines changed: 3 additions & 3 deletions
Large diffs are not rendered by default.

‎apps/server/src/orchestration-v2/testkit/fixtures/subagent_v2/muse_transcript.ndjson‎

Lines changed: 3 additions & 3 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)