You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 2fda067
Browse filesBrowse the repository at this point in the historyBrowse files
# The build ran for many minutes. If the PR closed or lost the label
161
+
# meanwhile, cleanup already ran in its own concurrency group, so
162
+
# publishing now would resurrect a deleted download.
163
+
if ! preview_eligible; then
164
+
echo "PR closed or preview label removed while building. Skipping publish."
165
+
exit 0
166
+
fi
167
+
168
+
dmg_path="$(find release -type f -name '*.dmg' -print -quit)"
169
+
if [[ -z "$dmg_path" ]]; then
170
+
echo "No DMG found in the downloaded artifact." >&2
171
+
exit 1
172
+
fi
173
+
174
+
# The filename comes out of the build, which runs PR code. Requiring
175
+
# this PR's marker keeps a build from clobbering or deleting another
176
+
# PR's asset, since those names carry a different -pr.N. marker.
177
+
if [[ "$(basename "$dmg_path")" != *"-pr.${PR_NUMBER}."* ]]; then
178
+
echo "DMG name '$(basename "$dmg_path")' does not carry this PR's -pr.${PR_NUMBER}. marker. Refusing to publish." >&2
179
+
exit 1
180
+
fi
181
+
182
+
if ! gh release view "$tag" --repo "$GITHUB_REPOSITORY" >/dev/null 2>&1; then
183
+
# "|| true" tolerates a concurrent publish job creating the
184
+
# release between the check and the create.
185
+
gh release create "$tag" \
186
+
--repo "$GITHUB_REPOSITORY" \
187
+
--target "$DEFAULT_BRANCH" \
188
+
--prerelease \
189
+
--title "Desktop preview builds" \
190
+
--notes "Rolling unsigned desktop builds from pull requests with a preview label. Each download is removed when its pull request closes or loses the label. Install stable builds from the latest release instead." \
191
+
|| true
192
+
fi
193
+
194
+
# Keep one DMG per PR: drop this PR's older builds first. The
195
+
# trailing dot keeps -pr.12. from matching -pr.123. builds.
Copy file name to clipboardExpand all lines: .macroscope/check-run-agents/ui-consistency.md
+7Lines changed: 7 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -70,6 +70,13 @@ The goal is not to minimize CSS or class counts at any cost. The goal is to put
70
70
- Do not treat a screenshot as proof of keyboard, overflow, scrollbar, responsive, or runtime-theme behavior. Pair visual evidence with source, computed-style, emitted-CSS, or interaction checks as appropriate.
71
71
- Be alert to shared primitive color indirection. When a primitive routes icon color through a CSS variable, ensure migrated contextual icons retain their intended tone, including pressed and disabled states.
72
72
73
+
## Environment routing in shared renderers
74
+
75
+
- A shared renderer that performs an environment-scoped action — a server RPC such as opening or revealing a file, an environment-gated capability check, or an OS-derived label — must resolve its target environment from explicit scope: the bound thread's `environmentId`, or an `environmentId` prop threaded from the owning surface. Never let it silently fall back to the globally active environment. Multi-environment surfaces (pull request panels, review annotations, cross-environment listings) can render content from environment B while environment A is active; a silent fallback sends B's paths to A's server and presents A's platform wording.
76
+
- When a call site cannot supply an explicit environment scope, suppress the environment-scoped actions at that call site rather than guessing. A hidden menu item is correct; an item that targets the wrong server is a concrete finding.
77
+
- Capability gating, action dispatch, and user-facing labels must all read from the same environment's server config that the action will execute against. Flag a renderer whose label derives from one environment while its RPC targets another.
78
+
- Flag new call sites of shared markdown, chip, or menu renderers that trigger environment actions without passing explicit scope, and flag new environment-action props whose default reintroduces an active-environment fallback.
79
+
73
80
## Change discipline
74
81
75
82
- Review the pull request's changed scope and directly affected consumers. Do not turn a focused PR into a demand for unrelated legacy cleanup.
0 commit comments