@@ -176,6 +176,53 @@ function makeProjection(visibleTurnItems: OrchestrationV2ProjectedTurnItem[]) {
176176}
177177
178178describe ( "threadHistoryPaging" , ( ) => {
179+ it ( "bounds a single human turn and pages every item exactly once" , ( ) => {
180+ const items = Array . from ( { length : 180 } , ( _ , index ) => makeRow ( index ) ) ;
181+ items [ 0 ] = {
182+ ...items [ 0 ] ! ,
183+ item : {
184+ ...items [ 0 ] ! . item ,
185+ type : "user_message" ,
186+ createdBy : "user" ,
187+ creationSource : "web" ,
188+ inputIntent : "turn_start" ,
189+ messageId : MessageId . make ( "long-human-turn" ) ,
190+ text : "Continue" ,
191+ attachments : [ ] ,
192+ } ,
193+ } as OrchestrationV2ProjectedTurnItem ;
194+ const recent = selectRecentTimelineWindow ( { items, snapshotSequence : 1 } ) ;
195+ expect ( recent . items ) . toHaveLength ( THREAD_HISTORY_PAGE_POLICY . maxItems ) ;
196+ const loaded = [ ...recent . items ] ;
197+ let cursor = recent . nextCursor ;
198+ for ( let pages = 0 ; cursor !== null ; pages += 1 ) {
199+ expect ( pages ) . toBeLessThan ( items . length ) ;
200+ const page = selectHistoryPageFromCursor ( { items, cursor, snapshotSequence : 1 } ) ;
201+ expect ( page . items . length ) . toBeGreaterThan ( 0 ) ;
202+ expect ( page . items . length ) . toBeLessThanOrEqual ( THREAD_HISTORY_PAGE_POLICY . maxItems ) ;
203+ loaded . unshift ( ...page . items ) ;
204+ cursor = page . nextCursor ;
205+ }
206+ expect ( loaded . map ( ( row ) => row . sourceItemId ) ) . toEqual ( items . map ( ( row ) => row . sourceItemId ) ) ;
207+
208+ const large = items
209+ . slice ( 0 , 12 )
210+ . map ( ( row ) =>
211+ row . item . type === "command_execution"
212+ ? { ...row , item : { ...row . item , output : "x" . repeat ( 200_000 ) } }
213+ : row ,
214+ ) ;
215+ const bounded = buildBoundedThreadProjection ( {
216+ projection : makeProjection ( large ) ,
217+ snapshotSequence : 1 ,
218+ } ) ;
219+ expect ( bounded . projection . visibleTurnItems . length ) . toBeLessThan ( large . length ) ;
220+ expect ( bounded . payloadBudgetExceeded ) . toBe ( false ) ;
221+ expect ( boundedTimelineEncodedBytes ( bounded . projection ) ) . toBeLessThanOrEqual (
222+ THREAD_HISTORY_PAGE_POLICY . maxEncodedBytes ,
223+ ) ;
224+ } ) ;
225+
179226 it ( "keeps background turns with user turns, with main's 150-turn fan-out ceiling" , ( ) => {
180227 const items = Array . from ( { length : 161 } , ( _ , turn ) => {
181228 const row = makeRow ( turn * 2 ) ;
@@ -195,13 +242,15 @@ describe("threadHistoryPaging", () => {
195242 } ;
196243 return [ prompt , makeRow ( turn * 2 + 1 ) ] ;
197244 } ) . flat ( ) ;
198- const first = selectRecentTimelineWindow ( { items, snapshotSequence : 1 } ) ;
245+ const policy = { ...THREAD_HISTORY_PAGE_POLICY , maxItems : 1_000 , maxEncodedBytes : 10_000_000 } ;
246+ const first = selectRecentTimelineWindow ( { items, snapshotSequence : 1 , policy } ) ;
199247 expect ( first . items ) . toHaveLength ( 300 ) ;
200248 expect ( first . items [ 0 ] ?. sourceItemId ) . toBe ( "item-22" ) ;
201249 const older = selectHistoryPageFromCursor ( {
202250 items,
203251 cursor : first . nextCursor ! ,
204252 snapshotSequence : 1 ,
253+ policy,
205254 } ) ;
206255 expect ( older . items ) . toHaveLength ( 22 ) ;
207256 expect ( older . hasMoreHistory ) . toBe ( false ) ;
@@ -244,13 +293,15 @@ describe("threadHistoryPaging", () => {
244293 inRun ( run * 4 + 2 , run , notification ( `Steer ${ run } ` ) ) ,
245294 inRun ( run * 4 + 3 , run ) ,
246295 ] ) . flat ( ) ;
247- const first = selectRecentTimelineWindow ( { items, snapshotSequence : 1 } ) ;
296+ const policy = { ...THREAD_HISTORY_PAGE_POLICY , maxItems : 1_000 , maxEncodedBytes : 10_000_000 } ;
297+ const first = selectRecentTimelineWindow ( { items, snapshotSequence : 1 , policy } ) ;
248298 expect ( first . items ) . toHaveLength ( 150 * 4 - 1 ) ;
249299 expect ( first . items [ 0 ] ?. sourceItemId ) . toBe ( `item-${ 11 * 4 + 1 } ` ) ;
250300 const older = selectHistoryPageFromCursor ( {
251301 items,
252302 cursor : first . nextCursor ! ,
253303 snapshotSequence : 1 ,
304+ policy,
254305 } ) ;
255306 expect ( [ ...older . items , ...first . items ] . map ( ( row ) => row . sourceItemId ) ) . toEqual (
256307 items . map ( ( row ) => row . sourceItemId ) ,
@@ -288,26 +339,46 @@ describe("threadHistoryPaging", () => {
288339 } ) ;
289340
290341 it ( "always includes at least one pathological oversized item" , ( ) => {
291- const items = [ makeRow ( 0 , { outputBytes : 2_000_000 } ) , makeRow ( 1 , { outputBytes : 10 } ) ] ;
292- const page = selectRecentTimelineWindow ( {
293- items,
294- snapshotSequence : 1 ,
295- policy : { maxItems : 50 , maxEncodedBytes : 1_024 } ,
296- } ) ;
297- expect ( page . items ) . toHaveLength ( 1 ) ;
298- expect ( page . items [ 0 ] ?. sourceItemId ) . toBe ( "item-1" ) ;
299- expect ( page . hasMoreHistory ) . toBe ( true ) ;
300-
301- const older = selectHistoryPageFromCursor ( {
302- items,
303- cursor : page . nextCursor ! ,
304- snapshotSequence : 1 ,
305- policy : { maxItems : 50 , maxEncodedBytes : 1_024 } ,
306- } ) ;
307- expect ( older . items ) . toHaveLength ( 1 ) ;
308- expect ( older . items [ 0 ] ?. sourceItemId ) . toBe ( "item-0" ) ;
309- expect ( older . hasMoreHistory ) . toBe ( false ) ;
310- expect ( older . nextCursor ) . toBeNull ( ) ;
342+ for ( const humanTurn of [ false , true ] ) {
343+ const oversized = makeRow ( 0 , { outputBytes : 2_000_000 } ) ;
344+ const items = [
345+ humanTurn
346+ ? ( {
347+ ...oversized ,
348+ item : {
349+ ...oversized . item ,
350+ type : "user_message" ,
351+ createdBy : "user" ,
352+ creationSource : "web" ,
353+ inputIntent : "turn_start" ,
354+ messageId : MessageId . make ( "oversized-human-turn" ) ,
355+ text : "x" . repeat ( 2_000_000 ) ,
356+ attachments : [ ] ,
357+ } ,
358+ } as OrchestrationV2ProjectedTurnItem )
359+ : oversized ,
360+ makeRow ( 1 , { outputBytes : 10 } ) ,
361+ ] ;
362+ const policy = { ...THREAD_HISTORY_PAGE_POLICY , maxItems : 50 , maxEncodedBytes : 1_024 } ;
363+ const page = selectRecentTimelineWindow ( { items, snapshotSequence : 1 , policy } ) ;
364+ expect ( page . items ) . toHaveLength ( 1 ) ;
365+ expect ( page . items [ 0 ] ?. sourceItemId ) . toBe ( "item-1" ) ;
366+ expect ( page . hasMoreHistory ) . toBe ( true ) ;
367+
368+ const older = selectHistoryPageFromCursor ( {
369+ items,
370+ cursor : page . nextCursor ! ,
371+ snapshotSequence : 1 ,
372+ policy,
373+ } ) ;
374+ expect ( older . items ) . toHaveLength ( 1 ) ;
375+ expect ( older . items [ 0 ] ?. sourceItemId ) . toBe ( "item-0" ) ;
376+ expect ( older . hasMoreHistory ) . toBe ( false ) ;
377+ expect ( older . nextCursor ) . toBeNull ( ) ;
378+ expect ( [ ...older . items , ...page . items ] . map ( ( row ) => row . sourceItemId ) ) . toEqual (
379+ items . map ( ( row ) => row . sourceItemId ) ,
380+ ) ;
381+ }
311382 } ) ;
312383
313384 it ( "recovers identity-miss cursors when position is past a shrunken timeline" , ( ) => {
0 commit comments