Skip to content

Commit 2cdeee0

Browse files
committed
fix(web): the branch picker opens its pull request rows again and the settings search sits in a search landmark
1 parent 6b528e6 commit 2cdeee0

2 files changed

Lines changed: 4 additions & 1 deletion

File tree

‎apps/web/src/components/BranchToolbarBranchSelector.tsx‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ import {
3232
import { useComposerDraftStore, type DraftId } from "../composerDraftStore";
3333
import { writeTextToClipboard } from "../hooks/useCopyToClipboard";
3434
import { readLocalApi } from "../localApi";
35+
import { useOpenPrLink } from "../lib/openPullRequestLink";
3536
import { usePaginatedBranches } from "../state/queries";
3637
import { readThreadShell, useProject, useQuietThreadShell } from "../state/entities";
3738
import { useEnvironmentQuery } from "../state/query";
@@ -712,6 +713,7 @@ export function BranchToolbarBranchSelector({
712713
threadBranch: branchPrBranch,
713714
gitStatus: branchStatusQuery.data,
714715
});
716+
const openPrLink = useOpenPrLink(threadRef);
715717

716718
function selectPickerItem(itemValue: string) {
717719
if (isInitialBranchesLoadPending || isBranchActionPending) return;

‎apps/web/src/components/settings/SettingsSidebarNav.tsx‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,8 @@ export function SettingsSidebarNav({ pathname }: { pathname: string }) {
260260
<div className={cn("px-3 pt-3 pb-3.5", !compactSearchOpen && "max-md:hidden")}>
261261
{/* Pen EV7oi: a search field with a trailing slash hint. */}
262262
<div className={compactSearchOpen ? undefined : "max-md:hidden"}>
263-
<InputGroup>
263+
{/* A search landmark, so the nav holds no group without a heading. */}
264+
<InputGroup role="search">
264265
<InputGroupAddon>
265266
<SearchIcon className="size-3.5" />
266267
</InputGroupAddon>

0 commit comments

Comments
 (0)