Skip to content

Commit 2a83da1

Browse files
refactor(web): give Spinner and RefreshIcon a size prop
Every consumer sized these glyphs through className (size-3, size-3.5, size-4, size-5). Expose that scale as size="xs|sm|md|lg", plus tone="muted" on Spinner, and migrate the 57 call sites. No default size, so glyphs inside a Button keep inheriting the button's svg sizing. Lowers the no-restyle ceiling from 1213 to 1206. Co-Authored-By: Claude Fable 5 <[email protected]>
1 parent c26119a commit 2a83da1

36 files changed

Lines changed: 101 additions & 59 deletions

‎apps/web/src/components/BranchToolbarBranchSelector.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -905,7 +905,7 @@ export function BranchToolbarBranchSelector({
905905
className="flex cursor-pointer items-center justify-between gap-3 border-t border-border/60 px-3 py-2 text-xs"
906906
>
907907
<span className="flex min-w-0 items-center gap-1.5 font-medium text-muted-foreground">
908-
<RefreshIcon aria-hidden="true" className="size-3 shrink-0 opacity-70" />
908+
<RefreshIcon aria-hidden="true" size="xs" className="shrink-0" />
909909
<span className="truncate">Start from origin</span>
910910
</span>
911911
<Switch

‎apps/web/src/components/DiffPanel.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -856,7 +856,7 @@ export default function DiffPanel({
856856
/>
857857
}
858858
>
859-
<RefreshIcon className="size-3.5" refreshing={isRefreshingDiff} />
859+
<RefreshIcon size="sm" refreshing={isRefreshingDiff} />
860860
</TooltipTrigger>
861861
<TooltipPopup side="top">
862862
{isRefreshingDiff ? "Refreshing diff…" : "Refresh diff"}

‎apps/web/src/components/GitActionsControl.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -851,7 +851,7 @@ function PublishRepositoryDialog(props: PublishRepositoryDialogProps) {
851851
aria-live="polite"
852852
className="flex items-center gap-2 rounded-md border border-input bg-muted/40 px-3 py-2 text-xs text-muted-foreground dark:border-transparent dark:bg-white/[0.035]"
853853
>
854-
<Spinner className="size-3.5" aria-hidden />
854+
<Spinner size="sm" aria-hidden />
855855
Publishing repository to {publishProviderLabel}...
856856
</div>
857857
) : null}
@@ -938,7 +938,7 @@ function PublishRepositoryDialog(props: PublishRepositoryDialogProps) {
938938
<Button disabled={!canSubmitPublishRepository} onClick={submitPublishRepository}>
939939
{publishRepositoryAction.isPending ? (
940940
<>
941-
<Spinner className="size-3.5" aria-hidden />
941+
<Spinner size="sm" aria-hidden />
942942
Publishing...
943943
</>
944944
) : (

‎apps/web/src/components/ProviderUpdateEnvironmentRows.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ function EnvironmentUpdateRow({
118118
let trailing: ReactNode;
119119
switch (status.kind) {
120120
case "loading":
121-
trailing = <Spinner className="size-4 text-muted-foreground" />;
121+
trailing = <Spinner size="md" tone="muted" />;
122122
break;
123123
case "success":
124124
trailing = <CheckIcon aria-hidden="true" className="size-4 text-success" />;

‎apps/web/src/components/PullRequestThreadDialog.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ export function PullRequestThreadDialog({
252252

253253
{isResolving ? (
254254
<div className="flex items-center gap-2 text-muted-foreground text-xs">
255-
<Spinner className="size-3.5" />
255+
<Spinner size="sm" />
256256
Resolving {terminology.singular}...
257257
</div>
258258
) : null}

‎apps/web/src/components/chat/ComposerPrimaryActions.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,7 @@ export const ComposerPrimaryActions = memo(function ComposerPrimaryActions({
254254
</span>
255255
) : null}
256256
{isConnecting || isSendBusy ? (
257-
<Spinner className="size-3.5" aria-hidden="true" />
257+
<Spinner size="sm" aria-hidden="true" />
258258
) : (
259259
<svg width="14" height="14" viewBox="0 0 14 14" fill="none" aria-hidden="true">
260260
<path

‎apps/web/src/components/chat/MessagesTimeline.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2567,7 +2567,7 @@ function BackgroundWorktreeSetupChip({ snapshot }: { snapshot: WorktreeSetupSnap
25672567
/>
25682568
}
25692569
>
2570-
<Spinner className="size-3 shrink-0" />
2570+
<Spinner size="xs" className="shrink-0" />
25712571
<span className="truncate">{scriptName}</span>
25722572
</PopoverTrigger>
25732573
<PopoverPopup

‎apps/web/src/components/chat/WorktreeSetupCard.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ function StageIcon({ status }: { status: WorktreeSetupStage["status"] }) {
6161
case "done":
6262
return <CheckIcon aria-hidden className={className} />;
6363
case "running":
64-
return <Spinner className={className} />;
64+
return <Spinner size="md" className="shrink-0" />;
6565
case "failed":
6666
return <XIcon aria-hidden className={className} />;
6767
case "warning":

‎apps/web/src/components/clerk/ClerkUserProfilePage.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ export function ClerkUserProfileRefreshButton({
5656
disabled={disabled || isPending}
5757
onClick={onClick}
5858
>
59-
<RefreshIcon aria-hidden="true" className="size-3.5" refreshing={isPending} />
59+
<RefreshIcon aria-hidden="true" size="sm" refreshing={isPending} />
6060
Refresh
6161
</Button>
6262
);

‎apps/web/src/components/device/DeviceLoadingView.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export function DeviceLoadingView(props: {
2727
) : null}
2828
</div>
2929
<div className="flex items-center gap-2 text-xs text-muted-foreground">
30-
{!props.error ? <Spinner className="size-3" /> : null}
30+
{!props.error ? <Spinner size="xs" /> : null}
3131
<span>{props.message}</span>
3232
</div>
3333
{props.children}

0 commit comments

Comments
 (0)