Skip to content

Commit 2a1caac

Browse files
nibarAhmednibarAhmedjuliusmarminge
authored
fix(web): NVDA browse mode reads the current thread's branch, not the previous one (#34446)
Co-authored-by: nibarAhmed <[email protected]> Co-authored-by: Julius Marminge <[email protected]>
1 parent f5ae808 commit 2a1caac

1 file changed

Lines changed: 8 additions & 1 deletion

File tree

‎apps/web/src/components/BranchToolbarBranchSelector.tsx‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -786,6 +786,8 @@ export function BranchToolbarBranchSelector({
786786
}
787787
className="min-w-0 max-w-full active:scale-100"
788788
disabled={isInitialBranchesLoadPending || isBranchActionPending}
789+
// NVDA browse mode re-reads a combobox when its attributes change, not when its text does.
790+
aria-label={`Branch: ${triggerLabel}`}
789791
>
790792
<GitBranchIcon
791793
className={cn(
@@ -794,7 +796,12 @@ export function BranchToolbarBranchSelector({
794796
)}
795797
/>
796798
<ComposerContextLabel displayMode={displayMode}>
797-
<MiddleTruncate value={triggerLabel} variant="cap-aligned" className="w-full" />
799+
<MiddleTruncate
800+
value={triggerLabel}
801+
variant="cap-aligned"
802+
className="w-full"
803+
aria-hidden
804+
/>
798805
</ComposerContextLabel>
799806
</ComboboxTrigger>
800807
</span>

0 commit comments

Comments
 (0)