Skip to content

Commit 2a0137b

Browse files
Dwiteclaude
andcommitted
fix(mobile): Android reply actions get 48dp touch targets
Copy and fork under an agent reply were fixed 28dp buttons on every platform, well under Android's 48dp minimum and hard to hit. On Android they now take their size from useAndroidControlSizing, like the app's other Android controls, so they hold 48dp and grow with the text size. iOS keeps the compact size. Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 37fbefd commit 2a0137b

1 file changed

Lines changed: 21 additions & 4 deletions

File tree

‎apps/mobile/src/features/threads/ThreadFeed.tsx‎

Lines changed: 21 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,7 @@ import { CopyTextButton } from "./CopyTextButton";
163163
import { getReviewSectionIdForCheckpoint } from "../review/reviewModel";
164164
import { setReviewSelectedSectionId } from "../review/reviewState";
165165
import { Menu } from "../../components/ui/Menu";
166+
import { useAndroidControlSizing } from "../../components/ui/useAndroidControlSizing";
166167
import { copyPromptLink } from "../prompt-links/prompt-link-actions";
167168
import { parseReviewCommentMessageSegments } from "../review/reviewCommentSelection";
168169
import {
@@ -414,6 +415,8 @@ function UserMessageCopyButton(props: {
414415
function AssistantForkButton(props: {
415416
readonly environmentId: EnvironmentId;
416417
readonly iconColor: ColorValue;
418+
readonly buttonSize: number;
419+
readonly iconSize: number;
417420
readonly projectedItem: OrchestrationV2ProjectedTurnItem;
418421
readonly sourceTitle: string;
419422
}) {
@@ -469,14 +472,15 @@ function AssistantForkButton(props: {
469472
})
470473
.finally(() => setBusy(false));
471474
}}
472-
className="h-7 w-7 items-center justify-center disabled:opacity-40"
475+
className="items-center justify-center disabled:opacity-40"
476+
style={{ width: props.buttonSize, height: props.buttonSize }}
473477
>
474478
{busy ? (
475479
<AppActivityIndicator size="small" />
476480
) : (
477481
<SymbolView
478482
name="arrow.triangle.branch"
479-
size={13}
483+
size={props.iconSize}
480484
tintColor={props.iconColor}
481485
type="monochrome"
482486
/>
@@ -1326,6 +1330,7 @@ function renderFeedEntry(
13261330
readonly renderViewedImage: MarkdownImageRenderer;
13271331
readonly renderReasoning: (text: string) => ReactNode;
13281332
readonly iconSubtleColor: string | import("react-native").ColorValue;
1333+
readonly replyActionSize: { readonly button: number; readonly icon: number };
13291334
readonly screenColor: string;
13301335
readonly userBubbleColor: string | import("react-native").ColorValue;
13311336
readonly markdownStyles: MarkdownStyleSets;
@@ -1846,13 +1851,15 @@ function renderFeedEntry(
18461851
accessibilityLabel="Copy message"
18471852
text={renderedText}
18481853
tintColor={iconSubtleColor}
1849-
buttonSize={28}
1850-
iconSize={13}
1854+
buttonSize={props.replyActionSize.button}
1855+
iconSize={props.replyActionSize.icon}
18511856
/>
18521857
{message.projectedItem ? (
18531858
<AssistantForkButton
18541859
environmentId={props.environmentId}
18551860
iconColor={iconSubtleColor}
1861+
buttonSize={props.replyActionSize.button}
1862+
iconSize={props.replyActionSize.icon}
18561863
projectedItem={message.projectedItem}
18571864
sourceTitle={props.threadTitle}
18581865
/>
@@ -2316,6 +2323,15 @@ export const ThreadFeed = memo(function ThreadFeed({
23162323

23172324
const theme = useUniwindTheme();
23182325
const iconSubtleColor = theme["--color-icon-subtle"];
2326+
const { buttonSize: androidButtonSize, smallIconSize: androidIconSize } =
2327+
useAndroidControlSizing();
2328+
const replyActionSize = useMemo(
2329+
() =>
2330+
Platform.OS === "android"
2331+
? { button: androidButtonSize, icon: androidIconSize }
2332+
: { button: 28, icon: 13 },
2333+
[androidButtonSize, androidIconSize],
2334+
);
23192335
const screenColor = theme["--color-screen"];
23202336
const userBubbleColor = theme["--color-user-bubble"];
23212337
const openSkillInstructions = (path: string) => {
@@ -3164,6 +3180,7 @@ export const ThreadFeed = memo(function ThreadFeed({
31643180
renderViewedImage,
31653181
renderReasoning,
31663182
iconSubtleColor,
3183+
replyActionSize,
31673184
screenColor,
31683185
userBubbleColor,
31693186
markdownStyles,

0 commit comments

Comments
 (0)