Skip to content

Commit 291b5f6

Browse files
only21milcodex
andcommitted
fix(web): use supported draft and deferred types
Co-Authored-By: GPT-6.1 Sol <[email protected]>
1 parent f6bbeda commit 291b5f6

2 files changed

Lines changed: 12 additions & 11 deletions

File tree

‎apps/web/src/components/settings/AcpSessionManagementSection.browser.test.tsx‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -190,11 +190,14 @@ it.each(["Save", "Disable"])("keeps other provider edits through a %s refetch",
190190
await userEvent.fill(input("other write-only headers JSON"), '{"X-Test":"unsaved"}');
191191
await userEvent.fill(input("google write-only headers JSON"), '{"X-Test":"saved"}');
192192

193-
const reload = Promise.withResolvers<typeof response>();
194-
commands.listProviders.mockReturnValueOnce(reload.promise);
193+
let resolveReload!: (value: typeof response) => void;
194+
const reload = new Promise<typeof response>((resolve) => {
195+
resolveReload = resolve;
196+
});
197+
commands.listProviders.mockReturnValueOnce(reload);
195198
await screen.click(action);
196199
await userEvent.fill(input("other base URL"), "https://newer.example.test/v1");
197-
await act(async () => reload.resolve(response));
200+
await act(async () => resolveReload(response));
198201

199202
expect(input("other base URL").value).toBe("https://newer.example.test/v1");
200203
expect(input("other write-only headers JSON").value).toBe('{"X-Test":"unsaved"}');

‎apps/web/src/components/settings/AcpSessionManagementSection.tsx‎

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -225,15 +225,13 @@ export function AcpSessionManagementSection(props: {
225225
Object.fromEntries(
226226
result.value.providers.map((provider) => [
227227
provider.providerId,
228-
resetProviderId !== undefined &&
229-
provider.providerId !== resetProviderId &&
230-
current[provider.providerId] !== undefined
228+
(resetProviderId !== undefined && provider.providerId !== resetProviderId
231229
? current[provider.providerId]
232-
: {
233-
apiType: provider.current?.apiType ?? provider.supported[0] ?? "",
234-
baseUrl: provider.current?.baseUrl ?? "",
235-
headers: "",
236-
},
230+
: undefined) ?? {
231+
apiType: provider.current?.apiType ?? provider.supported[0] ?? "",
232+
baseUrl: provider.current?.baseUrl ?? "",
233+
headers: "",
234+
},
237235
]),
238236
),
239237
);

0 commit comments

Comments
 (0)