Skip to content

Commit 28cddcd

Browse files
committed
feat(mobile): a New Voice Task shortcut starts a new task already dictating
Adds a second App Shortcut, New Voice Task, for the Action button, Siri, and Spotlight. It opens the same fresh no-project composer as New Task but starts dictation instead of raising the keyboard. Devices without on-device transcription get the keyboard. Dictation starts once per request, and only after the draft has switched to the requested project, so a temporary composer or a reopened draft never turns the microphone on.
1 parent 946eb8a commit 28cddcd

10 files changed

Lines changed: 107 additions & 11 deletions

File tree

‎apps/mobile/modules/t3-native-controls/ios/T3AppIntentsModule.swift‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import os
44
/// Holds the last App Intent until JS takes it; cold launches run the intent before JS listens.
55
public enum T3AppIntentInbox {
66
public static let newTask = "newTask"
7+
public static let voiceTask = "voiceTask"
78

89
static let didDeliver = Notification.Name("T3AppIntentInbox.didDeliver")
910
private static let pending = OSAllocatedUnfairLock<String?>(initialState: nil)

‎apps/mobile/plugins/ios/T3AppIntents.swift‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,17 @@ struct StartNewTaskIntent: AppIntent {
1414
}
1515
}
1616

17+
struct StartVoiceTaskIntent: AppIntent {
18+
static let title: LocalizedStringResource = "New Voice Task"
19+
static let openAppWhenRun = true
20+
21+
@MainActor
22+
func perform() async throws -> some IntentResult {
23+
T3AppIntentInbox.deliver(T3AppIntentInbox.voiceTask)
24+
return .result()
25+
}
26+
}
27+
1728
struct T3AppShortcuts: AppShortcutsProvider {
1829
static var appShortcuts: [AppShortcut] {
1930
AppShortcut(
@@ -25,5 +36,14 @@ struct T3AppShortcuts: AppShortcutsProvider {
2536
shortTitle: "New Task",
2637
systemImageName: "square.and.pencil"
2738
)
39+
AppShortcut(
40+
intent: StartVoiceTaskIntent(),
41+
phrases: [
42+
"Dictate a new task in \(.applicationName)",
43+
"New \(.applicationName) voice task",
44+
],
45+
shortTitle: "New Voice Task",
46+
systemImageName: "mic"
47+
)
2848
}
2949
}

‎apps/mobile/src/features/layout/AdaptiveWorkspaceLayout.tsx‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ import { HomeListOptionsProvider } from "../home/home-list-options";
7272
import { newTaskDestination } from "../threads/new-task-project-selection";
7373
import { requestNewTaskComposerFocus } from "../threads/new-task-composer-focus";
7474
import { useNewTaskAppIntent } from "../shortcuts/useAppIntents";
75+
import { getLocalVoiceTranscriber } from "../../native/voiceTranscription";
7576
import { usePendingTaskListActions } from "../home/usePendingTaskListActions";
7677
import { ThreadNavigationSidebar } from "../threads/ThreadNavigationSidebar";
7778
import { useOpenThreadPullRequests } from "../threads/use-open-thread-pull-requests";
@@ -552,9 +553,11 @@ function AdaptiveWorkspaceLayoutContent(
552553
return true;
553554
});
554555

555-
useNewTaskAppIntent(() => {
556+
useNewTaskAppIntent((intent) => {
556557
const requestId = uuidv4();
557-
requestNewTaskComposerFocus(requestId);
558+
// Devices without on-device transcription get the keyboard instead.
559+
const dictates = intent === "voiceTask" && getLocalVoiceTranscriber() !== null;
560+
requestNewTaskComposerFocus(requestId, dictates ? "dictation" : "keyboard");
558561
navigation.dispatch(
559562
StackActions.push("NewTaskProject", { startWithoutProject: true, requestId }),
560563
);

‎apps/mobile/src/features/shortcuts/useAppIntents.ts‎

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,14 @@ const AppIntents = requireOptionalNativeModule<{
99
addListener(event: "onIntent", listener: () => void): { remove(): void };
1010
}>("T3AppIntents");
1111

12-
/** Runs when the "New Task" App Shortcut fires from the Action button, Siri, or Spotlight. */
13-
export function useNewTaskAppIntent(onNewTask: () => void): void {
12+
export type NewTaskAppIntent = "newTask" | "voiceTask";
13+
14+
/** Runs when a new-task App Shortcut fires from the Action button, Siri, or Spotlight. */
15+
export function useNewTaskAppIntent(onNewTask: (intent: NewTaskAppIntent) => void): void {
1416
const handlePendingIntent = useEffectEvent(() => {
15-
if (AppIntents?.takePendingIntent() === "newTask") {
16-
onNewTask();
17+
const intent = AppIntents?.takePendingIntent();
18+
if (intent === "newTask" || intent === "voiceTask") {
19+
onNewTask(intent);
1720
}
1821
});
1922

‎apps/mobile/src/features/threads/NewTaskDraftRouteScreen.tsx‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,10 @@ import { NativeStackScreenOptions } from "../../native/StackHeader";
3535

3636
import { ThreadScreenFallback } from "./ThreadScreenHost";
3737
import { NewTaskDraftScreen } from "./NewTaskDraftScreen";
38-
import { isNewTaskComposerFocusRequested } from "./new-task-composer-focus";
38+
import {
39+
isNewTaskComposerFocusRequested,
40+
takeNewTaskDictationRequest,
41+
} from "./new-task-composer-focus";
3942

4043
import type { NewTaskDraftRouteParams } from "./thread-route-state";
4144
export type { NewTaskDraftRouteParams } from "./thread-route-state";
@@ -222,6 +225,7 @@ export function NewTaskDraftRouteScreen({ route }: StaticScreenProps<NewTaskDraf
222225
}
223226
draftId={draftId}
224227
autoFocusComposer={isNewTaskComposerFocusRequested(params.requestId)}
228+
takeDictationRequest={() => takeNewTaskDictationRequest(params.requestId)}
225229
/>
226230
)}
227231
</>

‎apps/mobile/src/features/threads/NewTaskDraftScreen.tsx‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -152,6 +152,7 @@ export function NewTaskDraftScreen(props: {
152152
readonly draftId?: string;
153153
readonly incomingShareId?: string;
154154
readonly autoFocusComposer?: boolean;
155+
readonly takeDictationRequest?: () => boolean;
155156
}) {
156157
const [creationMetadata] = useState(makeTurnCommandMetadata);
157158
const projects = useProjects();
@@ -295,6 +296,11 @@ export function NewTaskDraftScreen(props: {
295296
project.id === props.initialProjectRef?.projectId,
296297
),
297298
);
299+
// The draft opens on the last-used project before switching to the route's; dictation must target the final draft.
300+
const isOnRequestedProject =
301+
selectedProject !== null &&
302+
selectedProject.environmentId === props.initialProjectRef?.environmentId &&
303+
selectedProject.id === props.initialProjectRef.projectId;
298304
const isProjectPickerReturnActive =
299305
isReturningToProjectPicker && !requestedInitialProjectAvailable;
300306
const isIncomingShareAwaitingServerConfig = Boolean(
@@ -1148,6 +1154,7 @@ export function NewTaskDraftScreen(props: {
11481154
),
11491155
editorRef: promptInputRef,
11501156
autoFocus: props.autoFocusComposer ?? false,
1157+
takeDictationRequest: isOnRequestedProject ? props.takeDictationRequest : undefined,
11511158
sendBlockedReason: setupBlockReason,
11521159
interactionLocked: isComposerInteractionLocked,
11531160
}}

‎apps/mobile/src/features/threads/ThreadComposer.tsx‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -218,6 +218,8 @@ export interface ThreadComposerProps {
218218
readonly hidden: boolean;
219219
readonly editorRef?: RefObject<ComposerEditorHandle | null>;
220220
readonly autoFocus?: boolean;
221+
/** Returns true once when this composer should open already dictating. */
222+
readonly takeDictationRequest?: () => boolean;
221223
readonly onChangeDraftMessage: (value: string) => void;
222224
readonly onPickDraftMedia: () => Promise<void>;
223225
readonly onPickDraftFiles: () => Promise<void>;
@@ -554,6 +556,14 @@ export const ThreadComposer = function ThreadComposer(props: ThreadComposerProps
554556
onChangeDraftMessage: (text) => setComposerDraftText(composerDraftKey, text),
555557
onChangeSelection: composerMenu.onSelectionChange,
556558
});
559+
const startRequestedDictation = useEffectEvent(() => {
560+
if (props.takeDictationRequest?.()) voiceInput.start();
561+
});
562+
const hasDictationRequest = props.takeDictationRequest !== undefined;
563+
// oxlint-disable-next-line t3code/react-effect-budget -- The voice shortcut opens a new task already listening; the request is one-shot.
564+
useEffect(() => {
565+
if (hasDictationRequest) startRequestedDictation();
566+
}, [hasDictationRequest]);
557567
const isSubmissionLocked =
558568
props.interactionLocked === true || queuedEdit?.saving === true || voiceInput.blocksSubmission;
559569
const voicePresentation = resolveVoiceComposerPresentation(

‎apps/mobile/src/features/threads/ThreadDetailScreen.tsx‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -207,6 +207,7 @@ export interface ThreadDetailScreenProps {
207207
readonly controls: React.ReactNode;
208208
readonly editorRef: React.RefObject<ComposerEditorHandle | null>;
209209
readonly autoFocus: boolean;
210+
readonly takeDictationRequest: (() => boolean) | undefined;
210211
readonly sendBlockedReason: string | null;
211212
readonly interactionLocked: boolean;
212213
};
@@ -1578,6 +1579,7 @@ function ThreadDetailBody(props: ThreadDetailScreenProps) {
15781579
reportedModelSelection={reportedModelSelection}
15791580
editorRef={composerEditorRef}
15801581
autoFocus={props.draftMode?.autoFocus ?? false}
1582+
takeDictationRequest={props.draftMode?.takeDictationRequest}
15811583
placeholder={
15821584
props.activePendingApproval
15831585
? props.activePendingApproval.supportsFeedback
Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
import { describe, expect, it } from "vite-plus/test";
2+
3+
import {
4+
isNewTaskComposerFocusRequested,
5+
requestNewTaskComposerFocus,
6+
takeNewTaskDictationRequest,
7+
} from "./new-task-composer-focus";
8+
9+
describe("new task composer focus", () => {
10+
it("starts dictation once, then focuses the keyboard when the draft reopens", () => {
11+
requestNewTaskComposerFocus("voice-request", "dictation");
12+
13+
expect(isNewTaskComposerFocusRequested("voice-request")).toBe(false);
14+
expect(takeNewTaskDictationRequest("voice-request")).toBe(true);
15+
expect(takeNewTaskDictationRequest("voice-request")).toBe(false);
16+
expect(isNewTaskComposerFocusRequested("voice-request")).toBe(true);
17+
});
18+
19+
it("never starts dictation for a keyboard request, another draft, or a draft without a request", () => {
20+
requestNewTaskComposerFocus("keyboard-request", "keyboard");
21+
expect(takeNewTaskDictationRequest("keyboard-request")).toBe(false);
22+
expect(isNewTaskComposerFocusRequested("keyboard-request")).toBe(true);
23+
24+
requestNewTaskComposerFocus("voice-request", "dictation");
25+
expect(takeNewTaskDictationRequest("other-request")).toBe(false);
26+
expect(takeNewTaskDictationRequest(undefined)).toBe(false);
27+
expect(isNewTaskComposerFocusRequested(undefined)).toBe(false);
28+
expect(takeNewTaskDictationRequest("voice-request")).toBe(true);
29+
});
30+
});
Lines changed: 20 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,26 @@
1+
export type NewTaskComposerFocus = "keyboard" | "dictation";
2+
13
// Kept out of route params so a restored draft URL never reopens the keyboard; request ids are unique per new task.
2-
let focusedRequestId: string | null = null;
4+
let focusRequest: { readonly requestId: string; readonly focus: NewTaskComposerFocus } | null =
5+
null;
6+
7+
export function requestNewTaskComposerFocus(requestId: string, focus: NewTaskComposerFocus): void {
8+
focusRequest = { requestId, focus };
9+
}
310

4-
export function requestNewTaskComposerFocus(requestId: string): void {
5-
focusedRequestId = requestId;
11+
function requestedFocus(requestId: string | undefined): NewTaskComposerFocus | null {
12+
return requestId !== undefined && focusRequest?.requestId === requestId
13+
? focusRequest.focus
14+
: null;
615
}
716

817
export function isNewTaskComposerFocusRequested(requestId: string | undefined): boolean {
9-
return requestId !== undefined && requestId === focusedRequestId;
18+
return requestedFocus(requestId) === "keyboard";
19+
}
20+
21+
/** Dictation starts once; reopening the same draft focuses the keyboard instead of the microphone. */
22+
export function takeNewTaskDictationRequest(requestId: string | undefined): boolean {
23+
if (requestId === undefined || requestedFocus(requestId) !== "dictation") return false;
24+
focusRequest = { requestId, focus: "keyboard" };
25+
return true;
1026
}

0 commit comments

Comments
 (0)