Skip to content

Commit 25ed99a

Browse files
t3dotggclaude
andcommitted
fix(ci): name the aggregate gate Check so branch protection covers every job
The ruleset already requires a check named Check, so the gate job now uses that name and the lint job becomes Lint. Typecheck, Build, Test Web, and the new server shards are covered without a ruleset change. The gate also rejects skipped jobs, except the macOS native lint, which skips on purpose. Shard weights are refreshed against current main. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
1 parent cf1b008 commit 25ed99a

2 files changed

Lines changed: 40 additions & 38 deletions

File tree

‎.github/workflows/ci.yml‎

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ concurrency:
1515

1616
jobs:
1717
# Lint, typecheck, and the desktop build each get a runner so they run side by
18-
# side instead of one after another. The `CI` job at the end of this file
18+
# side instead of one after another. The `Check` job at the end of this file
1919
# passes only when every other job does.
20-
check:
21-
name: Check
20+
lint:
21+
name: Lint
2222
runs-on: blacksmith-8vcpu-ubuntu-2404
2323
timeout-minutes: 10
2424
steps:
@@ -450,17 +450,17 @@ jobs:
450450
- name: Exercise release-only workflow steps
451451
run: node scripts/release-smoke.ts
452452

453-
# The one check branch protection needs to require. It fails when any other
454-
# job fails or is cancelled, so adding, splitting, or resharding jobs never
455-
# changes the required checks. `always()` rather than `!cancelled()`: a
456-
# skipped job reports success to branch protection, so a cancelled run must
457-
# still produce a failing CI check.
458-
ci:
459-
name: CI
453+
# Branch protection requires this job by its name, `Check`. It fails when any
454+
# other job fails, is cancelled, or is skipped without a reason, so splitting
455+
# or resharding jobs needs no ruleset change. Add every new job to `needs`.
456+
# `always()` rather than `!cancelled()`: a skipped job reports success to
457+
# branch protection, so a cancelled run must still produce a failing check.
458+
check:
459+
name: Check
460460
if: ${{ always() }}
461461
needs:
462462
[
463-
check,
463+
lint,
464464
typecheck,
465465
build,
466466
test,
@@ -479,4 +479,7 @@ jobs:
479479
RESULTS: ${{ toJSON(needs) }}
480480
run: |
481481
echo "$RESULTS" | jq -r 'to_entries[] | "\(.key): \(.value.result)"'
482-
echo "$RESULTS" | jq -e 'all(.[]; .result == "success" or .result == "skipped")' > /dev/null
482+
# Only the macOS lint skips on purpose, when no native mobile code changed.
483+
echo "$RESULTS" | jq -e 'all(to_entries[];
484+
.value.result == "success"
485+
or (.key == "mobile_native_static_analysis" and .value.result == "skipped"))' > /dev/null
Lines changed: 25 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1,41 +1,40 @@
11
{
2-
"integration/orchestrationEngine.integration.test.ts": 1.8,
2+
"integration/orchestrationEngine.integration.test.ts": 1.9,
33
"integration/providerService.integration.test.ts": 0.5,
44
"src/bin.test.ts": 0.8,
55
"src/checkpointing/CheckpointStore.test.ts": 0.6,
6-
"src/device/deviceToolMaintenance.test.ts": 0.5,
7-
"src/device/sshDeviceScript.test.ts": 3,
8-
"src/git/GitManager.test.ts": 16.8,
9-
"src/orchestration/Layers/CheckpointReactor.test.ts": 6.7,
10-
"src/orchestration/Layers/OrchestrationEngine.test.ts": 1.5,
6+
"src/device/sshDeviceScript.test.ts": 2.9,
7+
"src/git/GitManager.test.ts": 18.7,
8+
"src/orchestration/Layers/CheckpointReactor.test.ts": 7.1,
9+
"src/orchestration/Layers/OrchestrationEngine.test.ts": 1.4,
1110
"src/orchestration/Layers/ProjectionPipeline.test.ts": 0.5,
12-
"src/orchestration/Layers/ProviderCommandReactor.test.ts": 4,
13-
"src/orchestration/Layers/ProviderRuntimeIngestion.test.ts": 2.8,
14-
"src/persistence/Layers/OrchestrationEventStore.test.ts": 3.1,
15-
"src/persistence/Layers/Sqlite.test.ts": 0.5,
16-
"src/process/externalLauncher.test.ts": 2.3,
17-
"src/project/AgentSessionScanner.test.ts": 4.4,
18-
"src/provider/Drivers/AntigravityDriver.test.ts": 2.1,
11+
"src/orchestration/Layers/ProviderCommandReactor.test.ts": 3.8,
12+
"src/orchestration/Layers/ProviderRuntimeIngestion.test.ts": 2.4,
13+
"src/persistence/Layers/OrchestrationEventStore.test.ts": 2.2,
14+
"src/process/externalLauncher.test.ts": 2.2,
15+
"src/project/AgentSessionScanner.test.ts": 4.3,
16+
"src/provider/CodexChatGptAuth.test.ts": 5.9,
17+
"src/provider/Drivers/AntigravityDriver.test.ts": 2,
1918
"src/provider/Layers/AntigravityAdapter.test.ts": 0.5,
20-
"src/provider/Layers/ClaudeAdapter.test.ts": 0.8,
19+
"src/provider/Layers/ClaudeAdapter.test.ts": 0.7,
2120
"src/provider/Layers/CodexCollabRuntime.integration.test.ts": 3.4,
22-
"src/provider/Layers/CursorAdapter.test.ts": 8.1,
23-
"src/provider/Layers/CursorProvider.test.ts": 1.5,
24-
"src/provider/Layers/GrokAdapter.test.ts": 8.7,
21+
"src/provider/Layers/CursorAdapter.test.ts": 8,
22+
"src/provider/Layers/CursorProvider.test.ts": 1.4,
23+
"src/provider/Layers/GrokAdapter.test.ts": 9,
2524
"src/provider/Layers/GrokProvider.test.ts": 0.7,
2625
"src/provider/Layers/ProviderService.test.ts": 0.5,
27-
"src/provider/acp/AcpJsonRpcConnection.test.ts": 6.8,
26+
"src/provider/acp/AcpJsonRpcConnection.test.ts": 6.2,
2827
"src/provider/acp/XAiAcpExtension.test.ts": 0.6,
2928
"src/provider/opencodeRuntime.environment.test.ts": 1.1,
30-
"src/pullRequest/PullRequestService.test.ts": 3.4,
31-
"src/server.test.ts": 10.4,
32-
"src/serverSettings.test.ts": 0.6,
29+
"src/pullRequest/PullRequestService.test.ts": 3.1,
30+
"src/server.test.ts": 10.2,
31+
"src/serverSettings.test.ts": 0.5,
3332
"src/serviceLauncher.test.ts": 6.2,
34-
"src/terminal/Manager.test.ts": 1.5,
35-
"src/textGeneration/CodexTextGeneration.test.ts": 0.5,
36-
"src/textGeneration/CursorTextGeneration.test.ts": 0.9,
33+
"src/terminal/Manager.test.ts": 1.6,
34+
"src/textGeneration/CursorTextGeneration.test.ts": 0.8,
3735
"src/textGeneration/GrokTextGeneration.test.ts": 1.2,
38-
"src/vcs/GitVcsDriver.test.ts": 3.4,
39-
"src/vcs/GitVcsDriverCore.test.ts": 6.6,
36+
"src/usage/usageTranscriptStreaming.test.ts": 0.8,
37+
"src/vcs/GitVcsDriver.test.ts": 3.7,
38+
"src/vcs/GitVcsDriverCore.test.ts": 6.5,
4039
"src/workspace/WorkspaceEntries.test.ts": 1.9
4140
}

0 commit comments

Comments
 (0)