Skip to content

Commit 253acde

Browse files
only21milclaude
andauthored
fix(pi): show an extension dialog's title once (#22463)
Co-authored-by: Claude Opus 5.5 <[email protected]>
1 parent 706bf34 commit 253acde

2 files changed

Lines changed: 38 additions & 6 deletions

File tree

‎packages/provider-pi/src/server/adapter.test.ts‎

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3301,6 +3301,34 @@ describe("PiAdapterV2", () => {
33013301
}).pipe(Effect.scoped, Effect.provide(layerTest)),
33023302
);
33033303

3304+
it.effect("keeps an input dialog's title as the header above its placeholder", () =>
3305+
Effect.gen(function* () {
3306+
const fake = yield* makeFakePi;
3307+
const { runtime, takeEvent } = yield* openRuntime(fake);
3308+
yield* runtime.ensureThread({
3309+
threadId: THREAD_ID,
3310+
modelSelection: modelSelection("default"),
3311+
runtimePolicy,
3312+
});
3313+
yield* fake.emit({
3314+
type: "extension_ui_request",
3315+
id: "ui-input-placeholder",
3316+
method: "input",
3317+
title: "Name",
3318+
placeholder: "Your name",
3319+
});
3320+
const event = yield* takeEvent(
3321+
(event) =>
3322+
event.type === "turn_item.updated" && event.turnItem.type === "user_input_request",
3323+
);
3324+
if (event.type !== "turn_item.updated" || event.turnItem.type !== "user_input_request") {
3325+
return assert.fail("expected a user input request");
3326+
}
3327+
assert.equal(event.turnItem.questions[0]?.header, "Name");
3328+
assert.equal(event.turnItem.questions[0]?.question, "Your name");
3329+
}).pipe(Effect.scoped, Effect.provide(layerTest)),
3330+
);
3331+
33043332
it.effect("emits a valid empty select option and returns its original value", () =>
33053333
Effect.gen(function* () {
33063334
const fake = yield* makeFakePi;
@@ -3332,6 +3360,8 @@ describe("PiAdapterV2", () => {
33323360
["Empty value", ""],
33333361
],
33343362
);
3363+
assert.equal(questions[0]?.header, "Question");
3364+
assert.equal(questions[0]?.question, "Pick a tag");
33353365
yield* runtime.respondToRuntimeRequest({
33363366
requestId: event.turnItem.requestId,
33373367
answers: { "ui-select": "" },
@@ -3366,6 +3396,7 @@ describe("PiAdapterV2", () => {
33663396
if (event.type !== "turn_item.updated" || event.turnItem.type !== "user_input_request") {
33673397
return assert.fail("expected a user input request");
33683398
}
3399+
assert.equal(decodeUserInputQuestions(event.turnItem.questions)[0]?.header, "Question");
33693400
assert.equal(decodeUserInputQuestions(event.turnItem.questions)[0]?.question, title);
33703401
yield* runtime.respondToRuntimeRequest({
33713402
requestId: event.turnItem.requestId,
@@ -3401,6 +3432,7 @@ describe("PiAdapterV2", () => {
34013432
return;
34023433
assert.equal(event.turnItem.questions[0]?.initialAnswer, prefill);
34033434
assert.deepEqual(event.turnItem.questions[0]?.options, []);
3435+
assert.equal(event.turnItem.questions[0]?.header, "Question");
34043436
assert.equal(event.turnItem.questions[0]?.question, "Commit message");
34053437
const edited = " fix(server): edited commit message\n\n";
34063438
yield* runtime.respondToRuntimeRequest({

‎packages/provider-pi/src/server/adapter.ts‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3333,15 +3333,15 @@ function piQuestion(
33333333
value: "",
33343334
},
33353335
];
3336+
// Pi's select and editor dialogs carry only a title, so show it once, as the question.
33363337
// Extensions may send a blank placeholder, which is not a valid question.
3337-
const question =
3338-
[recordString(event, "message"), recordString(event, "placeholder")].find(
3339-
(text) => text !== undefined && text.trim().length > 0,
3340-
) ?? title;
3338+
const detail = [recordString(event, "message"), recordString(event, "placeholder")].find(
3339+
(text) => text !== undefined && text.trim().length > 0,
3340+
);
33413341
return {
33423342
id: questionId,
3343-
header: title,
3344-
question,
3343+
header: detail === undefined ? "Question" : title,
3344+
question: detail ?? title,
33453345
...(method === "editor" ? { initialAnswer: recordString(event, "prefill") ?? "" } : {}),
33463346
options,
33473347
};

0 commit comments

Comments
 (0)