Repository navigation
Commit 24be8f1
fix(web): thread details popover closes when the card moves inline
Problem: the thread details card reported its presentation to ChatView
from a layout effect (onPresentationChange), and the card and the
preview mini player each reported their boxes into ChatCanvas state from
layout effects, so every layout change took a second render pass. When
the card switched from popover to inline while the popover was open
(window widened, preview moved away), base-ui kept the unmounted popup
on screen because its exit animation never finished.
Fix: a per-chat-view canvas store holds the canvas measurements and the
card's measured height (tagged with its thread). ChatCanvas and ChatView
derive the card placement and presentation from that store, the inline
flag and the mini player's source, which ChatView now reads through
useThreadPreviewCanvasSource. The popover popup stays mounted in both
modes and only renders content in popover mode, so it closes cleanly.
Effects: ThreadDetailsCard 4 -> 2 (kept: closing a stale popover flag,
which derives from three stores; content measurement driven by density),
ThreadPreviewMiniPlayer 3 -> 1 (kept: pill outside-press listener),
ChatCanvas 1 -> 1 (resize observation), ChatView 18 -> 18.
Co-Authored-By: Claude Opus 5.5 <[email protected]>1 parent 71ba6b3 commit 24be8f1
9 files changed
Lines changed: 674 additions & 244 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
121 | 121 | | |
122 | 122 | | |
123 | 123 | | |
| 124 | + | |
124 | 125 | | |
125 | 126 | | |
126 | 127 | | |
| |||
150 | 151 | | |
151 | 152 | | |
152 | 153 | | |
153 | | - | |
154 | | - | |
155 | | - | |
156 | | - | |
| 154 | + | |
157 | 155 | | |
158 | 156 | | |
159 | 157 | | |
| |||
164 | 162 | | |
165 | 163 | | |
166 | 164 | | |
167 | | - | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
168 | 170 | | |
169 | 171 | | |
170 | 172 | | |
| |||
1004 | 1006 | | |
1005 | 1007 | | |
1006 | 1008 | | |
1007 | | - | |
1008 | | - | |
1009 | 1009 | | |
1010 | | - | |
1011 | | - | |
1012 | | - | |
1013 | | - | |
1014 | | - | |
1015 | | - | |
1016 | | - | |
| 1010 | + | |
1017 | 1011 | | |
1018 | 1012 | | |
1019 | 1013 | | |
| |||
1856 | 1850 | | |
1857 | 1851 | | |
1858 | 1852 | | |
| 1853 | + | |
| 1854 | + | |
| 1855 | + | |
| 1856 | + | |
| 1857 | + | |
| 1858 | + | |
| 1859 | + | |
| 1860 | + | |
| 1861 | + | |
| 1862 | + | |
| 1863 | + | |
| 1864 | + | |
| 1865 | + | |
| 1866 | + | |
| 1867 | + | |
| 1868 | + | |
| 1869 | + | |
| 1870 | + | |
| 1871 | + | |
| 1872 | + | |
| 1873 | + | |
| 1874 | + | |
| 1875 | + | |
| 1876 | + | |
| 1877 | + | |
| 1878 | + | |
| 1879 | + | |
| 1880 | + | |
| 1881 | + | |
| 1882 | + | |
| 1883 | + | |
| 1884 | + | |
| 1885 | + | |
1859 | 1886 | | |
1860 | 1887 | | |
1861 | 1888 | | |
| |||
3184 | 3211 | | |
3185 | 3212 | | |
3186 | 3213 | | |
| 3214 | + | |
| 3215 | + | |
| 3216 | + | |
3187 | 3217 | | |
3188 | 3218 | | |
3189 | 3219 | | |
| |||
3690 | 3720 | | |
3691 | 3721 | | |
3692 | 3722 | | |
3693 | | - | |
3694 | | - | |
3695 | | - | |
3696 | | - | |
| 3723 | + | |
3697 | 3724 | | |
3698 | | - | |
| 3725 | + | |
3699 | 3726 | | |
3700 | | - | |
| 3727 | + | |
3701 | 3728 | | |
3702 | 3729 | | |
3703 | 3730 | | |
| |||
3711 | 3738 | | |
3712 | 3739 | | |
3713 | 3740 | | |
3714 | | - | |
3715 | 3741 | | |
3716 | 3742 | | |
3717 | 3743 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
| 2 | + | |
2 | 3 | | |
3 | | - | |
4 | | - | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
5 | 7 | | |
| 8 | + | |
6 | 9 | | |
7 | 10 | | |
8 | 11 | | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
9 | 15 | | |
10 | 16 | | |
11 | 17 | | |
12 | 18 | | |
13 | 19 | | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
14 | 25 | | |
15 | 26 | | |
16 | 27 | | |
17 | 28 | | |
18 | 29 | | |
19 | 30 | | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
| 31 | + | |
| 32 | + | |
58 | 33 | | |
59 | 34 | | |
60 | 35 | | |
| |||
65 | 40 | | |
66 | 41 | | |
67 | 42 | | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
72 | 52 | | |
73 | 53 | | |
74 | 54 | | |
| |||
78 | 58 | | |
79 | 59 | | |
80 | 60 | | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
| 61 | + | |
89 | 62 | | |
90 | 63 | | |
91 | 64 | | |
92 | 65 | | |
93 | 66 | | |
94 | 67 | | |
95 | 68 | | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | | - | |
102 | | - | |
103 | | - | |
104 | | - | |
105 | | - | |
106 | | - | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
107 | 84 | | |
108 | | - | |
109 | | - | |
110 | | - | |
111 | | - | |
112 | | - | |
113 | | - | |
114 | | - | |
115 | | - | |
116 | | - | |
117 | | - | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
118 | 88 | | |
119 | | - | |
120 | | - | |
121 | 89 | | |
122 | | - | |
123 | | - | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
124 | 94 | | |
125 | 95 | | |
126 | 96 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
3 | | - | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
4 | 12 | | |
5 | 13 | | |
6 | 14 | | |
7 | 15 | | |
8 | 16 | | |
9 | 17 | | |
10 | | - | |
11 | | - | |
12 | 18 | | |
13 | | - | |
| 19 | + | |
14 | 20 | | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
15 | 25 | | |
16 | 26 | | |
17 | 27 | | |
0 commit comments