Skip to content

Commit 233bb09

Browse files
refactor(web): one vertical rhythm for dialog bodies
Dialog bodies set their own rhythm through className: fourteen at space-y-4, three at 3, two at 5, one at 0 with custom padding, and seven with none. That is one rhythm plus drift. DialogPanel now applies space-y-4 in the base and the 27 dialogs drop their classes. Visible effect: three dialogs (SSH password, link pull request, proposed plan save) loosen by 4px between sections; two (theme import, add environment) tighten by 4px; the seven that had no spacing now space their direct children like every other dialog; the shared-policy settings dialog regains the standard 24px side padding. Lowers the no-restyle ceiling from 1089 to 1071. Co-Authored-By: Claude Fable 5 <[email protected]>
1 parent 7723649 commit 233bb09

16 files changed

Lines changed: 30 additions & 26 deletions

‎apps/web/src/components/CustomSnoozeDialog.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ function CustomSnoozeDialog() {
9494
<DialogTitle>Custom snooze</DialogTitle>
9595
<DialogDescription>Choose when snoozed threads return to your inbox.</DialogDescription>
9696
</DialogHeader>
97-
<DialogPanel className="flex flex-col gap-4 text-base sm:text-sm">
97+
<DialogPanel className="text-base sm:text-sm">
9898
<Tabs.Root
9999
value={mode}
100100
onValueChange={(value) => {

‎apps/web/src/components/GitActionsControl.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1882,7 +1882,7 @@ export default function GitActionsControl({
18821882
<DialogTitle>{COMMIT_DIALOG_TITLE}</DialogTitle>
18831883
<DialogDescription>{COMMIT_DIALOG_DESCRIPTION}</DialogDescription>
18841884
</DialogHeader>
1885-
<DialogPanel className="space-y-4">
1885+
<DialogPanel>
18861886
<div className="space-y-3 rounded-xl bg-zinc-25 p-3 text-sm ring-1 ring-black/5 dark:bg-white/[0.035] dark:ring-white/5">
18871887
<div className="grid grid-cols-[auto_1fr] items-center gap-x-2 gap-y-1">
18881888
<span className="text-muted-foreground">Branch</span>

‎apps/web/src/components/LegacySidebar.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2514,7 +2514,7 @@ const SidebarProjectItem = memo(function SidebarProjectItem(props: SidebarProjec
25142514
: "Update the project title."}
25152515
</DialogDescription>
25162516
</DialogHeader>
2517-
<DialogPanel className="space-y-4">
2517+
<DialogPanel>
25182518
<div className="grid gap-1.5">
25192519
<span className="text-xs font-medium text-foreground">Project title</span>
25202520
<Input
@@ -2561,7 +2561,7 @@ const SidebarProjectItem = memo(function SidebarProjectItem(props: SidebarProjec
25612561
: "Choose how this project should be grouped in the sidebar."}
25622562
</DialogDescription>
25632563
</DialogHeader>
2564-
<DialogPanel className="space-y-4">
2564+
<DialogPanel>
25652565
<div className="grid gap-1.5">
25662566
<span className="text-xs font-medium text-foreground">Grouping rule</span>
25672567
<Select

‎apps/web/src/components/PullRequestThreadDialog.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ export function PullRequestThreadDialog({
205205
the draft thread in the main repo or in a dedicated worktree.
206206
</DialogDescription>
207207
</DialogHeader>
208-
<DialogPanel className="space-y-4">
208+
<DialogPanel>
209209
<label className="grid gap-1.5">
210210
<span className="text-xs font-medium text-foreground capitalize">
211211
{terminology.singular}

‎apps/web/src/components/chat/ProposedPlanCard.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ export const ProposedPlanCard = memo(function ProposedPlanCard({
223223
Enter a path relative to <code>{workspaceRoot ?? "the workspace"}</code>.
224224
</DialogDescription>
225225
</DialogHeader>
226-
<DialogPanel className="space-y-3">
226+
<DialogPanel>
227227
<label htmlFor={savePathInputId} className="grid gap-1.5">
228228
<span className="text-xs font-medium text-foreground">Workspace path</span>
229229
<Input

‎apps/web/src/components/desktop/SshPasswordPromptDialog.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ function ActiveSshPasswordPrompt({
164164
to the local SSH process for this connection attempt and is not saved by T3 Code.
165165
</DialogDescription>
166166
</DialogHeader>
167-
<DialogPanel className="space-y-3" scrollFade={false}>
167+
<DialogPanel scrollFade={false}>
168168
<form
169169
className="space-y-3"
170170
id={formId}

‎apps/web/src/components/pullRequest/LinkPullRequestDialog.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ function LinkPullRequestDialog({
208208
this environment has a project for.
209209
</DialogDescription>
210210
</DialogHeader>
211-
<DialogPanel className="space-y-3">
211+
<DialogPanel>
212212
<Input
213213
ref={inputRef}
214214
placeholder="Pull request URL or #42"

‎apps/web/src/components/settings/BrowserImportWizard.tsx‎

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -490,9 +490,11 @@ function ImportingStep() {
490490
<DialogTitle>Importing cookies</DialogTitle>
491491
<DialogDescription>This may take a moment.</DialogDescription>
492492
</DialogHeader>
493-
<DialogPanel className="flex items-center gap-3 py-6">
494-
<Spinner size="md" tone="muted" />
495-
<span className="text-sm text-muted-foreground">Importing…</span>
493+
<DialogPanel>
494+
<div className="flex items-center gap-3 py-2">
495+
<Spinner size="md" tone="muted" />
496+
<span className="text-sm text-muted-foreground">Importing…</span>
497+
</div>
496498
</DialogPanel>
497499
</>
498500
);
@@ -515,11 +517,13 @@ function CheckingStep({
515517
: "Checking whether the browser has closed."}
516518
</DialogDescription>
517519
</DialogHeader>
518-
<DialogPanel className="flex items-center gap-3 py-6">
519-
<Spinner size="md" tone="muted" />
520-
<span className="text-sm text-muted-foreground">
521-
{check === "fullDiskAccess" ? "Checking access…" : "Checking…"}
522-
</span>
520+
<DialogPanel>
521+
<div className="flex items-center gap-3 py-2">
522+
<Spinner size="md" tone="muted" />
523+
<span className="text-sm text-muted-foreground">
524+
{check === "fullDiskAccess" ? "Checking access…" : "Checking…"}
525+
</span>
526+
</div>
523527
</DialogPanel>
524528
</>
525529
);

‎apps/web/src/components/settings/ConnectionsSettings.tsx‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -828,7 +828,7 @@ const PairingLinkListRow = memo(function PairingLinkListRow({
828828
: "Clipboard copy is unavailable here. Manually copy this code into another client."}
829829
</DialogDescription>
830830
</DialogHeader>
831-
<DialogPanel className="space-y-4">
831+
<DialogPanel>
832832
<Textarea
833833
readOnly
834834
value={revealValue}
@@ -1133,7 +1133,7 @@ const AuthorizedClientsHeaderAction = memo(function AuthorizedClientsHeaderActio
11331133
authorized client.
11341134
</DialogDescription>
11351135
</DialogHeader>
1136-
<DialogPanel className="space-y-5">
1136+
<DialogPanel>
11371137
<label className="block">
11381138
<span className="mb-1.5 block text-xs font-medium text-foreground">
11391139
Client label (optional)
@@ -3602,7 +3602,7 @@ export function ConnectionsSettings() {
36023602
Tailscale to proxy HTTPS traffic to this backend.
36033603
</DialogDescription>
36043604
</DialogHeader>
3605-
<DialogPanel className="space-y-4">
3605+
<DialogPanel>
36063606
<label className="block">
36073607
<span className="text-sm font-medium text-foreground">HTTPS port</span>
36083608
<Input

‎apps/web/src/components/settings/DeviceHostEditor.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ export function DeviceHostEditor({
7272
Hosts on the same machine are skipped.
7373
</DialogDescription>
7474
</DialogHeader>
75-
<DialogPanel className="space-y-4">
75+
<DialogPanel>
7676
<label className="block space-y-1.5 text-sm">
7777
<span>Name</span>
7878
<Input

0 commit comments

Comments
 (0)