Skip to content

Commit 22a0ac5

Browse files
juliusmarmingecodex
andcommitted
fix(mobile): remove settings from filter menu
Co-authored-by: codex <[email protected]>
1 parent 8e1aa32 commit 22a0ac5

3 files changed

Lines changed: 1 addition & 13 deletions

File tree

‎apps/mobile/src/features/home/HomeHeader.tsx‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -385,10 +385,6 @@ function IosHomeHeader(props: HomeHeaderProps) {
385385
title="Thread list options"
386386
separateBackground
387387
>
388-
<NativeHeaderToolbar.MenuAction onPress={props.onOpenSettings}>
389-
<NativeHeaderToolbar.Label>Settings</NativeHeaderToolbar.Label>
390-
</NativeHeaderToolbar.MenuAction>
391-
392388
<NativeHeaderToolbar.Menu title="Environment">
393389
<NativeHeaderToolbar.Label>Environment</NativeHeaderToolbar.Label>
394390
<NativeHeaderToolbar.MenuAction

‎apps/mobile/src/features/home/home-list-filter-menu.test.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ describe("buildHomeListFilterMenu", () => {
2424
const projectMenu = menu.items.find(
2525
(item) => item.type === "submenu" && item.title === "Project",
2626
);
27+
expect(menu.items.some((item) => item.title === "Settings")).toBe(false);
2728
expect(projectMenu).toMatchObject({
2829
type: "submenu",
2930
items: [

‎apps/mobile/src/features/home/home-list-filter-menu.ts‎

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -43,22 +43,13 @@ export function buildHomeListFilterMenu(props: {
4343
readonly onProjectChange: (projectKey: string | null) => void;
4444
readonly onProjectSortOrderChange: (sortOrder: HomeProjectSortOrder) => void;
4545
readonly onThreadSortOrderChange: (sortOrder: SidebarThreadSortOrder) => void;
46-
readonly onOpenSettings?: () => void;
4746
/** False hides the sort/group submenus. Thread List v2 uses a fixed
4847
creation-order layout, so offering those controls while it silently
4948
ignores them would be a lie; the environment filter still applies. */
5049
readonly listOrganization?: boolean;
5150
}): HomeListFilterMenu {
5251
const items: Array<HomeListFilterMenuAction | HomeListFilterMenuSubmenu> = [];
5352

54-
if (props.onOpenSettings) {
55-
items.push({
56-
type: "action",
57-
title: "Settings",
58-
onPress: props.onOpenSettings,
59-
});
60-
}
61-
6253
items.push({
6354
type: "submenu",
6455
title: "Environment",

0 commit comments

Comments
 (0)